From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] ntp: prevent keyword-gen failure during ntp_keyword.h check
Date: Fri, 18 Jul 2014 21:26:58 +0200 [thread overview]
Message-ID: <20140718212658.06acda90@free-electrons.com> (raw)
In-Reply-To: <1405655815-2025-2-git-send-email-danomimanchego123@gmail.com>
Dear Danomi Manchego,
On Thu, 17 Jul 2014 23:56:54 -0400, Danomi Manchego wrote:
> During the first compile, the keyword-gen check is not run. However,
> it gets run on the first rebuild. Because we are cross-compiling, the
> keyword-gen can't run on the host. Since this is only used to check if
> ntp_keyword.h is up to date, we simply drop the check altogether.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
I haven't applied this one, because I'm not entirely satisfied by the
explanation here. Why isn't the keyword-gen check executed on the first
run? I did some testing, and I indeed don't see the rule about
ntp_keyword.h being evaluated on the first build. Do you have more
details about what makes the difference between the first and
subsequent builds?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-18 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 3:56 [Buildroot] [PATCH 1/2] ntp: rename patches to follow BR guidelines Danomi Manchego
2014-07-18 3:56 ` [Buildroot] [PATCH 2/2] ntp: prevent keyword-gen failure during ntp_keyword.h check Danomi Manchego
2014-07-18 19:26 ` Thomas Petazzoni [this message]
2014-07-19 0:52 ` Danomi Manchego
2014-07-19 8:38 ` Thomas Petazzoni
2014-07-18 19:25 ` [Buildroot] [PATCH 1/2] ntp: rename patches to follow BR guidelines Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140718212658.06acda90@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox