Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] ntp: prevent keyword-gen failure during ntp_keyword.h check
Date: Sat, 19 Jul 2014 10:38:58 +0200	[thread overview]
Message-ID: <20140719103858.43d6540d@free-electrons.com> (raw)
In-Reply-To: <CANxTyt41syqHG2BGF9mHMd9C_f8ztmNwtADFmDE9N7ZBiNF_OA@mail.gmail.com>

Dear Danomi Manchego,

On Fri, 18 Jul 2014 20:52:18 -0400, Danomi Manchego wrote:

> > I haven't applied this one, because I'm not entirely satisfied by the
> > explanation here. Why isn't the keyword-gen check executed on the first
> > run? I did some testing, and I indeed don't see the rule about
> > ntp_keyword.h being evaluated on the first build. Do you have more
> > details about what makes the difference between the first and
> > subsequent builds?
> 
> No.  Stranger yet, when the patch is applied, I found that the
> keyword-gen check is only run on the *first* ntp-rebuild.  Further
> ntp-rebuilds do not cause the check to re-occur.
> 
> But anyway, I didn't notice any indication that the keyword-gen would
> be compiled with a HOSTCC, so I reasoned that if it's cross-compiled,
> then it shouldn't be run on the build machine in any circumstance.  So
> I didn't investigate further.

Right, but the ntp source code comes with a pre-generated result of
this keyword-gen program, which allows the first build to work
properly. So it'd be good to understand why this logic used for the
first build doesn't work for the subsequent builds.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-07-19  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  3:56 [Buildroot] [PATCH 1/2] ntp: rename patches to follow BR guidelines Danomi Manchego
2014-07-18  3:56 ` [Buildroot] [PATCH 2/2] ntp: prevent keyword-gen failure during ntp_keyword.h check Danomi Manchego
2014-07-18 19:26   ` Thomas Petazzoni
2014-07-19  0:52     ` Danomi Manchego
2014-07-19  8:38       ` Thomas Petazzoni [this message]
2014-07-18 19:25 ` [Buildroot] [PATCH 1/2] ntp: rename patches to follow BR guidelines Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140719103858.43d6540d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox