[Buildroot] [git commit] google-breakpad: disable on mips64

[Buildroot] [git commit] google-breakpad: disable on mips64

[Thomas Petazzoni]

commit: http://git.buildroot.net/buildroot/commit/?id=7ef750f4a408322e23fc2aaa822e7afa14bcbbe7
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Due to some mmap() related issue, google-breakpad fails to build on
mips64, so let's disable it for the moment. The mips/mips64 folks
might be interested in fixing that later.

Fixes:

  http://autobuild.buildroot.org/results/2b0/2b03937693ea400ddcc7e8364ff7dc22ce651669/

Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Cc: Markos Chandras <Markos.Chandras@imgtec.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/google-breakpad/Config.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index 0ef10c5..146db36 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	bool
 	default y if BR2_i386 || BR2_x86_64 || BR2_arm || BR2_aarch64 || \
-		BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
+		BR2_mips || BR2_mipsel
 
 config BR2_PACKAGE_GOOGLE_BREAKPAD
 	bool "google-breakpad"

[Buildroot] [git commit] google-breakpad: disable on mips64

[Baruch Siach]

Hi Thomas,

On Sat, Jul 19, 2014 at 06:34:39PM +0200, Thomas Petazzoni wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=7ef750f4a408322e23fc2aaa822e7afa14bcbbe7
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> Due to some mmap() related issue, google-breakpad fails to build on
> mips64, so let's disable it for the moment. The mips/mips64 folks
> might be interested in fixing that later.
> 
> Fixes:
> 
>   http://autobuild.buildroot.org/results/2b0/2b03937693ea400ddcc7e8364ff7dc22ce651669/
> 
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Cc: Markos Chandras <Markos.Chandras@imgtec.com>

Interesting. As this patch never appeared on the list before, does the git 
commits mail sending script actually Cc these addresses?

baruch

> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/google-breakpad/Config.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
> index 0ef10c5..146db36 100644
> --- a/package/google-breakpad/Config.in
> +++ b/package/google-breakpad/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
>  	bool
>  	default y if BR2_i386 || BR2_x86_64 || BR2_arm || BR2_aarch64 || \
> -		BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
> +		BR2_mips || BR2_mipsel
>  
>  config BR2_PACKAGE_GOOGLE_BREAKPAD
>  	bool "google-breakpad"
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [git commit] google-breakpad: disable on mips64

[Thomas Petazzoni]

Dear Baruch Siach,

On Sun, 20 Jul 2014 06:47:19 +0300, Baruch Siach wrote:

> On Sat, Jul 19, 2014 at 06:34:39PM +0200, Thomas Petazzoni wrote:
> > commit: http://git.buildroot.net/buildroot/commit/?id=7ef750f4a408322e23fc2aaa822e7afa14bcbbe7
> > branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> > 
> > Due to some mmap() related issue, google-breakpad fails to build on
> > mips64, so let's disable it for the moment. The mips/mips64 folks
> > might be interested in fixing that later.
> > 
> > Fixes:
> > 
> >   http://autobuild.buildroot.org/results/2b0/2b03937693ea400ddcc7e8364ff7dc22ce651669/
> > 
> > Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > Cc: Markos Chandras <Markos.Chandras@imgtec.com>
> 
> Interesting. As this patch never appeared on the list before, does the git 
> commits mail sending script actually Cc these addresses?

No, it was a mistake from my side: I did had these Cc: lines as I was
planning on sending the mail to the list (to get Vicente and Markos
informed of the issue), and then only apply the patch. Unfortunately,
in the mean time, I applied other patches and I pushed everything.

Let's Cc them now :-)

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [git commit] google-breakpad: disable on mips64

[Markos Chandras]

On 07/20/2014 09:28 AM, Thomas Petazzoni wrote:
> Dear Baruch Siach,
> 
> On Sun, 20 Jul 2014 06:47:19 +0300, Baruch Siach wrote:
> 
>> On Sat, Jul 19, 2014 at 06:34:39PM +0200, Thomas Petazzoni wrote:
>>> commit: http://git.buildroot.net/buildroot/commit/?id=7ef750f4a408322e23fc2aaa822e7afa14bcbbe7
>>> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>>
>>> Due to some mmap() related issue, google-breakpad fails to build on
>>> mips64, so let's disable it for the moment. The mips/mips64 folks
>>> might be interested in fixing that later.
>>>
>>> Fixes:
>>>
>>>   http://autobuild.buildroot.org/results/2b0/2b03937693ea400ddcc7e8364ff7dc22ce651669/
>>>
>>> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>> Cc: Markos Chandras <Markos.Chandras@imgtec.com>
>>
>> Interesting. As this patch never appeared on the list before, does the git 
>> commits mail sending script actually Cc these addresses?
> 
> No, it was a mistake from my side: I did had these Cc: lines as I was
> planning on sending the mail to the list (to get Vicente and Markos
> informed of the issue), and then only apply the patch. Unfortunately,
> in the mean time, I applied other patches and I pushed everything.
> 
> Let's Cc them now :-)
> 
> Thanks,
> 
> Thomas
> 
Hi Thomas,

This has been reported upstream so disabling this option for MIPS64 is
fine for now.

https://code.google.com/p/google-breakpad/issues/detail?id=599&sort=-id
https://code.google.com/p/linux-syscall-support/issues/detail?id=7

Thanks for letting us know.

-- 
markos