Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ezequiel García" <ezequiel@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] u-boot: Allow to specify a list of patches
Date: Mon, 21 Jul 2014 16:55:43 -0300	[thread overview]
Message-ID: <20140721195543.GA23072@arch.cereza> (raw)
In-Reply-To: <53C85A27.2060907@mind.be>

Hi everyone,

On 18 Jul 01:20 AM, Arnout Vandecappelle wrote:
[..]
> >>>>>
> >>>>> Thomas, was there a specific reason we wanted the patches to be
> >>>>> PKG-prefixed? If not, would it make sense to just accept patches without
> >>>>> a PKG-prefix?
> >>>>
> >>>> Er, we don't... We require this specific naming scheme for contributed
> >>>> packages, but the code itself just takes *.patch.
> >>>
> >>> Yes sure, it's a convention only, but the question is: why did we include the package name in the convention?
> >>
> >>  I think it's purely historical. And I think it never was required for patches
> >> in a <pkgname> subdir.
> > 
> > So we could change the manual to not require patches to be PKG-prefixed?
> > 
> > As long as they are number-prefixed, that's all we need, right?
> > 
> > So, Ezequiel's patch is really no longer needed, and his use-case to use
> > git-formatted patches is already covered, right?
> 
>  Yep.
> 
>  Untested, of course :-)
> 

I did a quick test in here. It seems GLOBAL_PATCH_DIR works perfectly,
and it's a lot cleaner than having N options, one for each supposedly special
package, as it's keeps all the modification to vanilla in one place.

So I strongly support removing all the UBOOT_PATCH, LINUX_PATCH, and any other
FOO_PATCH options out there.

Any brave hacker stepping up? :)
-- 
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

      reply	other threads:[~2014-07-21 19:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 18:26 [Buildroot] [PATCH] u-boot: Allow to specify a list of patches Ezequiel Garcia
2014-07-15 18:53 ` Thomas Petazzoni
2014-07-15 19:49   ` Ezequiel García
2014-07-15 20:13     ` Yann E. MORIN
2014-07-15 20:35       ` Thomas Petazzoni
2014-07-16  5:21         ` Thomas De Schampheleire
2014-07-16 22:23       ` Arnout Vandecappelle
2014-07-17  4:52         ` Thomas De Schampheleire
2014-07-17  7:48           ` Arnout Vandecappelle
2014-07-17 17:23             ` Yann E. MORIN
2014-07-17 23:20               ` Arnout Vandecappelle
2014-07-21 19:55                 ` Ezequiel García [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140721195543.GA23072@arch.cereza \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox