From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] u-boot: Allow to specify a list of patches
Date: Thu, 17 Jul 2014 09:48:24 +0200 [thread overview]
Message-ID: <53C77FC8.6060303@mind.be> (raw)
In-Reply-To: <29128166-5526-4da5-804d-72225bc05bc1@email.android.com>
On 17/07/14 06:52, Thomas De Schampheleire wrote:
> Arnout Vandecappelle <arnout@mind.be> schreef:
>> On 15/07/14 22:13, Yann E. MORIN wrote:
>>> The more I think about it, the more I find our policy to require
>>> PKG-prefixed patches to be really cumbersome, since the patches already
>>> are in a subdir named PKG/
>>>
>>> Of course, we're enforcing this naming scheme in BR2_GLOBAL_PATCH_DIR to
>>> be in sync with what we do for our bundled patches.
>>>
>>> But still, if patches were just named NNNN-title.patch, that would be as
>>> efficient at sorting the patches. The PKG- prefix is not really
>>> required, and indeed can cause some troubles with some use-cases, such
>>> as yours.
>>>
>>> Thomas, was there a specific reason we wanted the patches to be
>>> PKG-prefixed? If not, would it make sense to just accept patches without
>>> a PKG-prefix?
>>
>> Er, we don't... We require this specific naming scheme for contributed
>> packages, but the code itself just takes *.patch.
>
> Yes sure, it's a convention only, but the question is: why did we include the package name in the convention?
I think it's purely historical. And I think it never was required for patches
in a <pkgname> subdir.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2014-07-17 7:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 18:26 [Buildroot] [PATCH] u-boot: Allow to specify a list of patches Ezequiel Garcia
2014-07-15 18:53 ` Thomas Petazzoni
2014-07-15 19:49 ` Ezequiel García
2014-07-15 20:13 ` Yann E. MORIN
2014-07-15 20:35 ` Thomas Petazzoni
2014-07-16 5:21 ` Thomas De Schampheleire
2014-07-16 22:23 ` Arnout Vandecappelle
2014-07-17 4:52 ` Thomas De Schampheleire
2014-07-17 7:48 ` Arnout Vandecappelle [this message]
2014-07-17 17:23 ` Yann E. MORIN
2014-07-17 23:20 ` Arnout Vandecappelle
2014-07-21 19:55 ` Ezequiel García
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C77FC8.6060303@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox