From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 2] generic packages: rename FOO_CONFIGURE_OPTS into FOO_CONFIGURE_OPT
Date: Sun, 27 Jul 2014 15:22:23 +0200 [thread overview]
Message-ID: <20140727152223.38c38d68@free-electrons.com> (raw)
In-Reply-To: <5b961fc80eb2d23373a6.1406056892@localhost>
Dear Thomas De Schampheleire,
On Tue, 22 Jul 2014 21:21:32 +0200, Thomas De Schampheleire wrote:
> As FOO_MAKE_OPTS has been renamed to FOO_MAKE_OPT, this patch renames
> FOO_CONFIGURE_OPTS into FOO_CONFIGURE_OPT for symmetry reasons.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
>
> ---
> Note: TARGET_CONFIGURE_OPTS has not been changed since the impact is very
> large. It would make sense to change it too, though, so let me know what you
> think.
Yeah, I'm a bit worried with the discrepancy between
TARGET_CONFIGURE_OPTS, TARGET_CONFIGURE_ARGS, HOST_CONFIGURE_OPTS and
HOST_CONFIGURE_ARGS that use the plural form, vs those per-package
<foobar>_OPT options.
My feeling is that the plural form looks more logical, so instead of
moving from _OPTS to _OPT, I'd rather like to see a move from _OPT to
_OPTS. But that indeed involves changing a *lot* of packages.
What do others think?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-27 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 19:21 [Buildroot] [PATCH 1 of 2] generic packages: rename FOO_MAKE_OPTS into FOO_MAKE_OPT Thomas De Schampheleire
2014-07-22 19:21 ` [Buildroot] [PATCH 2 of 2] generic packages: rename FOO_CONFIGURE_OPTS into FOO_CONFIGURE_OPT Thomas De Schampheleire
2014-07-27 13:22 ` Thomas Petazzoni [this message]
2014-07-27 14:33 ` Thomas De Schampheleire
2014-07-27 20:27 ` Yann E. MORIN
2014-07-27 20:55 ` Thomas Petazzoni
2014-07-29 8:40 ` Thomas De Schampheleire
2014-07-22 19:55 ` [Buildroot] [PATCH 1 of 2] generic packages: rename FOO_MAKE_OPTS into FOO_MAKE_OPT Thomas De Schampheleire
2014-07-22 20:26 ` Yann E. MORIN
2014-07-23 5:21 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727152223.38c38d68@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox