From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 2] generic packages: rename FOO_CONFIGURE_OPTS into FOO_CONFIGURE_OPT
Date: Sun, 27 Jul 2014 22:55:29 +0200 [thread overview]
Message-ID: <20140727225529.518feb68@free-electrons.com> (raw)
In-Reply-To: <20140727202710.GI3895@free.fr>
Dear Yann E. MORIN,
On Sun, 27 Jul 2014 22:27:10 +0200, Yann E. MORIN wrote:
> > We could add a simple check to warn users of _OPT, but not more than that.
>
> OK, I'm siding with you guys. OK for the renaming.
>
> But then we should add a check that the old variable gets used, and
> _error out_ in such case. If we just warn, the warning will be lost
> amongst all the other messages, nad will bbe missed; and suddenly,
> br2-external packages fails to build, or build in an unexpected
> configuration.
>
> I agree with you that we should just check if the old variable is set,
> but we should not try to correct the situation.
I fully agree with this: we should error out if the old variable is
used, so that things are clearly noticed by users.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-07-27 20:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 19:21 [Buildroot] [PATCH 1 of 2] generic packages: rename FOO_MAKE_OPTS into FOO_MAKE_OPT Thomas De Schampheleire
2014-07-22 19:21 ` [Buildroot] [PATCH 2 of 2] generic packages: rename FOO_CONFIGURE_OPTS into FOO_CONFIGURE_OPT Thomas De Schampheleire
2014-07-27 13:22 ` Thomas Petazzoni
2014-07-27 14:33 ` Thomas De Schampheleire
2014-07-27 20:27 ` Yann E. MORIN
2014-07-27 20:55 ` Thomas Petazzoni [this message]
2014-07-29 8:40 ` Thomas De Schampheleire
2014-07-22 19:55 ` [Buildroot] [PATCH 1 of 2] generic packages: rename FOO_MAKE_OPTS into FOO_MAKE_OPT Thomas De Schampheleire
2014-07-22 20:26 ` Yann E. MORIN
2014-07-23 5:21 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140727225529.518feb68@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox