From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ptpd2: fix static linking
Date: Thu, 31 Jul 2014 20:19:54 +0200 [thread overview]
Message-ID: <20140731201954.586efea1@free-electrons.com> (raw)
In-Reply-To: <1406758585-24577-1-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Wed, 30 Jul 2014 19:16:25 -0300, Gustavo Zacarias wrote:
> Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d
> to avoid missing libraries needed by libpcap. Fixes:
> http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/ptpd2/ptpd2.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/ptpd2/ptpd2.mk b/package/ptpd2/ptpd2.mk
> index 3133726..6a6ae60 100644
> --- a/package/ptpd2/ptpd2.mk
> +++ b/package/ptpd2/ptpd2.mk
> @@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
> PTPD2_LICENSE = BSD-2c
> PTPD2_LICENSE_FILES = COPYRIGHT
>
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> + PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
> +endif
> +
Applied, thanks. However, I continue to be worried about all those
fixups we do all over the place for static linking, instead of fixing
upstream properly. If upstream suddenly fixes static linking, we won't
even notice.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-07-31 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 22:16 [Buildroot] [PATCH] ptpd2: fix static linking Gustavo Zacarias
2014-07-31 18:19 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140731201954.586efea1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox