Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] ptpd2: fix static linking
@ 2014-07-30 22:16 Gustavo Zacarias
  2014-07-31 18:19 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo Zacarias @ 2014-07-30 22:16 UTC (permalink / raw)
  To: buildroot

Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d
to avoid missing libraries needed by libpcap. Fixes:
http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/ptpd2/ptpd2.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/ptpd2/ptpd2.mk b/package/ptpd2/ptpd2.mk
index 3133726..6a6ae60 100644
--- a/package/ptpd2/ptpd2.mk
+++ b/package/ptpd2/ptpd2.mk
@@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
 PTPD2_LICENSE = BSD-2c
 PTPD2_LICENSE_FILES = COPYRIGHT
 
+ifeq ($(BR2_PREFER_STATIC_LIB),y)
+	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
+endif
+
 ifeq ($(BR2_PACKAGE_NETSNMP),y)
 	PTPD2_CONF_ENV += ac_cv_path_PATH_NET_SNMP_CONFIG=$(STAGING_DIR)/usr/bin/net-snmp-config
 	PTPD2_DEPENDENCIES += netsnmp
-- 
1.8.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] ptpd2: fix static linking
  2014-07-30 22:16 [Buildroot] [PATCH] ptpd2: fix static linking Gustavo Zacarias
@ 2014-07-31 18:19 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-07-31 18:19 UTC (permalink / raw)
  To: buildroot

Dear Gustavo Zacarias,

On Wed, 30 Jul 2014 19:16:25 -0300, Gustavo Zacarias wrote:
> Do the same as in commit b64a06d7b70bd7b160826bf9b97e60e18171913d
> to avoid missing libraries needed by libpcap. Fixes:
> http://autobuild.buildroot.net/results/1a1/1a1dadfa2b22074d401b013606f0cede66efe826/
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  package/ptpd2/ptpd2.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/ptpd2/ptpd2.mk b/package/ptpd2/ptpd2.mk
> index 3133726..6a6ae60 100644
> --- a/package/ptpd2/ptpd2.mk
> +++ b/package/ptpd2/ptpd2.mk
> @@ -13,6 +13,10 @@ PTPD2_AUTORECONF = YES
>  PTPD2_LICENSE = BSD-2c
>  PTPD2_LICENSE_FILES = COPYRIGHT
>  
> +ifeq ($(BR2_PREFER_STATIC_LIB),y)
> +	PTPD2_CONF_OPT += LIBS="$(shell $(STAGING_DIR)/usr/bin/pcap-config --static --additional-libs)"
> +endif
> +

Applied, thanks. However, I continue to be worried about all those
fixups we do all over the place for static linking, instead of fixing
upstream properly. If upstream suddenly fixes static linking, we won't
even notice.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-31 18:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-30 22:16 [Buildroot] [PATCH] ptpd2: fix static linking Gustavo Zacarias
2014-07-31 18:19 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox