Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4 of 6 v2] uclibc: only add targets if uclibc is enabled
Date: Thu, 31 Jul 2014 23:13:38 +0200	[thread overview]
Message-ID: <20140731231338.205114b3@free-electrons.com> (raw)
In-Reply-To: <540167f28c2d41530ceb.1406750285@localhost>

Dear Thomas De Schampheleire,

On Wed, 30 Jul 2014 21:58:05 +0200, Thomas De Schampheleire wrote:

> In analogy of linux.mk, only enable its targets (in particular the kconfig
> targets (menuconfig, update-config, ...) when the uclibc package is actually
> enabled.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
> 
> ---
> v2: rebase after making kconfig-package a full infra
> 
> Note: now that kconfig-package is a full package infra (inheriting from
> generic-package) this may seem a bit odd, as other packages do not do this.
> Nevertheless, it does not hurt and will slightly improve the parsing of the
> Makefiles when the package is not selected.
> 
>  package/uclibc/uclibc.mk |  2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff -r 083076145a2b -r 540167f28c2d package/uclibc/uclibc.mk
> --- a/package/uclibc/uclibc.mk	Tue Jul 22 20:35:36 2014 +0200
> +++ b/package/uclibc/uclibc.mk	Wed Jul 23 20:12:32 2014 +0200
> @@ -539,7 +539,9 @@
>  	$(UCLIBC_INSTALL_UTILS_STAGING)
>  endef
>  
> +ifeq ($(BR2_TOOLCHAIN_BUILDROOT_UCLIBC),y)
>  $(eval $(kconfig-package))
> +endif

I actually don't like this that much, because I like a lot the fact
that I can do "make <foo>-source" "make <foo>-extract", "make
<foo>-patch" or even "make <foo>" (though this last case, for the
specific situation of uClibc doesn't seem really possible).

Though it's true it can be considered a bit strange to allow "make
<foo>-patch" but not "make <foo>-menuconfig".

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-07-31 21:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-30 19:58 [Buildroot] [PATCH 0 of 6 v2] Introduction of kconfig-package Thomas De Schampheleire
2014-07-30 19:58 ` [Buildroot] [PATCH 1 of 6 v2] infra: introduce a kconfig-package infrastructure Thomas De Schampheleire
2014-07-31 20:42   ` Yann E. MORIN
2014-08-01 19:22     ` Thomas De Schampheleire
2014-07-30 19:58 ` [Buildroot] [PATCH 2 of 6 v2] manual: add documentation for kconfig-package Thomas De Schampheleire
2014-07-31 21:03   ` Yann E. MORIN
2014-07-30 19:58 ` [Buildroot] [PATCH 3 of 6 v2] uclibc: convert to kconfig-package infrastructure Thomas De Schampheleire
2014-07-31 21:07   ` Yann E. MORIN
2014-08-01 19:42     ` Thomas De Schampheleire
2014-08-01 20:21       ` Yann E. MORIN
2014-07-30 19:58 ` [Buildroot] [PATCH 4 of 6 v2] uclibc: only add targets if uclibc is enabled Thomas De Schampheleire
2014-07-31 21:08   ` Yann E. MORIN
2014-07-31 21:13   ` Thomas Petazzoni [this message]
2014-08-01 19:37     ` Thomas De Schampheleire
2014-08-01 20:38       ` Yann E. MORIN
2014-07-30 19:58 ` [Buildroot] [PATCH 5 of 6 v2] busybox: convert to kconfig-package infrastructure Thomas De Schampheleire
2014-07-31 21:53   ` Yann E. MORIN
2014-07-30 19:58 ` [Buildroot] [PATCH 6 of 6 v2] busybox: only add kconfig targets if uclibc is enabled Thomas De Schampheleire
2014-07-31 21:12   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140731231338.205114b3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox