* [Buildroot] [PATCH] glm: Added package
@ 2014-08-05 22:59 Paul Cercueil
2014-08-06 3:10 ` Baruch Siach
2014-08-06 20:12 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Paul Cercueil @ 2014-08-05 22:59 UTC (permalink / raw)
To: buildroot
OpenGL Mathematics (GLM) is a header only C++ mathematics library for
graphics software based on the OpenGL Shading Language (GLSL)
specification.
http://glm.g-truc.net/
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
package/Config.in | 1 +
package/glm/Config.in | 7 +++++++
package/glm/glm.mk | 13 +++++++++++++
3 files changed, 21 insertions(+)
create mode 100644 package/glm/Config.in
create mode 100644 package/glm/glm.mk
diff --git a/package/Config.in b/package/Config.in
index 4520ba6..1e4bc50 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -828,6 +828,7 @@ menu "Other"
source "package/fftw/Config.in"
source "package/flann/Config.in"
source "package/glibmm/Config.in"
+ source "package/glm/Config.in"
source "package/gmp/Config.in"
source "package/gsl/Config.in"
source "package/gtest/Config.in"
diff --git a/package/glm/Config.in b/package/glm/Config.in
new file mode 100644
index 0000000..2897cf0
--- /dev/null
+++ b/package/glm/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_GLM
+ bool "glm"
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ OpenGL Mathematics (GLM)
+
+ http://glm.g-truc.net
diff --git a/package/glm/glm.mk b/package/glm/glm.mk
new file mode 100644
index 0000000..1e7e7df
--- /dev/null
+++ b/package/glm/glm.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# glm
+#
+#############################################################
+GLM_VERSION = 0.9.5.4
+GLM_SITE = git://github.com/g-truc/glm.git
+GLM_LICENSE = MIT
+GLM_LICENSE_FILES = copying.txt
+GLM_INSTALL_STAGING = YES
+GLM_INSTALL_TARGET = NO
+
+$(eval $(cmake-package))
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] glm: Added package
2014-08-05 22:59 [Buildroot] [PATCH] glm: Added package Paul Cercueil
@ 2014-08-06 3:10 ` Baruch Siach
2014-08-06 20:12 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-08-06 3:10 UTC (permalink / raw)
To: buildroot
Hi Paul,
On Wed, Aug 06, 2014 at 12:59:17AM +0200, Paul Cercueil wrote:
> OpenGL Mathematics (GLM) is a header only C++ mathematics library for
> graphics software based on the OpenGL Shading Language (GLSL)
> specification.
>
> http://glm.g-truc.net/
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> package/Config.in | 1 +
> package/glm/Config.in | 7 +++++++
> package/glm/glm.mk | 13 +++++++++++++
> 3 files changed, 21 insertions(+)
> create mode 100644 package/glm/Config.in
> create mode 100644 package/glm/glm.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4520ba6..1e4bc50 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -828,6 +828,7 @@ menu "Other"
> source "package/fftw/Config.in"
> source "package/flann/Config.in"
> source "package/glibmm/Config.in"
> + source "package/glm/Config.in"
> source "package/gmp/Config.in"
> source "package/gsl/Config.in"
> source "package/gtest/Config.in"
> diff --git a/package/glm/Config.in b/package/glm/Config.in
> new file mode 100644
> index 0000000..2897cf0
> --- /dev/null
> +++ b/package/glm/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_GLM
> + bool "glm"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + OpenGL Mathematics (GLM)
> +
> + http://glm.g-truc.net
> diff --git a/package/glm/glm.mk b/package/glm/glm.mk
> new file mode 100644
> index 0000000..1e7e7df
> --- /dev/null
> +++ b/package/glm/glm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# glm
> +#
> +#############################################################
> +GLM_VERSION = 0.9.5.4
> +GLM_SITE = git://github.com/g-truc/glm.git
Have you tried using the github helper? If it doesn't work for you please add
a comment explaining why.
baruch
> +GLM_LICENSE = MIT
> +GLM_LICENSE_FILES = copying.txt
> +GLM_INSTALL_STAGING = YES
> +GLM_INSTALL_TARGET = NO
> +
> +$(eval $(cmake-package))
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] glm: Added package
2014-08-05 22:59 [Buildroot] [PATCH] glm: Added package Paul Cercueil
2014-08-06 3:10 ` Baruch Siach
@ 2014-08-06 20:12 ` Thomas Petazzoni
2014-08-09 13:42 ` Paul Cercueil
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2014-08-06 20:12 UTC (permalink / raw)
To: buildroot
Dear Paul Cercueil,
On Wed, 6 Aug 2014 00:59:17 +0200, Paul Cercueil wrote:
> diff --git a/package/glm/Config.in b/package/glm/Config.in
> new file mode 100644
> index 0000000..2897cf0
> --- /dev/null
> +++ b/package/glm/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_GLM
> + bool "glm"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + OpenGL Mathematics (GLM)
> +
> + http://glm.g-truc.net
This lacks a comment explaining that this package depends on C++ when
C++ is not available (see the Buildroot manual and many other packages
in Buildroot).
> diff --git a/package/glm/glm.mk b/package/glm/glm.mk
> new file mode 100644
> index 0000000..1e7e7df
> --- /dev/null
> +++ b/package/glm/glm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# glm
> +#
> +#############################################################
Header length is not correct (80 # signs are needed), and there should
be an empty line between the header and the first variable definition.
> +GLM_VERSION = 0.9.5.4
> +GLM_SITE = git://github.com/g-truc/glm.git
github helper, as pointed by Baruch.
> +GLM_LICENSE = MIT
> +GLM_LICENSE_FILES = copying.txt
> +GLM_INSTALL_STAGING = YES
> +GLM_INSTALL_TARGET = NO
Could you add a small comment above those two lines to explain why no
target installation is needed?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] glm: Added package
2014-08-06 20:12 ` Thomas Petazzoni
@ 2014-08-09 13:42 ` Paul Cercueil
0 siblings, 0 replies; 4+ messages in thread
From: Paul Cercueil @ 2014-08-09 13:42 UTC (permalink / raw)
To: buildroot
Hi Thomas, Baruch,
Thank you for your comments. I will send a new version of this patch
shortly.
Paul
Le 06/08/2014 22:12, Thomas Petazzoni a ?crit :
> Dear Paul Cercueil,
>
> On Wed, 6 Aug 2014 00:59:17 +0200, Paul Cercueil wrote:
>
>> diff --git a/package/glm/Config.in b/package/glm/Config.in
>> new file mode 100644
>> index 0000000..2897cf0
>> --- /dev/null
>> +++ b/package/glm/Config.in
>> @@ -0,0 +1,7 @@
>> +config BR2_PACKAGE_GLM
>> + bool "glm"
>> + depends on BR2_INSTALL_LIBSTDCPP
>> + help
>> + OpenGL Mathematics (GLM)
>> +
>> + http://glm.g-truc.net
>
> This lacks a comment explaining that this package depends on C++ when
> C++ is not available (see the Buildroot manual and many other packages
> in Buildroot).
>
>> diff --git a/package/glm/glm.mk b/package/glm/glm.mk
>> new file mode 100644
>> index 0000000..1e7e7df
>> --- /dev/null
>> +++ b/package/glm/glm.mk
>> @@ -0,0 +1,13 @@
>> +#############################################################
>> +#
>> +# glm
>> +#
>> +#############################################################
>
> Header length is not correct (80 # signs are needed), and there should
> be an empty line between the header and the first variable definition.
>
>> +GLM_VERSION = 0.9.5.4
>> +GLM_SITE = git://github.com/g-truc/glm.git
>
> github helper, as pointed by Baruch.
>
>> +GLM_LICENSE = MIT
>> +GLM_LICENSE_FILES = copying.txt
>> +GLM_INSTALL_STAGING = YES
>> +GLM_INSTALL_TARGET = NO
>
> Could you add a small comment above those two lines to explain why no
> target installation is needed?
>
> Thanks!
>
> Thomas
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-09 13:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-05 22:59 [Buildroot] [PATCH] glm: Added package Paul Cercueil
2014-08-06 3:10 ` Baruch Siach
2014-08-06 20:12 ` Thomas Petazzoni
2014-08-09 13:42 ` Paul Cercueil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox