[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Yann E. MORIN]

The fact that atomic operations are available is not really a
specificity of the toolchain, but rather of the architecture.

So, add a new option that architectures that have atomic operations
can select. This in turn selects the current toolchain atomic option,
until all packages have been converted, at which point the old
toolchain option can be removed.

Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/Config.in                | 6 ++++++
 arch/Config.in.arc            | 2 +-
 toolchain/toolchain-common.in | 1 -
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/Config.in b/arch/Config.in
index 9cd85a5..5cee0d7 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -250,6 +250,12 @@ config BR2_GCC_TARGET_FLOAT_ABI
 config BR2_GCC_TARGET_MODE
 	string
 
+# If the architecture has atomic operations, select this:
+config BR2_ARCH_HAS_ATOMICS
+	bool
+	default y if !BR2_arc
+	select BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+
 # Set up target binary format
 choice
 	prompt "Target Binary Format"
diff --git a/arch/Config.in.arc b/arch/Config.in.arc
index 836cfef..8a7f290 100644
--- a/arch/Config.in.arc
+++ b/arch/Config.in.arc
@@ -1,7 +1,7 @@
 # Choise of atomic instructions presence
 config BR2_ARC_ATOMIC_EXT
 	bool "Atomic extension (LLOCK/SCOND instructions)"
-	select BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	select BR2_ARCH_HAS_ATOMICS
 
 config BR2_ARCH
 	default "arc"	if BR2_arcle
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 6d43700..2fa4f61 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -46,7 +46,6 @@ config BR2_TOOLCHAIN_HAS_SSP
 
 config BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
 	bool
-	default y if !BR2_arc
 
 config BR2_ENABLE_LOCALE_PURGE
 	bool "Purge unwanted locales"
-- 
1.9.1

[Buildroot] [PATCH 02/24 v4] package/icu: use the new ARCH_HAS_ATOMICS as dependency

[Yann E. MORIN]

And propagate to the reverse dependencies of icu.
Also, fix beecrypt's comment: only the C++ support needs atomics.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/beecrypt/Config.in    | 12 ++++++------
 package/cppcms/Config.in      |  7 ++++---
 package/icu/Config.in         |  7 ++++---
 package/php/Config.ext        |  8 ++++----
 package/qt5/qt5base/Config.in |  5 +----
 5 files changed, 19 insertions(+), 20 deletions(-)

diff --git a/package/beecrypt/Config.in b/package/beecrypt/Config.in
index e0f9181..b9685ef 100644
--- a/package/beecrypt/Config.in
+++ b/package/beecrypt/Config.in
@@ -1,5 +1,5 @@
-comment "beecrypt needs a toolchain w/ threads, atomic intrinsics"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+comment "beecrypt needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_BEECRYPT
 	bool "beecrypt"
@@ -15,15 +15,15 @@ config BR2_PACKAGE_BEECRYPT_CPP
 	bool "C++ support"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_USE_WCHAR # icu
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # icu
 	depends on !BR2_BINFMT_FLAT # icu
+	depends on BR2_ARCH_HAS_ATOMICS # icu
 	select BR2_PACKAGE_ICU
 	help
 	  Enable C++ support. This pulls in the (large) icu package.
 
-comment "C++ support needs a toolchain w/ wchar, atomic intrinsics"
+comment "C++ support needs a toolchain w/ wchar"
 	depends on !BR2_BINFMT_FLAT
-	depends on BR2_INSTALL_LIBSTDCPP && (!BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS)
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_INSTALL_LIBSTDCPP && !BR2_USE_WCHAR
 
 endif # BR2_PACKAGE_BEECRYPT
diff --git a/package/cppcms/Config.in b/package/cppcms/Config.in
index 297c514..dbe4786 100644
--- a/package/cppcms/Config.in
+++ b/package/cppcms/Config.in
@@ -26,14 +26,15 @@ config BR2_PACKAGE_CPPCMS_ICU
 	bool "enable icu support"
 	depends on !BR2_BINFMT_FLAT # icu
 	depends on BR2_USE_WCHAR # icu
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # icu
+	depends on BR2_ARCH_HAS_ATOMICS # icu
 	select BR2_PACKAGE_ICU
 	help
 	  Using ICU allows advanced localization features into CppCMS,
 	  in another hand ICU is heavier than iconv.
 
-comment "icu support needs a toolchain w/ wchar, atomic intrinsics"
-	depends on !BR2_BINFMT_FLAT || !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+comment "icu support needs a toolchain w/ wchar"
+	depends on !BR2_BINFMT_FLAT
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_USE_WCHAR
 
 endif
diff --git a/package/icu/Config.in b/package/icu/Config.in
index d4521ac..d7bf2fe 100644
--- a/package/icu/Config.in
+++ b/package/icu/Config.in
@@ -7,7 +7,7 @@ config BR2_PACKAGE_ICU
 	# file, and it cannot easily be changed to generate FLAT
 	# format.
 	depends on !BR2_BINFMT_FLAT
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	depends on BR2_ARCH_HAS_ATOMICS
 	help
 	  International Components for Unicode.
 
@@ -25,7 +25,8 @@ config BR2_PACKAGE_ICU_CUSTOM_DATA_PATH
 
 endif
 
-comment "icu needs a toolchain w/ C++, wchar, threads, atomic intrinsics"
+comment "icu needs a toolchain w/ C++, wchar, threads"
 	depends on !BR2_BINFMT_FLAT
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+		!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/php/Config.ext b/package/php/Config.ext
index 078be8d..e07779a 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -168,14 +168,14 @@ config BR2_PACKAGE_PHP_EXT_INTL
 	depends on BR2_USE_WCHAR
 	depends on !BR2_BINFMT_FLAT # icu
 	depends on BR2_TOOLCHAIN_HAS_THREADS # icu
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # icu
+	depends on BR2_ARCH_HAS_ATOMICS # icu
 	help
 	  Internationalization support
 
-comment "intl support needs a toolchain w/ C++, wchar, threads, atomic intrinsics"
+comment "intl support needs a toolchain w/ C++, wchar, threads"
 	depends on !BR2_BINFMT_FLAT
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 
 comment "Image processing"
 
diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
index 67f211c..7a34d6f 100644
--- a/package/qt5/qt5base/Config.in
+++ b/package/qt5/qt5base/Config.in
@@ -241,15 +241,12 @@ config BR2_PACKAGE_QT5BASE_DBUS
 config BR2_PACKAGE_QT5BASE_ICU
 	bool "Enable ICU support"
 	select BR2_PACKAGE_ICU
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # icu
+	depends on BR2_ARCH_HAS_ATOMICS # icu
 	depends on !BR2_BINFMT_FLAT # icu
 	help
 	  This option enables ICU support in Qt5. This is for example
 	  needed for Qt5Webkit.
 
-comment "icu needs a toolchain w/ atomic intrinsics"
-	depends on !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
-
 config BR2_PACKAGE_QT5BASE_TSLIB
 	bool "Enable Tslib support"
 	depends on !BR2_PREFER_STATIC_LIB # dlopen
-- 
1.9.1

[Buildroot] [PATCH 03/24 v4] package/libtorrent: use the new ARCH_HAS_ATOMICS as dependency

[Yann E. MORIN]

And propagate to the reverse dependencies of libtorrent

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/libtorrent/Config.in | 8 ++++----
 package/rtorrent/Config.in   | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/package/libtorrent/Config.in b/package/libtorrent/Config.in
index a706d98..aac71fa 100644
--- a/package/libtorrent/Config.in
+++ b/package/libtorrent/Config.in
@@ -2,13 +2,13 @@ config BR2_PACKAGE_LIBTORRENT
 	bool "libtorrent"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	depends on BR2_ARCH_HAS_ATOMICS
 	select BR2_PACKAGE_LIBSIGC
 	help
 	  BitTorrent library written in C++ for *nix
 
 	  http://libtorrent.rakshasa.no/
 
-comment "libtorrent needs a toolchain w/ C++, threads, atomic intrinsics"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+comment "libtorrent needs a toolchain w/ C++, threads"
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/rtorrent/Config.in b/package/rtorrent/Config.in
index 1efc5f1..1798331 100644
--- a/package/rtorrent/Config.in
+++ b/package/rtorrent/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_RTORRENT
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS # libtorrent
+	depends on BR2_ARCH_HAS_ATOMICS # libtorrent
 	select BR2_PACKAGE_LIBCURL
 	select BR2_PACKAGE_LIBSIGC
 	select BR2_PACKAGE_LIBTORRENT
@@ -15,7 +15,7 @@ config BR2_PACKAGE_RTORRENT
 
 	  http://libtorrent.rakshasa.no/
 
-comment "rtorrent needs a toolchain w/ C++, threads, wchar, atomic intrinsics"
+comment "rtorrent needs a toolchain w/ C++, threads, wchar"
 	depends on BR2_USE_MMU
-	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS \
-		&& BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS)
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && BR2_TOOLCHAIN_HAS_THREADS)
-- 
1.9.1

[Buildroot] [PATCH 04/24 v4] package/jack2: use the new ARCH_HAS_ATOMICS as dependency

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/jack2/Config.in | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/jack2/Config.in b/package/jack2/Config.in
index 82143c7..afc723c 100644
--- a/package/jack2/Config.in
+++ b/package/jack2/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_JACK2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	depends on BR2_ARCH_HAS_ATOMICS
 	select BR2_PACKAGE_LIBSAMPLERATE
 	select BR2_PACKAGE_LIBSNDFILE
 	select BR2_PACKAGE_ALSA_LIB
@@ -21,7 +21,8 @@ config BR2_PACKAGE_JACK2
 
 	  http://jackaudio.org/
 
-comment "jack2 needs a toolchain w/ largefile, threads, C++, atomic intrinsics"
+comment "jack2 needs a toolchain w/ largefile, threads, C++"
 	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+		!BR2_INSTALL_LIBSTDCPP
-- 
1.9.1

[Buildroot] [PATCH 05/24 v4] package/thrift: use the new ARCH_HAS_ATOMICS as dependency

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/thrift/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/thrift/Config.in b/package/thrift/Config.in
index 23b99e5..7c7272a 100644
--- a/package/thrift/Config.in
+++ b/package/thrift/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_THRIFT
 	depends on BR2_USE_WCHAR
 	depends on BR2_LARGEFILE
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+	depends on BR2_ARCH_HAS_ATOMICS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBEVENT
 	select BR2_PACKAGE_OPENSSL
@@ -19,7 +19,7 @@ config BR2_PACKAGE_THRIFT
 
 	  http://thrift.apache.org/
 
-comment "thrift needs a toolchain w/ C++, largefile, wchar, threads, atomic intrinsics"
+comment "thrift needs a toolchain w/ C++, largefile, wchar, threads"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_LARGEFILE || !BR2_USE_WCHAR || \
-		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP || \
-		!BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
+		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
-- 
1.9.1

[Buildroot] [PATCH 06/24 v4] toolchain: drop the now-unused old BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS

[Yann E. MORIN]

It's now been replaced with BR2_ARCH_HAS_ATOMICS, annd all packages have
been changed to use that instead.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/Config.in                | 1 -
 toolchain/toolchain-common.in | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/arch/Config.in b/arch/Config.in
index 5cee0d7..6bcafd4 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -254,7 +254,6 @@ config BR2_GCC_TARGET_MODE
 config BR2_ARCH_HAS_ATOMICS
 	bool
 	default y if !BR2_arc
-	select BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
 
 # Set up target binary format
 choice
diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 2fa4f61..82ac26a 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -44,9 +44,6 @@ config BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS
 config BR2_TOOLCHAIN_HAS_SSP
 	bool
 
-config BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
-	bool
-
 config BR2_ENABLE_LOCALE_PURGE
 	bool "Purge unwanted locales"
 	help
-- 
1.9.1

[Buildroot] [PATCH 07/24 v4] manual: document dependencies on atomic operations

[Yann E. MORIN]

From: Anton Kolesov <anton.kolesov@synopsys.com>

Add atomic operations to the list of generic dependencies.

Since this is an architecture option, there is no comment string to be
added.

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998 at free.fr: use the new arch-option; remove comment string]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 docs/manual/adding-packages-directory.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
index 93e6a3e..40a81d5 100644
--- a/docs/manual/adding-packages-directory.txt
+++ b/docs/manual/adding-packages-directory.txt
@@ -219,6 +219,10 @@ use in the comment.
 ** Dependency symbol: +BR2_USE_MMU+
 ** Comment string: no comment to be added
 
+* Atomic operations
+** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
+** Comment string: no comment to be added
+
 * Kernel headers
 ** Dependency symbol: +BR2_TOOLCHAIN_HEADERS_AT_LEAST_X_Y+, (replace
    +X_Y+ with the proper version, see +toolchain/toolchain-common.in+)
-- 
1.9.1

[Buildroot] [PATCH 08/24 v4] cairo: add dependency on atomic operations

[Yann E. MORIN]

From: Anton Kolesov <anton.kolesov@synopsys.com>

This fixes:
http://autobuild.buildroot.net/results/fadfaa9916724d310d0dda555a1db31bee1601d0/

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998 at free.fr: use the new symbol; remove comment strings;
 fix weston's comment]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/cairo/Config.in                        | 1 +
 package/efl/libevas-generic-loaders/Config.in  | 2 ++
 package/gstreamer/gst-plugins-good/Config.in   | 1 +
 package/gstreamer1/gst1-plugins-good/Config.in | 1 +
 package/libgtk2/Config.in                      | 2 ++
 package/librsvg/Config.in                      | 2 ++
 package/libsvg-cairo/Config.in                 | 1 +
 package/pango/Config.in                        | 2 ++
 package/webkit/Config.in                       | 2 ++
 package/weston/Config.in                       | 2 ++
 10 files changed, 16 insertions(+)

diff --git a/package/cairo/Config.in b/package/cairo/Config.in
index 0c87a29..38570d6 100644
--- a/package/cairo/Config.in
+++ b/package/cairo/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_CAIRO
 	bool "cairo"
+	depends on BR2_ARCH_HAS_ATOMICS
 	select BR2_PACKAGE_PIXMAN
 	select BR2_PACKAGE_FONTCONFIG
 	select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
diff --git a/package/efl/libevas-generic-loaders/Config.in b/package/efl/libevas-generic-loaders/Config.in
index 23b9f77..30fb88b 100644
--- a/package/efl/libevas-generic-loaders/Config.in
+++ b/package/efl/libevas-generic-loaders/Config.in
@@ -17,10 +17,12 @@ config BR2_PACKAGE_LIBEVAS_GENERIC_LOADERS_SVG
 	depends on BR2_USE_WCHAR # librsvg -> glib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2
 	depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  This option enables the Evas generic SVG loader
 
 comment "SVG loader needs a toolchain w/ wchar, threads, C++"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
 
 endif
diff --git a/package/gstreamer/gst-plugins-good/Config.in b/package/gstreamer/gst-plugins-good/Config.in
index 3ec93cf..36b15a8 100644
--- a/package/gstreamer/gst-plugins-good/Config.in
+++ b/package/gstreamer/gst-plugins-good/Config.in
@@ -178,6 +178,7 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_ANNODEX
 
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_CAIRO
 	bool "cairo"
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 
diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
index 65dc7b1..f44690c 100644
--- a/package/gstreamer1/gst1-plugins-good/Config.in
+++ b/package/gstreamer1/gst1-plugins-good/Config.in
@@ -278,6 +278,7 @@ comment "v4l2 needs toolchain w/ headers >= 3.0"
 
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_CAIRO
 	bool "cairo"
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 	help
diff --git a/package/libgtk2/Config.in b/package/libgtk2/Config.in
index 5239c25..9326f44 100644
--- a/package/libgtk2/Config.in
+++ b/package/libgtk2/Config.in
@@ -17,6 +17,7 @@ config BR2_PACKAGE_LIBGTK2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  The GTK+ version 2 graphical user interface library
 
@@ -34,6 +35,7 @@ endif
 
 comment "libgtk2 needs a toolchain w/ wchar, threads, C++"
 	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on BR2_PACKAGE_XORG7
 	depends on !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/librsvg/Config.in b/package/librsvg/Config.in
index 5dd4c58..94ef2ed 100644
--- a/package/librsvg/Config.in
+++ b/package/librsvg/Config.in
@@ -10,6 +10,7 @@ config BR2_PACKAGE_LIBRSVG
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # pango
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	help
 	  The rsvg library is an efficient renderer for Scalable
 	  Vector Graphics (SVG) pictures.
@@ -18,4 +19,5 @@ config BR2_PACKAGE_LIBRSVG
 
 comment "librsvg needs a toolchain w/ wchar, threads, C++"
 	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libsvg-cairo/Config.in b/package/libsvg-cairo/Config.in
index 9577c69..d69a6b9 100644
--- a/package/libsvg-cairo/Config.in
+++ b/package/libsvg-cairo/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBSVG_CAIRO
 	bool "libsvg-cairo"
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_SVG
 	select BR2_PACKAGE_LIBSVG
diff --git a/package/pango/Config.in b/package/pango/Config.in
index 70f4fd3..e9c3040 100644
--- a/package/pango/Config.in
+++ b/package/pango/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_PANGO
 	depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
 	depends on BR2_USE_MMU # glib2
 	depends on BR2_INSTALL_LIBSTDCPP # freetype support
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_CAIRO
@@ -23,5 +24,6 @@ config BR2_PACKAGE_PANGO
 
 comment "pango needs a toolchain w/ wchar, threads, C++"
 	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
 		!BR2_INSTALL_LIBSTDCPP
diff --git a/package/webkit/Config.in b/package/webkit/Config.in
index 8cd1a36..fcb61b6 100644
--- a/package/webkit/Config.in
+++ b/package/webkit/Config.in
@@ -17,6 +17,7 @@ config BR2_PACKAGE_WEBKIT
 	depends on BR2_PACKAGE_LIBGTK2
 	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	depends on !BR2_BINFMT_FLAT # icu
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 	select BR2_PACKAGE_ENCHANT
@@ -44,6 +45,7 @@ config BR2_PACKAGE_WEBKIT
 
 comment "webkit needs libgtk2 and a toolchain w/ C++, wchar, threads"
 	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	depends on !BR2_PACKAGE_LIBGTK2 || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU
diff --git a/package/weston/Config.in b/package/weston/Config.in
index aaef405..dc7e235 100644
--- a/package/weston/Config.in
+++ b/package/weston/Config.in
@@ -1,5 +1,6 @@
 comment "weston needs udev and a toolchain w/ threads, headers >= 3.0"
 	depends on !BR2_avr32
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_PACKAGE_HAS_UDEV || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
 
 config BR2_PACKAGE_WESTON
@@ -15,6 +16,7 @@ config BR2_PACKAGE_WESTON
 	depends on !BR2_avr32 # wayland
 	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
+	depends on BR2_ARCH_HAS_ATOMICS # cairo
 	# Runtime dependency
 	select BR2_PACKAGE_XKEYBOARD_CONFIG
 	# Make sure at least one compositor is selected.
-- 
1.9.1

[Buildroot] [PATCH 09/24 v4] pulseaudio: add dependency on atomic operations

[Yann E. MORIN]

From: Anton Kolesov <anton.kolesov@synopsys.com>

This fixes:
http://autobuild.buildroot.net/results/d463f3bf730a600a07ed6cd33695bf45e9fd3540/

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998 at free.fr: use the new symbol; remove comment strings]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/gstreamer/gst-plugins-good/Config.in   | 6 ++++++
 package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++++
 package/mpd/Config.in                          | 2 ++
 package/pulseaudio/Config.in                   | 2 ++
 4 files changed, 16 insertions(+)

diff --git a/package/gstreamer/gst-plugins-good/Config.in b/package/gstreamer/gst-plugins-good/Config.in
index 36b15a8..3e25820 100644
--- a/package/gstreamer/gst-plugins-good/Config.in
+++ b/package/gstreamer/gst-plugins-good/Config.in
@@ -209,9 +209,15 @@ config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_PULSE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
 	depends on BR2_LARGEFILE # pulseaudio -> libsndfile
 	depends on BR2_USE_MMU # pulseaudio
+	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio
 	select BR2_PACKAGE_PULSEAUDIO
 	bool "pulseaudio"
 
+comment "pulseaudio support needs a toolchain w/ largefile, threads"
+	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+
 config BR2_PACKAGE_GST_PLUGINS_GOOD_PLUGIN_SOUPHTTPSRC
 	bool "souphttpsrc (http client)"
 	depends on BR2_USE_WCHAR # libsoup -> glib2
diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
index f44690c..22980dc 100644
--- a/package/gstreamer1/gst1-plugins-good/Config.in
+++ b/package/gstreamer1/gst1-plugins-good/Config.in
@@ -309,11 +309,17 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_PULSE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # pulseaudio
 	depends on BR2_LARGEFILE # pulseaudio -> libsndfile
 	depends on BR2_USE_MMU # pulseaudio
+	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio
 	select BR2_PACKAGE_PULSEAUDIO
 	bool "pulseaudio"
 	help
 	  PulseAudio plugin library
 
+comment "pulseaudio support needs a toolchain w/ largefile, threads"
+	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
+	depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
+
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SOUPHTTPSRC
 	bool "souphttpsrc (http client)"
 	depends on BR2_USE_WCHAR # libsoup -> glib2
diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index f5f5b34..b8a56b7 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -45,11 +45,13 @@ config BR2_PACKAGE_MPD_AUDIOFILE
 config BR2_PACKAGE_MPD_PULSEAUDIO
 	bool "pulseaudio"
 	depends on BR2_LARGEFILE # pulseaudio -> libsndfile
+	depends on BR2_ARCH_HAS_ATOMICS # pulseaudio
 	select BR2_PACKAGE_PULSEAUDIO
 	help
 	  Enable pulseaudio output support.
 
 comment "pulseaudio support needs a toolchain w/ largefile"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_LARGEFILE
 
 config BR2_PACKAGE_MPD_BZIP2
diff --git a/package/pulseaudio/Config.in b/package/pulseaudio/Config.in
index ac6222c..4bf64c2 100644
--- a/package/pulseaudio/Config.in
+++ b/package/pulseaudio/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_PULSEAUDIO
 	select BR2_PACKAGE_SPEEX
 	depends on BR2_LARGEFILE
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_ARCH_HAS_ATOMICS
 	help
 	  PulseAudio is a sound system for POSIX OSes, meaning that it
 	  is a proxy for your sound applications. It allows you to do
@@ -32,4 +33,5 @@ endif
 
 comment "pulseaudio needs a toolchain w/ wchar, largefile, threads"
 	depends on BR2_USE_MMU
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_USE_WCHAR || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
-- 
1.9.1

[Buildroot] [PATCH 10/24 v4] libftdi: add dependency on atomic operations

[Yann E. MORIN]

From: Anton Kolesov <anton.kolesov@synopsys.com>

This fixes:
http://autobuild.buildroot.net/results/6cb25ed954840109c9d0e582e922b0ba9d07e174/

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998 at free.fr: use the new symbol; remove comment strings]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/libftdi/Config.in | 2 ++
 package/openocd/Config.in | 1 +
 2 files changed, 3 insertions(+)

diff --git a/package/libftdi/Config.in b/package/libftdi/Config.in
index dc81514..76b30b1 100644
--- a/package/libftdi/Config.in
+++ b/package/libftdi/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_LIBFTDI
 	bool "libftdi"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	depends on BR2_ARCH_HAS_ATOMICS
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_LIBUSB_COMPAT
 	help
@@ -19,4 +20,5 @@ config BR2_PACKAGE_LIBTFDI_CPP
 endif # BR2_PACKAGE_LIBFTDI
 
 comment "libftdi needs a toolchain w/ threads"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/openocd/Config.in b/package/openocd/Config.in
index 7f96ef8..9440c65 100644
--- a/package/openocd/Config.in
+++ b/package/openocd/Config.in
@@ -14,6 +14,7 @@ comment "Adapters"
 
 config BR2_PACKAGE_OPENOCD_FT2XXX
 	bool "FT2xxx/FT4xxx Based JTAG Programmer"
+	depends on BR2_ARCH_HAS_ATOMICS # libftdi
 	select BR2_PACKAGE_LIBFTDI
 	help
 	  Enable building support for FT2232 based devices
-- 
1.9.1

[Buildroot] [PATCH 11/24 v4] msgpack: add dependency on atomic operations

[Yann E. MORIN]

From: Anton Kolesov <anton.kolesov@synopsys.com>

This fixes:
http://autobuild.buildroot.net/results/44849a386cefb8899f4560296bfbbd8ea19ee910/

Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998 at free.fr: use the new symbol; remove comment strings]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 package/msgpack/Config.in        | 4 ++--
 package/python-msgpack/Config.in | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/msgpack/Config.in b/package/msgpack/Config.in
index b380c58..a57a378 100644
--- a/package/msgpack/Config.in
+++ b/package/msgpack/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_MSGPACK
 	bool "msgpack"
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on !BR2_arc # atomic builtins
+	depends on BR2_ARCH_HAS_ATOMICS
 	help
 	  MessagePack is an efficient binary serialization format.
 
@@ -11,5 +11,5 @@ config BR2_PACKAGE_MSGPACK
 	  http://msgpack.org/
 
 comment "msgpack needs a toolchain w/ C++"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on !BR2_INSTALL_LIBSTDCPP
-	depends on !BR2_arc
diff --git a/package/python-msgpack/Config.in b/package/python-msgpack/Config.in
index c4b68a3..ed0b432 100644
--- a/package/python-msgpack/Config.in
+++ b/package/python-msgpack/Config.in
@@ -3,7 +3,7 @@ config BR2_PACKAGE_PYTHON_MSGPACK
 	depends on BR2_PACKAGE_PYTHON
 	select BR2_PACKAGE_MSGPACK
 	depends on BR2_INSTALL_LIBSTDCPP # msgpack
-	depends on !BR2_arc # msgpack - atomic builtins
+	depends on BR2_ARCH_HAS_ATOMICS # msgpack
 	help
 	  MessagePack (http://msgpack.org/) is a fast, compact binary
 	  serialization format, suitable for similar data to JSON.
@@ -13,6 +13,6 @@ config BR2_PACKAGE_PYTHON_MSGPACK
 	  https://pypi.python.org/pypi/msgpack-python/
 
 comment "python-msgpack needs a toolchain w/ C++"
+	depends on BR2_ARCH_HAS_ATOMICS
 	depends on BR2_PACKAGE_PYTHON
 	depends on !BR2_INSTALL_LIBSTDCPP
-	depends on !BR2_arc
-- 
1.9.1

[Buildroot] [PATCH 12/24 v4] arch/arm: always has atomic ops

[Yann E. MORIN]

armv6 and above all have one sort of atomic ops or another. For armv5
and below, they are emulated, either as a kernel trap, a kernel VDSO,
or compiler intrinsics.

Aarch64 is just armv8, so make it a single commit. ;-)

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.aarch64 | 3 +++
 arch/Config.in.arm     | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/arch/Config.in.aarch64 b/arch/Config.in.aarch64
index 4c68a37..2e79870 100644
--- a/arch/Config.in.aarch64
+++ b/arch/Config.in.aarch64
@@ -3,3 +3,6 @@ config BR2_ARCH
 
 config BR2_ENDIAN
 	default "LITTLE"
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
diff --git a/arch/Config.in.arm b/arch/Config.in.arm
index 4cc41f1..e404a50 100644
--- a/arch/Config.in.arm
+++ b/arch/Config.in.arm
@@ -340,6 +340,9 @@ config BR2_ENDIAN
 	default "LITTLE" if BR2_arm
 	default "BIG"	 if BR2_armeb
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_CPU
 	default "arm920"	if BR2_arm920
 	default "arm920t"	if BR2_arm920t
-- 
1.9.1

[Buildroot] [PATCH 13/24 v4] arch/avr32: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.avr32 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.avr32 b/arch/Config.in.avr32
index 8429589..fc1f4f6 100644
--- a/arch/Config.in.avr32
+++ b/arch/Config.in.avr32
@@ -6,3 +6,6 @@ config BR2_ENDIAN
 
 config BR2_GCC_TARGET_ARCH
 	default "ap"
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
-- 
1.9.1

[Buildroot] [PATCH 14/24 v4] arch/bfin: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.bfin | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.bfin b/arch/Config.in.bfin
index 415fc89..0783969 100644
--- a/arch/Config.in.bfin
+++ b/arch/Config.in.bfin
@@ -68,6 +68,9 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "LITTLE"
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_CPU
 	default bf606		if BR2_bf606
 	default bf607		if BR2_bf607
-- 
1.9.1

[Buildroot] [PATCH 15/24 v4] arch/m68k: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.m68k | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.m68k b/arch/Config.in.m68k
index ba6cedf..6b79307 100644
--- a/arch/Config.in.m68k
+++ b/arch/Config.in.m68k
@@ -4,6 +4,9 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "BIG"
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_TUNE
 	default "68000"		if BR2_m68k_68000
 	default "68010"		if BR2_m68k_68010
-- 
1.9.1

[Buildroot] [PATCH 16/24 v4] arch/microblaze: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.microblaze | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.microblaze b/arch/Config.in.microblaze
index 2d4c1fe..7c21dfc 100644
--- a/arch/Config.in.microblaze
+++ b/arch/Config.in.microblaze
@@ -9,3 +9,6 @@ config BR2_ENDIAN
 config BR2_microblaze
 	bool
 	default y if BR2_microblazeel || BR2_microblazebe
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
-- 
1.9.1

[Buildroot] [PATCH 17/24 v4] arch/mips: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.mips | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.mips b/arch/Config.in.mips
index 20951e0..18138de 100644
--- a/arch/Config.in.mips
+++ b/arch/Config.in.mips
@@ -73,6 +73,9 @@ config BR2_ENDIAN
 	default "LITTLE"	if BR2_mipsel || BR2_mips64el
 	default "BIG" 	    	if BR2_mips || BR2_mips64
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_ARCH
 	default "mips1"		if BR2_mips_1
 	default "mips2"		if BR2_mips_2
-- 
1.9.1

[Buildroot] [PATCH 18/24 v4] arch/nios2: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.nios2 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.nios2 b/arch/Config.in.nios2
index ed63898..7807769 100644
--- a/arch/Config.in.nios2
+++ b/arch/Config.in.nios2
@@ -3,3 +3,6 @@ config BR2_ARCH
 
 config BR2_ENDIAN
 	default "LITTLE"
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
-- 
1.9.1

[Buildroot] [PATCH 19/24 v4] arch/powerpc: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.powerpc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.powerpc b/arch/Config.in.powerpc
index e444cb8..239f5dc 100644
--- a/arch/Config.in.powerpc
+++ b/arch/Config.in.powerpc
@@ -157,6 +157,9 @@ config BR2_ENDIAN
 	default "BIG"    if BR2_powerpc || BR2_powerpc64
 	default "LITTLE" if BR2_powerpc64le
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_TUNE
 	default "401"		if BR2_powerpc_401
 	default "403"		if BR2_powerpc_403
-- 
1.9.1

[Buildroot] [PATCH 0/24 v4] arch: move atomics to arch, not toolchain (branch yem/atomics)

[Yann E. MORIN]

Hello All!

This series is a follow-up to, and includes Anton's series, to introduce
awareness of atomic operations, so pacjages can be hidden-away on
architectures that do not provide atomic operations.

We've discussed this with Thomas on IRC and on the list, and although
this comes late in the cycle, we both consider this to be materials for
the *current* release.

I tried to cover all bases here, but there are architectures I have
close-to-zero knowledge of, so please speak up if you disagree on my
proposal.

The series is split in thre parts:

  - patches 1..7 renames the option, and moves it out of toolchain and
    to an architecture option, and add the option to the manual;

  - patches 8..11 hides more packages due to their requiring atomics

  - patches 12..24 convert all our architectures to selectively declare
    their (non-)support for atomic ops, to finally get rid of the
    generic default value.


Changes v3 -> v4:
  - rename the option into an architecture option  (Yann)


Regards,
Yann E. MORIN.


The following changes since commit 8c94df28c75ff834ef77df781b753e0453b8c8dd:

  CHANGES: update with recent changes (2014-08-17 09:44:53 +0200)

are available in the git repository at:

  git://gitorious.org/buildroot/buildroot.git yem/atomics

for you to fetch changes up to b8d37160ad1e6fafbba18de4733512650e00f6ec:

  arch: remove no-longer default on atomics option (2014-08-17 14:32:07 +0200)

----------------------------------------------------------------
Anton Kolesov (5):
      manual: document dependencies on atomic operations
      cairo: add dependency on atomic operations
      pulseaudio: add dependency on atomic operations
      libftdi: add dependency on atomic operations
      msgpack: add dependency on atomic operations

Yann E. MORIN (19):
      arch: add an option to specify if the arch has atomic ops
      package/icu: use the new ARCH_HAS_ATOMICS as dependency
      package/libtorrent: use the new ARCH_HAS_ATOMICS as dependency
      package/jack2: use the new ARCH_HAS_ATOMICS as dependency
      package/thrift: use the new ARCH_HAS_ATOMICS as dependency
      toolchain: drop the now-unused old BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
      arch/arm: always has atomic ops
      arch/avr32: always has atomic ops
      arch/bfin: always has atomic ops
      arch/m68k: always has atomic ops
      arch/microblaze: always has atomic ops
      arch/mips: always has atomic ops
      arch/nios2: always has atomic ops
      arch/powerpc: always has atomic ops
      arch/sh: always has atomic ops
      arch/sparc: always has atomic ops
      arch/x86: all x86 but i386 has atomics operations
      arch/xtensa: always has atomic ops
      arch: remove no-longer default on atomics option

 arch/Config.in                                 |  4 ++++
 arch/Config.in.aarch64                         |  3 +++
 arch/Config.in.arc                             |  2 +-
 arch/Config.in.arm                             |  3 +++
 arch/Config.in.avr32                           |  3 +++
 arch/Config.in.bfin                            |  3 +++
 arch/Config.in.m68k                            |  3 +++
 arch/Config.in.microblaze                      |  3 +++
 arch/Config.in.mips                            |  3 +++
 arch/Config.in.nios2                           |  3 +++
 arch/Config.in.powerpc                         |  3 +++
 arch/Config.in.sh                              |  3 +++
 arch/Config.in.sparc                           |  3 +++
 arch/Config.in.x86                             |  3 +++
 arch/Config.in.xtensa                          |  3 +++
 docs/manual/adding-packages-directory.txt      |  4 ++++
 package/beecrypt/Config.in                     | 12 ++++++------
 package/cairo/Config.in                        |  1 +
 package/cppcms/Config.in                       |  7 ++++---
 package/efl/libevas-generic-loaders/Config.in  |  2 ++
 package/gstreamer/gst-plugins-good/Config.in   |  7 +++++++
 package/gstreamer1/gst1-plugins-good/Config.in |  7 +++++++
 package/icu/Config.in                          |  7 ++++---
 package/jack2/Config.in                        |  7 ++++---
 package/libftdi/Config.in                      |  2 ++
 package/libgtk2/Config.in                      |  2 ++
 package/librsvg/Config.in                      |  2 ++
 package/libsvg-cairo/Config.in                 |  1 +
 package/libtorrent/Config.in                   |  8 ++++----
 package/mpd/Config.in                          |  2 ++
 package/msgpack/Config.in                      |  4 ++--
 package/openocd/Config.in                      |  1 +
 package/pango/Config.in                        |  2 ++
 package/php/Config.ext                         |  8 ++++----
 package/pulseaudio/Config.in                   |  2 ++
 package/python-msgpack/Config.in               |  4 ++--
 package/qt5/qt5base/Config.in                  |  5 +----
 package/rtorrent/Config.in                     |  8 ++++----
 package/thrift/Config.in                       |  8 ++++----
 package/webkit/Config.in                       |  2 ++
 package/weston/Config.in                       |  2 ++
 toolchain/toolchain-common.in                  |  4 ----
 42 files changed, 122 insertions(+), 44 deletions(-)

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 20/24 v4] arch/sh: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.sh | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.sh b/arch/Config.in.sh
index 1bdea37..9f8f79c 100644
--- a/arch/Config.in.sh
+++ b/arch/Config.in.sh
@@ -28,3 +28,6 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "LITTLE"	if BR2_sh4 || BR2_sh4a || BR2_sh64
 	default "BIG"		if BR2_sh2a || BR2_sh4eb || BR2_sh4aeb
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
-- 
1.9.1

[Buildroot] [PATCH 21/24 v4] arch/sparc: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.sparc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.sparc b/arch/Config.in.sparc
index 21e83f7..657c825 100644
--- a/arch/Config.in.sparc
+++ b/arch/Config.in.sparc
@@ -23,6 +23,9 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "BIG"
 
+config BR2_ARCH_HAS_ATOMICS
+	default y
+
 config BR2_GCC_TARGET_TUNE
 	default "v8"		if BR2_sparc_v8
 
-- 
1.9.1

[Buildroot] [PATCH 22/24 v4] arch/x86: all x86 but i386 has atomics operations

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.x86 | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.x86 b/arch/Config.in.x86
index 327aff0..9aa4ea2 100644
--- a/arch/Config.in.x86
+++ b/arch/Config.in.x86
@@ -202,6 +202,9 @@ config BR2_ARCH
 config BR2_ENDIAN
 	default "LITTLE"
 
+config BR2_ARCH_HAS_ATOMICS
+	default y if !BR2_x86_i386
+
 config BR2_GCC_TARGET_TUNE
 	default "i386"		if BR2_x86_i386
 	default "i486"		if BR2_x86_i486
-- 
1.9.1

[Buildroot] [PATCH 23/24 v4] arch/xtensa: always has atomic ops

[Yann E. MORIN]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in.xtensa | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/Config.in.xtensa b/arch/Config.in.xtensa
index 60c03f5..ff71e0b 100644
--- a/arch/Config.in.xtensa
+++ b/arch/Config.in.xtensa
@@ -35,3 +35,6 @@ config BR2_XTENSA_OVERLAY_DIR
 
 config BR2_ARCH
 	default "xtensa"	if BR2_xtensa
+
+config BR2_ARCH_HAS_ATOMICS
+	default y
-- 
1.9.1

[Buildroot] [PATCH 24/24 v4] arch: remove no-longer default on atomics option

[Yann E. MORIN]

Now that all archiotectures explicitly select this options when it makes
sense, there is no need to have a default value.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
---
 arch/Config.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/Config.in b/arch/Config.in
index 6bcafd4..1126d43 100644
--- a/arch/Config.in
+++ b/arch/Config.in
@@ -253,7 +253,6 @@ config BR2_GCC_TARGET_MODE
 # If the architecture has atomic operations, select this:
 config BR2_ARCH_HAS_ATOMICS
 	bool
-	default y if !BR2_arc
 
 # Set up target binary format
 choice
-- 
1.9.1

[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Thomas De Schampheleire]

"Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>The fact that atomic operations are available is not really a
>specificity of the toolchain, but rather of the architecture.
>
>So, add a new option that architectures that have atomic operations
>can select. This in turn selects the current toolchain atomic option,
>until all packages have been converted, at which point the old
>toolchain option can be removed.
>
>Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
>Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>---
> arch/Config.in                | 6 ++++++
> arch/Config.in.arc            | 2 +-
> toolchain/toolchain-common.in | 1 -
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/arch/Config.in b/arch/Config.in
>index 9cd85a5..5cee0d7 100644
>--- a/arch/Config.in
>+++ b/arch/Config.in
>@@ -250,6 +250,12 @@ config BR2_GCC_TARGET_FLOAT_ABI
> config BR2_GCC_TARGET_MODE
> 	string
> 
>+# If the architecture has atomic operations, select this:
>+config BR2_ARCH_HAS_ATOMICS
>+	bool
>+	default y if !BR2_arc
>+	select BR2_TOOLCHAIN_HAS_ATOMIC_INTRINSICS
>+

Is there a specific reason why the option is now
 dubbed ATOMICS iso ATOMIC_INTRINSICS?

The latter may be a bit more descriptive, no?

Best regards,
Thomas

[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Thomas Petazzoni]

Dear Thomas De Schampheleire,

On Sun, 17 Aug 2014 14:55:06 +0200, Thomas De Schampheleire wrote:

> Is there a specific reason why the option is now
>  dubbed ATOMICS iso ATOMIC_INTRINSICS?
> 
> The latter may be a bit more descriptive, no?

But wouldn't make sense. "intrinsics" is a compiler notion, which
doesn't have much to do with an architecture. An architecture provides
atomic instructions, which in turn allow compilers to implement a
certain class of compiler intrinsics to access those atomic operations.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 07/24 v4] manual: document dependencies on atomic operations

[Thomas De Schampheleire]

"Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>From: Anton Kolesov <anton.kolesov@synopsys.com>
>
>Add atomic operations to the list of generic dependencies.
>
>Since this is an architecture option, there is no comment string to be
>added.
>
>Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
>[yann.morin.1998 at free.fr: use the new arch-option; remove comment string]
>Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>---
> docs/manual/adding-packages-directory.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
>index 93e6a3e..40a81d5 100644
>--- a/docs/manual/adding-packages-directory.txt
>+++ b/docs/manual/adding-packages-directory.txt
>@@ -219,6 +219,10 @@ use in the comment.
> ** Dependency symbol: +BR2_USE_MMU+
> ** Comment string: no comment to be added
> 
>+* Atomic operations
>+** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
>+** Comment string: no comment to be added
>+

Should we provide a brief explanation, reference, or
 name of these functions to make it a bit clearer what
is meant with 'atomic operations'?

[Buildroot] [PATCH 24/24 v4] arch: remove no-longer default on atomics option

[Thomas De Schampheleire]

"Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>Now that all archiotectures explicitly select this options when it makes

architectures
option

>sense, there is no need to have a default value.
>
>Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
>---
> arch/Config.in | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/Config.in b/arch/Config.in
>index 6bcafd4..1126d43 100644
>--- a/arch/Config.in
>+++ b/arch/Config.in
>@@ -253,7 +253,6 @@ config BR2_GCC_TARGET_MODE
> # If the architecture has atomic operations, select this:
> config BR2_ARCH_HAS_ATOMICS
> 	bool
>-	default y if !BR2_arc
> 
> # Set up target binary format
> choice

[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Thomas De Schampheleire]

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> schreef:
>Dear Thomas De Schampheleire,
>
>On Sun, 17 Aug 2014 14:55:06 +0200, Thomas De Schampheleire wrote:
>
>> Is there a specific reason why the option is now
>>  dubbed ATOMICS iso ATOMIC_INTRINSICS?
>> 
>> The latter may be a bit more descriptive, no?
>
>But wouldn't make sense. "intrinsics" is a compiler notion, which
>doesn't have much to do with an architecture. An architecture provides
>atomic instructions, which in turn allow compilers to implement a
>certain class of compiler intrinsics to access those atomic operations.

Then what about HAS_ATOMIC_INSTRUCTIONS ?

[Buildroot] [PATCH 01/24 v4] arch: add an option to specify if the arch has atomic ops

[Yann E. MORIN]

Thomas?, All,

On 2014-08-17 14:57 +0200, Thomas Petazzoni spake thusly:
> On Sun, 17 Aug 2014 14:55:06 +0200, Thomas De Schampheleire wrote:
> 
> > Is there a specific reason why the option is now
> >  dubbed ATOMICS iso ATOMIC_INTRINSICS?
> > 
> > The latter may be a bit more descriptive, no?
> 
> But wouldn't make sense. "intrinsics" is a compiler notion, which
> doesn't have much to do with an architecture. An architecture provides
> atomic instructions, which in turn allow compilers to implement a
> certain class of compiler intrinsics to access those atomic operations.

That.

Plus, who could have resisted the 'atomics' pun? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 07/24 v4] manual: document dependencies on atomic operations

[Yann E. MORIN]

Thomas, All,

On 2014-08-17 15:01 +0200, Thomas De Schampheleire spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
> >From: Anton Kolesov <anton.kolesov@synopsys.com>
> >
> >Add atomic operations to the list of generic dependencies.
> >
> >Since this is an architecture option, there is no comment string to be
> >added.
> >
> >Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
> >[yann.morin.1998 at free.fr: use the new arch-option; remove comment string]
> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >---
> > docs/manual/adding-packages-directory.txt | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> >index 93e6a3e..40a81d5 100644
> >--- a/docs/manual/adding-packages-directory.txt
> >+++ b/docs/manual/adding-packages-directory.txt
> >@@ -219,6 +219,10 @@ use in the comment.
> > ** Dependency symbol: +BR2_USE_MMU+
> > ** Comment string: no comment to be added
> > 
> >+* Atomic operations
> >+** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
> >+** Comment string: no comment to be added
> >+
> 
> Should we provide a brief explanation, reference, or
>  name of these functions to make it a bit clearer what
> is meant with 'atomic operations'?

Well, the atomics are all named differently in different architectures.

For example, armv6+ has LDREX and STREX (amon others):
    http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0008a/ch01s02s01.html

While on x86, I don't think there are corresponding instructions, but
you can prefix some intructions with the LOCK prefix to achieve a
similar result.

So, I would not know what to put in here. Also, we do not explain what
the other options are (like MMU, for example). Why would we do that for
this specific option, and not others?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 24/24 v4] arch: remove no-longer default on atomics option

[Yann E. MORIN]

Thomas, All,

On 2014-08-17 15:03 +0200, Thomas De Schampheleire spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
> >Now that all archiotectures explicitly select this options when it makes
> 
> architectures
> option

Fixed, thanks.

Regards,
Yann E. MORIN.

> >sense, there is no need to have a default value.
> >
> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >Cc: Anton Kolesov <Anton.Kolesov@synopsys.com>
> >---
> > arch/Config.in | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/arch/Config.in b/arch/Config.in
> >index 6bcafd4..1126d43 100644
> >--- a/arch/Config.in
> >+++ b/arch/Config.in
> >@@ -253,7 +253,6 @@ config BR2_GCC_TARGET_MODE
> > # If the architecture has atomic operations, select this:
> > config BR2_ARCH_HAS_ATOMICS
> > 	bool
> >-	default y if !BR2_arc
> > 
> > # Set up target binary format
> > choice
> 
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 07/24 v4] manual: document dependencies on atomic operations

[Thomas De Schampheleire]

"Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>Thomas, All,
>
>On 2014-08-17 15:01 +0200, Thomas De Schampheleire spake thusly:
>> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>> >From: Anton Kolesov <anton.kolesov@synopsys.com>
>> >
>> >Add atomic operations to the list of generic dependencies.
>> >
>> >Since this is an architecture option, there is no comment string to be
>> >added.
>> >
>> >Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
>> >[yann.morin.1998 at free.fr: use the new arch-option; remove comment string]
>> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> >---
>> > docs/manual/adding-packages-directory.txt | 4 ++++
>> > 1 file changed, 4 insertions(+)
>> >
>> >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
>> >index 93e6a3e..40a81d5 100644
>> >--- a/docs/manual/adding-packages-directory.txt
>> >+++ b/docs/manual/adding-packages-directory.txt
>> >@@ -219,6 +219,10 @@ use in the comment.
>> > ** Dependency symbol: +BR2_USE_MMU+
>> > ** Comment string: no comment to be added
>> > 
>> >+* Atomic operations
>> >+** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
>> >+** Comment string: no comment to be added
>> >+
>> 
>> Should we provide a brief explanation, reference, or
>>  name of these functions to make it a bit clearer what
>> is meant with 'atomic operations'?
>
>Well, the atomics are all named differently in different architectures.
>
>For example, armv6+ has LDREX and STREX (amon others):
>    http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0008a/ch01s02s01.html
>
>While on x86, I don't think there are corresponding instructions, but
>you can prefix some intructions with the LOCK prefix to achieve a
>similar result.
>
>So, I would not know what to put in here. Also, we do not explain what
>the other options are (like MMU, for example). Why would we do that for
>this specific option, and not others?


Because MMU is a widely known acronym for anyone in the embedded world, but 'atomics' or 'atomic operations' is a much more general term that is less obvious, IMHO.

Maybe the description can clarify that we're talking about a dependency on _CPU_ atomic _instructions_?

[Buildroot] [PATCH 07/24 v4] manual: document dependencies on atomic operations

[Yann E. MORIN]

Thomas, All,

On 2014-08-17 15:25 +0200, Thomas De Schampheleire spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
> >Thomas, All,
> >
> >On 2014-08-17 15:01 +0200, Thomas De Schampheleire spake thusly:
> >> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
> >> >From: Anton Kolesov <anton.kolesov@synopsys.com>
> >> >
> >> >Add atomic operations to the list of generic dependencies.
> >> >
> >> >Since this is an architecture option, there is no comment string to be
> >> >added.
> >> >
> >> >Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
> >> >[yann.morin.1998 at free.fr: use the new arch-option; remove comment string]
> >> >Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >> >---
> >> > docs/manual/adding-packages-directory.txt | 4 ++++
> >> > 1 file changed, 4 insertions(+)
> >> >
> >> >diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt
> >> >index 93e6a3e..40a81d5 100644
> >> >--- a/docs/manual/adding-packages-directory.txt
> >> >+++ b/docs/manual/adding-packages-directory.txt
> >> >@@ -219,6 +219,10 @@ use in the comment.
> >> > ** Dependency symbol: +BR2_USE_MMU+
> >> > ** Comment string: no comment to be added
> >> > 
> >> >+* Atomic operations
> >> >+** Dependency symbol: +BR2_ARCH_HAS_ATOMICS+
> >> >+** Comment string: no comment to be added
> >> >+
> >> 
> >> Should we provide a brief explanation, reference, or
> >>  name of these functions to make it a bit clearer what
> >> is meant with 'atomic operations'?
> >
> >Well, the atomics are all named differently in different architectures.
> >
> >For example, armv6+ has LDREX and STREX (amon others):
> >    http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0008a/ch01s02s01.html
> >
> >While on x86, I don't think there are corresponding instructions, but
> >you can prefix some intructions with the LOCK prefix to achieve a
> >similar result.
> >
> >So, I would not know what to put in here. Also, we do not explain what
> >the other options are (like MMU, for example). Why would we do that for
> >this specific option, and not others?
> 
> Because MMU is a widely known acronym for anyone in the embedded world,
> but 'atomics' or 'atomic operations' is a much more general term that
> is less obvious, IMHO.

Weird how different people, even from the same field, would consider one
thing as a fundamentals and not some other thing, or the opposite. :-)

> Maybe the description can clarify that we're talking about a dependency
> on _CPU_ atomic _instructions_?

OK, let's strike a deal: I keep the option name as-is (I like it), but I
add a bit of explanations in the manual. Deal? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'