* [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture
@ 2014-09-03 15:10 Vicente Olivert Riera
2014-09-04 15:30 ` Peter Korsgaard
2014-09-07 8:18 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Vicente Olivert Riera @ 2014-09-03 15:10 UTC (permalink / raw)
To: buildroot
The default ABI used in boost is 'sysv' which is not valid for MIPS.
Given the boost build system doesn't detect the right ABI when we are
cross-compiling, we fix this by passing the right ABI directly to the
boost options for the target.
Related:
https://svn.boost.org/trac/boost/ticket/10442
Fixes:
http://autobuild.buildroot.net/results/79f/79fe4caffb9a3b9f1b203498a589a5172bd0acea/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/boost/boost.mk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/boost/boost.mk b/package/boost/boost.mk
index 2cd76ce..ac67e3c 100644
--- a/package/boost/boost.mk
+++ b/package/boost/boost.mk
@@ -82,6 +82,7 @@ HOST_BOOST_OPT += toolset=gcc threading=multi variant=release link=shared \
BOOST_OPT += toolset=gcc \
threading=multi \
+ abi=$(if $(BR2_MIPS_OABI32),o32,sysv) \
variant=$(if $(BR2_ENABLE_DEBUG),debug,release) \
link=$(if $(BR2_PREFER_STATIC_LIB),static,shared) \
runtime-link=$(if $(BR2_PREFER_STATIC_LIB),static,shared)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture
2014-09-03 15:10 [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture Vicente Olivert Riera
@ 2014-09-04 15:30 ` Peter Korsgaard
2014-09-07 8:18 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-09-04 15:30 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> The default ABI used in boost is 'sysv' which is not valid for MIPS.
> Given the boost build system doesn't detect the right ABI when we are
> cross-compiling, we fix this by passing the right ABI directly to the
> boost options for the target.
> Related:
> https://svn.boost.org/trac/boost/ticket/10442
> Fixes:
> http://autobuild.buildroot.net/results/79f/79fe4caffb9a3b9f1b203498a589a5172bd0acea/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture
2014-09-03 15:10 [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture Vicente Olivert Riera
2014-09-04 15:30 ` Peter Korsgaard
@ 2014-09-07 8:18 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-09-07 8:18 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Wed, 3 Sep 2014 16:10:49 +0100, Vicente Olivert Riera wrote:
> + abi=$(if $(BR2_MIPS_OABI32),o32,sysv) \
Are you sure this is sufficient to handle MIPS in Boost? Reading the
Boost code, I see that it also supports abi=n64 and abi=n32. Maybe you
should have a look and see if additional cases of ABIs are needed.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-09-07 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-03 15:10 [Buildroot] [PATCH] boost: Force the target ABI for MIPS architecture Vicente Olivert Riera
2014-09-04 15:30 ` Peter Korsgaard
2014-09-07 8:18 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox