From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] arch: do not distinguish revisions of ARM1136JF-S
Date: Mon, 15 Sep 2014 23:39:16 +0200 [thread overview]
Message-ID: <20140915233916.55c17894@free-electrons.com> (raw)
In-Reply-To: <20140915213339.GC3878@free.fr>
Dear Yann E. MORIN,
On Mon, 15 Sep 2014 23:33:39 +0200, Yann E. MORIN wrote:
> > Note that the removal of the two options should not break existing
> > full .config, since the hidden option BR2_arm1136jf_s becomes again a
> > visible option to select the CPU.
>
> But it would break a defconfig.
Right. But I believe that when we change the default value of an
option, we also break a defconfig, and we don't include that as part of
the Config.in.legacy handling (but also because it's obviously more
complicated).
> As suggested on IRC, move the BR2_arm1136jf_s_r1 to Config.legacy, and
> have it select BR2_arm1136jf_s, so the user can re-use a defconfig.
Hum, why just BR2_arm1136jf_s_r1 and not BR2_arm1136jf_s_r0 ?
Thanks for the review!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-15 21:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 21:01 [Buildroot] [PATCH 0/4] Fix march/mcpu conflict on ARM Thomas Petazzoni
2014-09-15 21:01 ` [Buildroot] [PATCH 1/4] arch: remove BR2_arm920 reference Thomas Petazzoni
2014-09-15 21:08 ` Yann E. MORIN
2014-09-18 20:12 ` Peter Korsgaard
2014-09-15 21:01 ` [Buildroot] [PATCH 2/4] arch: remove BR2_arm10t Thomas Petazzoni
2014-09-15 21:13 ` Yann E. MORIN
2014-09-15 21:16 ` Thomas Petazzoni
2014-09-18 20:12 ` Peter Korsgaard
2014-09-15 21:01 ` [Buildroot] [PATCH 3/4] arch: do not distinguish revisions of ARM1136JF-S Thomas Petazzoni
2014-09-15 21:16 ` Benoît Thébaudeau
2014-09-15 21:33 ` Yann E. MORIN
2014-09-15 21:39 ` Thomas Petazzoni [this message]
2014-09-15 21:44 ` Benoît Thébaudeau
2014-09-15 21:50 ` Thomas Petazzoni
2014-09-15 22:36 ` Benoît Thébaudeau
2014-09-15 22:02 ` Yann E. MORIN
2014-09-15 22:37 ` Benoît Thébaudeau
2014-09-15 21:48 ` Yann E. MORIN
2014-09-15 21:01 ` [Buildroot] [PATCH 4/4] arch: remove BR2_GCC_TARGET_ARCH definitions on ARM Thomas Petazzoni
2014-09-15 22:09 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915233916.55c17894@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox