Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"
@ 2014-09-15 14:49 Alexey Brodkin
  2014-09-16 19:45 ` Thomas Petazzoni
  2014-09-16 21:10 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Alexey Brodkin @ 2014-09-15 14:49 UTC (permalink / raw)
  To: buildroot

This makes size_t to be "unsigned" ssize_t which makes happy compiler on data
type checks.

Fix is taken from current development branch of GCC for ARC and will be a
part of the next release of ARC tools, so at that point patch should be dropped.

https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3

Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

Cc: Anton Kolesov <akolesov@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
---

Compared to v1 comment is added in the patch itself with more info on its
origin and reasoning.

---

 .../arc-2014.08/200-size_type_unsigned_int.patch   | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 package/gcc/arc-2014.08/200-size_type_unsigned_int.patch

diff --git a/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch b/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch
new file mode 100644
index 0000000..4636524
--- /dev/null
+++ b/package/gcc/arc-2014.08/200-size_type_unsigned_int.patch
@@ -0,0 +1,22 @@
+Fixes SIZE_TYPE to be "unsigned int" instead of "long unsigned int".
+
+This makes size_t to be "unsigned" ssize_t which makes happy compiler on data
+type checks.
+
+Fix is taken from current development branch of GCC for ARC and will be a
+part of the next release of ARC tools, so at that point patch should be dropped.
+
+https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3
+---
+
+--- a/gcc/config/arc/arc.h
++++ b/gcc/config/arc/arc.h
+@@ -487,7 +487,7 @@ if (GET_MODE_CLASS (MODE) == MODE_INT		\
+ /* Define this as 1 if `char' should by default be signed; else as 0.  */
+ #define DEFAULT_SIGNED_CHAR 0
+ 
+-#define SIZE_TYPE "long unsigned int"
++#define SIZE_TYPE "unsigned int"
+ #define PTRDIFF_TYPE "long int"
+ #define WCHAR_TYPE "int"
+ #define WCHAR_TYPE_SIZE 32
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"
  2014-09-15 14:49 [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int" Alexey Brodkin
@ 2014-09-16 19:45 ` Thomas Petazzoni
  2014-09-16 21:10 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-09-16 19:45 UTC (permalink / raw)
  To: buildroot

Dear Alexey Brodkin,

On Mon, 15 Sep 2014 18:49:53 +0400, Alexey Brodkin wrote:
> This makes size_t to be "unsigned" ssize_t which makes happy compiler on data
> type checks.
> 
> Fix is taken from current development branch of GCC for ARC and will be a
> part of the next release of ARC tools, so at that point patch should be dropped.
> 
> https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3
> 
> Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> 
> Cc: Anton Kolesov <akolesov@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

though you still forgot to add your SoB in the patch itself. I guess
Peter can add it when applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int"
  2014-09-15 14:49 [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int" Alexey Brodkin
  2014-09-16 19:45 ` Thomas Petazzoni
@ 2014-09-16 21:10 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-09-16 21:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Alexey" == Alexey Brodkin <Alexey.Brodkin@synopsys.com> writes:

 > This makes size_t to be "unsigned" ssize_t which makes happy compiler on data
 > type checks.

 > Fix is taken from current development branch of GCC for ARC and will be a
 > part of the next release of ARC tools, so at that point patch should be dropped.

 > https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/commit/249f040299402647525c3f15b79d319fa7acddd3

 > Fixes http://autobuild.buildroot.net/results/405/405da9a945511329929b18740b983c51b8dcc43e

 > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>

 > Cc: Anton Kolesov <akolesov@synopsys.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Cc: Peter Korsgaard <peter@korsgaard.com>
 > ---

 > Compared to v1 comment is added in the patch itself with more info on its
 > origin and reasoning.

Committed, thanks.

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-16 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 14:49 [Buildroot] [PATCH v2] ARC: gcc - Fix SIZE_TYPE to be "unsigned int" instead of "long unsigned int" Alexey Brodkin
2014-09-16 19:45 ` Thomas Petazzoni
2014-09-16 21:10 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox