From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
Date: Wed, 17 Sep 2014 14:00:59 +0200 [thread overview]
Message-ID: <20140917140059.0eee9af9@free-electrons.com> (raw)
In-Reply-To: <1410953999-16520-4-git-send-email-cvubrugier@fastmail.fm>
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 13:39:56 +0200, Christophe Vu-Brugier wrote:
> diff --git a/package/python-rtslib-fb/Config.in b/package/python-rtslib-fb/Config.in
> new file mode 100644
> index 0000000..b2aebcf
> --- /dev/null
> +++ b/package/python-rtslib-fb/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_PYTHON_RTSLIB_FB
> + bool "python-rtslib-fb"
> + depends on BR2_PACKAGE_PYTHON
Is it for this package that you had the Python 3 issue? Could you
explain a bit more the 2to3 problems you have seen?
> + help
> + rtslib-fb is an object-based Python library for configuring
> + the LIO generic SCSI target, present in 3.x Linux kernel
> + versions.
> +
> + https://github.com/agrover/rtslib-fb
> diff --git a/package/python-rtslib-fb/python-rtslib.mk b/package/python-rtslib-fb/python-rtslib.mk
> new file mode 100644
> index 0000000..70b0257
> --- /dev/null
> +++ b/package/python-rtslib-fb/python-rtslib.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# python-rtslib-fb
> +#
> +################################################################################
> +
> +PYTHON_RTSLIB_FB_VERSION = v2.1.fb49
> +PYTHON_RTSLIB_FB_SITE = $(call github,agrover,rtslib-fb,$(PYTHON_RTSLIB_FB_VERSION))
> +PYTHON_RTSLIB_FB_LICENSE = Apache-2.0
> +PYTHON_RTSLIB_FB_LICENSE_FILES = COPYING
> +PYTHON_RTSLIB_FB_SETUP_TYPE = setuptools
> +
> +$(eval $(python-package))
Other than that, the patch looks good to me, and the Python 3 support
can always be added later:
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-17 12:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
2014-09-17 11:59 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
2014-09-17 12:00 ` Thomas Petazzoni [this message]
2014-09-17 13:13 ` Christophe Vu-Brugier
2014-09-17 13:15 ` Thomas Petazzoni
2014-09-17 15:21 ` Christophe Vu-Brugier
2014-09-17 15:29 ` Thomas Petazzoni
2014-09-17 20:00 ` Jerzy Grzegorek
2014-09-18 7:39 ` Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
2014-09-17 12:03 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 5/6] targetcli-fb: " Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
2014-09-17 12:12 ` Thomas Petazzoni
2014-09-17 13:19 ` Christophe Vu-Brugier
2014-09-17 13:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917140059.0eee9af9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox