From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/6] python-rtslib-fb: new package
Date: Wed, 17 Sep 2014 15:15:52 +0200 [thread overview]
Message-ID: <20140917151552.6d0d0e91@free-electrons.com> (raw)
In-Reply-To: <20140917151302.08303544@grp-cvubrugier>
Dear Christophe Vu-Brugier,
On Wed, 17 Sep 2014 15:13:02 +0200, Christophe Vu-Brugier wrote:
> Thank you for the prompt review.
You're welcome. Thanks for submitting those packages in the first place!
> > Is it for this package that you had the Python 3 issue? Could you
> > explain a bit more the 2to3 problems you have seen?
>
> It is for this package (and for configshell-fb and targetcli-fb) that I
> thought I had an issue with `2to3`.
> But I was wrong because it seems that `2to3` is correctly invoked by
> setup.py when it is run under Python 3.
> The installed python files are different from the source python files
> and are modified by `2to3`:
>
> --- build/python-rtslib-fb-v2.1.fb49/rtslib/utils.py
> +++ target/usr/lib/python3.4/site-packages/rtslib/utils.py
> @@ -435,14 +435,14 @@
> raise
>
> def set_attributes(obj, attr_dict, err_func):
> - for name, value in attr_dict.iteritems():
> + for name, value in attr_dict.items():
>
> So if there is an issue, it is not caused by a broken `2to3`.
Indeed, this modification looks like a Python 2 vs. Python 3
conversion, even though I'm not familiar enough with the Python
language changes to be sure.
What was the issue you had with Python 3 ?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-17 13:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 11:39 [Buildroot] [PATCH 0/6] targetcli-fb: new package Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 1/6] python, python3: add patch to prevent distutils from adjusting the shebang Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 2/6] python-urwid: new package Christophe Vu-Brugier
2014-09-17 11:59 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 3/6] python-rtslib-fb: " Christophe Vu-Brugier
2014-09-17 12:00 ` Thomas Petazzoni
2014-09-17 13:13 ` Christophe Vu-Brugier
2014-09-17 13:15 ` Thomas Petazzoni [this message]
2014-09-17 15:21 ` Christophe Vu-Brugier
2014-09-17 15:29 ` Thomas Petazzoni
2014-09-17 20:00 ` Jerzy Grzegorek
2014-09-18 7:39 ` Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 4/6] python-configshell-fb: " Christophe Vu-Brugier
2014-09-17 12:03 ` Thomas Petazzoni
2014-09-17 11:39 ` [Buildroot] [PATCH 5/6] targetcli-fb: " Christophe Vu-Brugier
2014-09-17 11:39 ` [Buildroot] [PATCH 6/6] targetcli-fb: add sysv initscript Christophe Vu-Brugier
2014-09-17 12:12 ` Thomas Petazzoni
2014-09-17 13:19 ` Christophe Vu-Brugier
2014-09-17 13:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917151552.6d0d0e91@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox