From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] swig: add symlink to /usr/bin/swig2.0
Date: Sun, 21 Sep 2014 20:07:37 +0200 [thread overview]
Message-ID: <20140921200737.740f2bc0@free-electrons.com> (raw)
In-Reply-To: <1411110831-27676-3-git-send-email-jeremy.rosen@openwide.fr>
Dear J?r?my Rosen,
On Fri, 19 Sep 2014 09:13:51 +0200, J?r?my Rosen wrote:
> the cmake detection script provided with cmake will first look for a
> binary called swig2.0 then for a binary called swig
>
> swig-host only installs a binary called swig and gets overridden by the
> version installed by the host distro. This symlink prevents that from
> happening
I don't understand the explanation: if it looks for a binary called
swig, then where's the need to create a swig2.0 symbolic link? How a
binary in $(HOST_DIR)/usr/bin can get overridden by the version
installed by the host distro?
The SoB line is missing.
> diff --git a/package/swig/swig.mk b/package/swig/swig.mk
> index 5efc81c..233e97d 100644
> --- a/package/swig/swig.mk
> +++ b/package/swig/swig.mk
> @@ -15,4 +15,10 @@ HOST_SWIG_CONF_OPT = \
> SWIG_LICENSE = GPLv3+ BSD-2c BSD-3c
> SWIG_LICENSE_FILES = LICENSE LICENSE-GPL LICENSE-UNIVERSITIES
>
> +define SWIG_INSTALL_SYMLINK
Should be HOST_SWITCH_INSTALL_SYMLINK.
I've marked your patch as "Changes requested" in patchwork.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-21 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 7:13 [Buildroot] [PATCH] cmake : bump to version 3.0.2 Jérémy Rosen
2014-09-19 7:13 ` [Buildroot] [PATCH] swig : bump to version 2.0.12 Jérémy Rosen
2014-09-21 18:06 ` Thomas Petazzoni
2014-09-19 7:13 ` [Buildroot] [PATCH] swig: add symlink to /usr/bin/swig2.0 Jérémy Rosen
2014-09-21 18:07 ` Thomas Petazzoni [this message]
2014-09-22 7:38 ` Jeremy Rosen
2014-09-22 8:00 ` Thomas Petazzoni
2014-09-19 7:27 ` [Buildroot] [PATCH] cmake : bump to version 3.0.2 Jeremy Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140921200737.740f2bc0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox