Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] ffmpeg: enable or disable debug based on BR2_ENABLE_DEBUG
Date: Sun, 21 Sep 2014 22:51:22 +0200	[thread overview]
Message-ID: <20140921225122.4a2c477a@free-electrons.com> (raw)
In-Reply-To: <1410228406-2140-2-git-send-email-danomimanchego123@gmail.com>

Dear Danomi Manchego,

On Mon,  8 Sep 2014 22:06:45 -0400, Danomi Manchego wrote:

>  FFMPEG_CONF_OPT = \
> -	--prefix=/usr		\
> +	--prefix=/usr \

Unrelated change, so I removed this change from the patch.

>  	--enable-avfilter \
> -	--disable-debug \
>  	--disable-version3 \
>  	--enable-logging \
>  	--enable-optimizations \
> @@ -68,6 +67,12 @@ FFMPEG_CONF_OPT = \
>  
>  FFMPEG_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
>  
> +ifeq ($(BR2_ENABLE_DEBUG),y)
> +FFMPEG_CONF_OPT += --enable-debug
> +else
> +FFMPEG_CONF_OPT += --disable-debug
> +endif
> +
>  ifeq ($(BR2_PACKAGE_FFMPEG_GPL),y)
>  FFMPEG_CONF_OPT += --enable-gpl
>  else

Other than that, applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-09-21 20:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  2:06 [Buildroot] [PATCH 1/3] ffmpeg: consolidate duplicated config options Danomi Manchego
2014-09-09  2:06 ` [Buildroot] [PATCH 2/3] ffmpeg: enable or disable debug based on BR2_ENABLE_DEBUG Danomi Manchego
2014-09-21 20:51   ` Thomas Petazzoni [this message]
2014-09-09  2:06 ` [Buildroot] [PATCH 3/3] ffmpeg: add --pkg-config to configure options Danomi Manchego
2014-09-21 20:55   ` Thomas Petazzoni
2014-09-21 20:48 ` [Buildroot] [PATCH 1/3] ffmpeg: consolidate duplicated config options Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140921225122.4a2c477a@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox