From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] ffmpeg: add --pkg-config to configure options
Date: Sun, 21 Sep 2014 22:55:28 +0200 [thread overview]
Message-ID: <20140921225528.47f45e50@free-electrons.com> (raw)
In-Reply-To: <1410228406-2140-3-git-send-email-danomimanchego123@gmail.com>
Dear Danomi Manchego,
On Mon, 8 Sep 2014 22:06:46 -0400, Danomi Manchego wrote:
> The ffmpeg does not understand the PKG_CONFIG env variable,
> so it throws a line like this at the end of its configuration:
>
> WARNING: .../output/host/usr/bin/arm-none-linux-gnueabi-pkg-config not found, library detection may fail.
>
> Apparently, some of the indevs and outdevs need a pkg-config.
> This patch adds the --pkg-config to let ffmpeg know where it
> is.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
> package/ffmpeg/ffmpeg.mk | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/ffmpeg/ffmpeg.mk b/package/ffmpeg/ffmpeg.mk
> index d50720b..b1d524e 100644
> --- a/package/ffmpeg/ffmpeg.mk
> +++ b/package/ffmpeg/ffmpeg.mk
> @@ -65,7 +65,7 @@ FFMPEG_CONF_OPT = \
> --disable-symver \
> --disable-doc
>
> -FFMPEG_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv)
> +FFMPEG_DEPENDENCIES += $(if $(BR2_PACKAGE_LIBICONV),libiconv) host-pkgconf
>
> ifeq ($(BR2_ENABLE_DEBUG),y)
> FFMPEG_CONF_OPT += --enable-debug
> @@ -327,13 +327,14 @@ define FFMPEG_CONFIGURE_CMDS
> $(TARGET_CONFIGURE_ARGS) \
> $(FFMPEG_CONF_ENV) \
> ./configure \
> - --enable-cross-compile \
> + --enable-cross-compile \
Unrelated change.
> --cross-prefix=$(TARGET_CROSS) \
> --sysroot=$(STAGING_DIR) \
> --host-cc="$(HOSTCC)" \
> --arch=$(BR2_ARCH) \
> --target-os="linux" \
> --disable-stripping \
> + --pkg-config="$(PKG_CONFIG_HOST_BINARY)" \
> $(if $(BR2_GCC_TARGET_TUNE),--cpu=$(BR2_GCC_TARGET_TUNE)) \
> $(SHARED_STATIC_LIBS_OPTS) \
> $(FFMPEG_CONF_OPT) \
So I've removed the unrelated change, and committed your patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-09-21 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 2:06 [Buildroot] [PATCH 1/3] ffmpeg: consolidate duplicated config options Danomi Manchego
2014-09-09 2:06 ` [Buildroot] [PATCH 2/3] ffmpeg: enable or disable debug based on BR2_ENABLE_DEBUG Danomi Manchego
2014-09-21 20:51 ` Thomas Petazzoni
2014-09-09 2:06 ` [Buildroot] [PATCH 3/3] ffmpeg: add --pkg-config to configure options Danomi Manchego
2014-09-21 20:55 ` Thomas Petazzoni [this message]
2014-09-21 20:48 ` [Buildroot] [PATCH 1/3] ffmpeg: consolidate duplicated config options Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140921225528.47f45e50@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox