* [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build
@ 2014-08-18 22:03 Alexey Brodkin
2014-08-18 22:03 ` [Buildroot] [PATCH 1/2] binutils: troubleshoot native binutils building (add WCHAR dependency) Alexey Brodkin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Alexey Brodkin @ 2014-08-18 22:03 UTC (permalink / raw)
To: buildroot
binutils starting at least from 2.23 when build for target require uClibc
configured with UCLIBC_HAS_WCHAR otherwise:
==========
libtool: link: [...] -o as-new [...]
read.o: In function `read_symbol_name':
read.c:(.text+0x3634): undefined reference to `mbstowcs'
collect2: error: ld returned 1 exit status
==========
because "mbstowcs" won't be compiled in.
That's why we need to make sure WCHAR is enabled in toolchain for all
packages that require native binutils.
Alexey Brodkin (2):
binutils: troubleshoot native binutils building (add WCHAR dependency)
packages: add WCHAR dependency for packages that select native
binutils
package/binutils/Config.in | 1 +
package/dropwatch/Config.in | 1 +
package/oprofile/Config.in | 1 +
3 files changed, 3 insertions(+)
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/2] binutils: troubleshoot native binutils building (add WCHAR dependency) 2014-08-18 22:03 [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin @ 2014-08-18 22:03 ` Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 2/2] packages: add WCHAR dependency for packages that select native binutils Alexey Brodkin 2014-09-23 11:05 ` [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2 siblings, 0 replies; 6+ messages in thread From: Alexey Brodkin @ 2014-08-18 22:03 UTC (permalink / raw) To: buildroot binutils starting at least from 2.23 when build for target require uClibc configured with UCLIBC_HAS_WCHAR otherwise: ========== libtool: link: [...] -o as-new [...] read.o: In function `read_symbol_name': read.c:(.text+0x3634): undefined reference to `mbstowcs' collect2: error: ld returned 1 exit status ========== because "mbstowcs" won't be compiled in. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Anton Kolesov <akolesov@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/binutils/Config.in | 1 + 1 file changed, 1 insertion(+) diff --git a/package/binutils/Config.in b/package/binutils/Config.in index 44e7ae0..d59a631 100644 --- a/package/binutils/Config.in +++ b/package/binutils/Config.in @@ -2,6 +2,7 @@ config BR2_PACKAGE_BINUTILS bool "binutils" select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE depends on !BR2_aarch64 && !BR2_nios2 + depends on BR2_USE_WCHAR help Install binutils on the target -- 1.9.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] packages: add WCHAR dependency for packages that select native binutils 2014-08-18 22:03 [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 1/2] binutils: troubleshoot native binutils building (add WCHAR dependency) Alexey Brodkin @ 2014-08-18 22:03 ` Alexey Brodkin 2014-09-23 11:05 ` [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2 siblings, 0 replies; 6+ messages in thread From: Alexey Brodkin @ 2014-08-18 22:03 UTC (permalink / raw) To: buildroot Native binutils require uClibc with WCHAR. Otherwise build stops with error - https://bugs.busybox.net/show_bug.cgi?id=6218 Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Anton Kolesov <akolesov@synopsys.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/dropwatch/Config.in | 1 + package/oprofile/Config.in | 1 + 2 files changed, 2 insertions(+) diff --git a/package/dropwatch/Config.in b/package/dropwatch/Config.in index 0c9aca6..a19b29f 100644 --- a/package/dropwatch/Config.in +++ b/package/dropwatch/Config.in @@ -5,6 +5,7 @@ config BR2_PACKAGE_DROPWATCH select BR2_PACKAGE_READLINE select BR2_PACKAGE_LIBNL depends on BR2_TOOLCHAIN_HAS_THREADS # libnl + depends on BR2_USE_WCHAR # native binutils require WCHAR help Dropwatch is an interactive utility for monitoring and recording packets that are dropped by the kernel diff --git a/package/oprofile/Config.in b/package/oprofile/Config.in index 075e9ea..4dca560 100644 --- a/package/oprofile/Config.in +++ b/package/oprofile/Config.in @@ -9,6 +9,7 @@ config BR2_PACKAGE_OPROFILE depends on !BR2_xtensa # libpfm4 is needed on PowerPC, and requires thread support depends on BR2_TOOLCHAIN_HAS_THREADS || !BR2_powerpc + depends on BR2_USE_WCHAR # native binutils require WCHAR help OProfile is a system-wide profiler for Linux systems, capable of profiling all running code at low overhead. -- 1.9.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build 2014-08-18 22:03 [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 1/2] binutils: troubleshoot native binutils building (add WCHAR dependency) Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 2/2] packages: add WCHAR dependency for packages that select native binutils Alexey Brodkin @ 2014-09-23 11:05 ` Alexey Brodkin 2014-09-23 11:22 ` Thomas Petazzoni 2 siblings, 1 reply; 6+ messages in thread From: Alexey Brodkin @ 2014-09-23 11:05 UTC (permalink / raw) To: buildroot Hi Thomas, On Tue, 2014-08-19 at 02:03 +0400, Alexey Brodkin wrote: > binutils starting at least from 2.23 when build for target require uClibc > configured with UCLIBC_HAS_WCHAR otherwise: > ========== > libtool: link: [...] -o as-new [...] > read.o: In function `read_symbol_name': > read.c:(.text+0x3634): undefined reference to `mbstowcs' > collect2: error: ld returned 1 exit status > ========== > because "mbstowcs" won't be compiled in. > > That's why we need to make sure WCHAR is enabled in toolchain for all > packages that require native binutils. > > Alexey Brodkin (2): > binutils: troubleshoot native binutils building (add WCHAR dependency) > packages: add WCHAR dependency for packages that select native > binutils > > package/binutils/Config.in | 1 + > package/dropwatch/Config.in | 1 + > package/oprofile/Config.in | 1 + > 3 files changed, 3 insertions(+) > Looks like this series got lost among other patches. Do you mind to revisit following patches? 1) http://patchwork.ozlabs.org/patch/381143/ 2) http://patchwork.ozlabs.org/patch/381144/ -Alexey ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build 2014-09-23 11:05 ` [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin @ 2014-09-23 11:22 ` Thomas Petazzoni 2014-09-23 11:31 ` Alexey Brodkin 0 siblings, 1 reply; 6+ messages in thread From: Thomas Petazzoni @ 2014-09-23 11:22 UTC (permalink / raw) To: buildroot Dear Alexey Brodkin, On Tue, 23 Sep 2014 11:05:59 +0000, Alexey Brodkin wrote: > Looks like this series got lost among other patches. No series get lost: you can check at http://patchwork.ozlabs.org/project/buildroot/list/. If your patches still appear in the "New" state, then it means they have not been lost. It's just that we haven't had the time to review, test and apply them. There are currently 283 patches waiting in the queue, so you can imagine it's a huge work to review, test and apply all those patches. If you want to speed things up for your patches, there's only one way: review and test patches posted by other developers. By having feedback on patches, we can apply them more quickly, therefore reducing the patch queue, and getting more quickly to your patches. That being said, those two patches, and your other patches touching toolchain stuff are on my TODO list for review/testing, as I've done quite a bit of toolchain stuff lately. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build 2014-09-23 11:22 ` Thomas Petazzoni @ 2014-09-23 11:31 ` Alexey Brodkin 0 siblings, 0 replies; 6+ messages in thread From: Alexey Brodkin @ 2014-09-23 11:31 UTC (permalink / raw) To: buildroot Hi Thomas, On Tue, 2014-09-23 at 13:22 +0200, Thomas Petazzoni wrote: > Dear Alexey Brodkin, > > On Tue, 23 Sep 2014 11:05:59 +0000, Alexey Brodkin wrote: > > > Looks like this series got lost among other patches. > > No series get lost: you can check at > http://patchwork.ozlabs.org/project/buildroot/list/. If your patches > still appear in the "New" state, then it means they have not been lost. > It's just that we haven't had the time to review, test and apply them. > > There are currently 283 patches waiting in the queue, so you can > imagine it's a huge work to review, test and apply all those patches. > > If you want to speed things up for your patches, there's only one way: > review and test patches posted by other developers. By having feedback > on patches, we can apply them more quickly, therefore reducing the > patch queue, and getting more quickly to your patches. > > That being said, those two patches, and your other patches touching > toolchain stuff are on my TODO list for review/testing, as I've done > quite a bit of toolchain stuff lately. Thanks for this explanation. This is something I was thinking about and I do understand how busy you guys are - respect your efforts very much and cannot ask for something more :) Indeed it would be good to contribute not only with my pwn patches but review/test others as well. Will try to participate more as much as workload allows. As for my reminders I'm just trying to make sure stuff that affects me gets upstreamed sometime soon. Still I'm trying to not be noisy - if my reminders really annoy you guys I'll try to send them only in case of emergency. -Alexey ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-09-23 11:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-08-18 22:03 [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 1/2] binutils: troubleshoot native binutils building (add WCHAR dependency) Alexey Brodkin 2014-08-18 22:03 ` [Buildroot] [PATCH 2/2] packages: add WCHAR dependency for packages that select native binutils Alexey Brodkin 2014-09-23 11:05 ` [Buildroot] [PATCH 0/2] Make sure WCHAR is enabled if native binutils will be build Alexey Brodkin 2014-09-23 11:22 ` Thomas Petazzoni 2014-09-23 11:31 ` Alexey Brodkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox