From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] openocd bump to 0.8.0
Date: Wed, 8 Oct 2014 23:10:40 +0200 [thread overview]
Message-ID: <20141008231040.57406af4@free-electrons.com> (raw)
In-Reply-To: <1412801633-3394-1-git-send-email-claudio.laurita@integrazionetotale.it>
Dear Claudio Laurita,
Thanks for this contribution! See some comments below.
On Wed, 8 Oct 2014 22:53:53 +0200, Claudio Laurita wrote:
> Signed-off-by: Claudio Laurita <claudio.laurita@integrazionetotale.it>
> ---
> .../openocd/001-fix-gcc-warning-in-mini51.patch | 13 ++
> package/openocd/Config.in | 191 +++++++++++++++++++--
> ...s-compilation-host-libsub-was-used-before.patch | 33 ----
> ...002-fix-xscale-uninitialise-breakpoint_pc.patch | 20 ---
> package/openocd/openocd-0003-force-gnu99.patch | 19 --
> .../openocd/openocd-0004-force_jimtcl_static.patch | 25 ---
> .../openocd/openocd-0005-dont-force-ldflags.patch | 37 ----
> package/openocd/openocd-0006-automake-compat.patch | 40 -----
> package/openocd/openocd.mk | 150 ++++++++++++++--
> 9 files changed, 330 insertions(+), 198 deletions(-)
> create mode 100644 package/openocd/001-fix-gcc-warning-in-mini51.patch
> delete mode 100644 package/openocd/openocd-0001-fix-cross-compilation-host-libsub-was-used-before.patch
> delete mode 100644 package/openocd/openocd-0002-fix-xscale-uninitialise-breakpoint_pc.patch
> delete mode 100644 package/openocd/openocd-0003-force-gnu99.patch
> delete mode 100644 package/openocd/openocd-0004-force_jimtcl_static.patch
> delete mode 100644 package/openocd/openocd-0005-dont-force-ldflags.patch
> delete mode 100644 package/openocd/openocd-0006-automake-compat.patch
The patch is doing a lot more than just bumping the version, so it
would be good to have some details about the changes that are made.
>
> diff --git a/package/openocd/001-fix-gcc-warning-in-mini51.patch b/package/openocd/001-fix-gcc-warning-in-mini51.patch
> new file mode 100644!
> index 0000000..514d166
> --- /dev/null
> +++ b/package/openocd/001-fix-gcc-warning-in-mini51.patch
Patches should have a description + Signed-off-by. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
> -HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
> +HOST_OPENOCD_CONF_OPTS = $(OPENOCD_CONF_OPTS)
Target options should normally not affect the build of host tools:
remember that someone can enable the host OpenOCD without building the
target OpenOCD.
> +# force disabling shared libraries to let jimtcl build its static version
> +SHARED_STATIC_LIBS_OPTS=
This is clearly not a solution: the namespace of variables in Buildroot
is global, so you are not allowed to modify such a global variable. You
can always force --enable-static --disable-shared in OPENOCD_CONF_OPTS
if needed.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-08 21:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:53 [Buildroot] [PATCH 1/1] openocd bump to 0.8.0 Claudio Laurita
2014-10-08 21:10 ` Thomas Petazzoni [this message]
2014-10-08 23:01 ` Claudio Laurita
2014-10-09 7:57 ` Thomas Petazzoni
2014-10-09 9:30 ` Claudio Laurita
2014-10-09 11:28 ` Thomas Petazzoni
2014-10-09 15:13 ` Claudio Laurita
2014-10-29 22:28 ` Thomas Petazzoni
2014-11-27 22:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141008231040.57406af4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox