From: Claudio Laurita <claudio.laurita@integrazionetotale.it>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] openocd bump to 0.8.0
Date: Thu, 09 Oct 2014 01:01:25 +0200 [thread overview]
Message-ID: <5435C245.1090100@integrazionetotale.it> (raw)
In-Reply-To: <20141008231040.57406af4@free-electrons.com>
This is my first tentative of "real" collaboration, so thank you for the
patience.
> The patch is doing a lot more than just bumping the version, so it
would be good to have some details about the changes that are made.
Ok, I thought it was not a lot ;-)
>> diff --git a/package/openocd/001-fix-gcc-warning-in-mini51.patch b/package/openocd/001-fix-gcc-warning-in-mini51.patch
>> new file mode 100644!
>> index 0000000..514d166
>> --- /dev/null
>> +++ b/package/openocd/001-fix-gcc-warning-in-mini51.patch
> Patches should have a description + Signed-off-by. See
> http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
Ok. I thought it was inherited from the main patch. Silly thought.
>> -HOST_OPENOCD_DEPENDENCIES = host-libusb-compat host-libftdi
>> +HOST_OPENOCD_CONF_OPTS = $(OPENOCD_CONF_OPTS)
> Target options should normally not affect the build of host tools:
> remember that someone can enable the host OpenOCD without building the
> target OpenOCD.
You're perfectly right, obviously. I made an hard shortcut ;-)
I tried to find a way to avoid duplicating the logic of selecting
options and finding related real dependencies. In current version it's
not allowed any choice for the host and I think it's a limit.
Duplicating everything is a bit redundant, but my idea was terribly
based on my actual needs. I apologize.
>> +# force disabling shared libraries to let jimtcl build its static version
>> +SHARED_STATIC_LIBS_OPTS=
> This is clearly not a solution: the namespace of variables in Buildroot
> is global, so you are not allowed to modify such a global variable. You
> can always force --enable-static --disable-shared in OPENOCD_CONF_OPTS
> if needed.
>
This is a problem.
If I understand, changing this variable would affect every successive
step of the global build. Is this the point? Not bad, as a mistake. I
should have studied better the main makefile. Sorry.
Anyway, SHARED_STATIC_LIBS_OPT is added by default to the configure
parameters. If your default is having shared preferred, It ends up in a
first assignment to --enable-shared (the global) and a second one to
--disable-shared (the local). Unfortunately, jimtcl ignores the second
one and keeps building only the shared lib, making openocd build fail.
The current BR implementation applies a patch to auto.def of jimtcl to
force it ignore -enable-shared. I don't like much this approach and
tried to find an alternative to avoid the patch. So, the only way is
redefining OPENOCD_CONFIGURE_CMDS entirely?
Thank you very much for your attention.
Claudio
next prev parent reply other threads:[~2014-10-08 23:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:53 [Buildroot] [PATCH 1/1] openocd bump to 0.8.0 Claudio Laurita
2014-10-08 21:10 ` Thomas Petazzoni
2014-10-08 23:01 ` Claudio Laurita [this message]
2014-10-09 7:57 ` Thomas Petazzoni
2014-10-09 9:30 ` Claudio Laurita
2014-10-09 11:28 ` Thomas Petazzoni
2014-10-09 15:13 ` Claudio Laurita
2014-10-29 22:28 ` Thomas Petazzoni
2014-11-27 22:00 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5435C245.1090100@integrazionetotale.it \
--to=claudio.laurita@integrazionetotale.it \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox