Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [git commit] botan: limit to supported CPU architectures
@ 2014-10-08 19:52 Peter Korsgaard
  2014-10-09  4:56 ` yuvaraj.patil at wipro.com
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2014-10-08 19:52 UTC (permalink / raw)
  To: buildroot

commit: http://git.buildroot.net/buildroot/commit/?id=1737af367993326ee47e847bd755806c8a78ced8
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

See src/build-data/arch/ for the list of supported CPU architectures.

Fixes:

  http://autobuild.buildroot.org/results/69f/69fdecb06a03e6a95adfab70adf8ebf45971f0da/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Francois Perrad <fperrad@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/botan/Config.in |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/package/botan/Config.in b/package/botan/Config.in
index 4911872..b9e2e3a 100644
--- a/package/botan/Config.in
+++ b/package/botan/Config.in
@@ -1,6 +1,13 @@
+config BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
+	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_m68k    || \
+		BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
+		BR2_powerpc || BR2_powerpc64 || BR2_sparc || BR2_sh  || \
+		BR2_x86_64
+
 config BR2_PACKAGE_BOTAN
 	bool "botan"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
 	help
 	  Botan is a crypto library for C++
 
@@ -8,3 +15,4 @@ config BR2_PACKAGE_BOTAN
 
 comment "botan needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] botan: limit to supported CPU architectures
  2014-10-08 19:52 [Buildroot] [git commit] botan: limit to supported CPU architectures Peter Korsgaard
@ 2014-10-09  4:56 ` yuvaraj.patil at wipro.com
  2014-10-09  7:40   ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: yuvaraj.patil at wipro.com @ 2014-10-09  4:56 UTC (permalink / raw)
  To: buildroot

Hello Thomas, Peter,

Similar issue is reported on Blackfin architecture for this package.
http://autobuild.buildroot.net/results/a2a/a2ad841630b411df3fc26461a868fe796a8b67ff//

Does the fix provided in below email addresses this as well?

Thanks
Yuvaraj

-----Original Message-----
From: buildroot [mailto:buildroot-bounces at busybox.net] On Behalf Of Peter Korsgaard
Sent: Thursday, October 09, 2014 1:23 AM
To: buildroot at busybox.net
Subject: [Buildroot] [git commit] botan: limit to supported CPU architectures

commit: http://git.buildroot.net/buildroot/commit/?id=1737af367993326ee47e847bd755806c8a78ced8
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

See src/build-data/arch/ for the list of supported CPU architectures.

Fixes:

  http://autobuild.buildroot.org/results/69f/69fdecb06a03e6a95adfab70adf8ebf45971f0da/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Francois Perrad <fperrad@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/botan/Config.in |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/package/botan/Config.in b/package/botan/Config.in index 4911872..b9e2e3a 100644
--- a/package/botan/Config.in
+++ b/package/botan/Config.in
@@ -1,6 +1,13 @@
+config BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
+	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_m68k    || \
+		BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \
+		BR2_powerpc || BR2_powerpc64 || BR2_sparc || BR2_sh  || \
+		BR2_x86_64
+
 config BR2_PACKAGE_BOTAN
 	bool "botan"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
 	help
 	  Botan is a crypto library for C++
 
@@ -8,3 +15,4 @@ config BR2_PACKAGE_BOTAN
 
 comment "botan needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOTAN_ARCH_SUPPORTS
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [git commit] botan: limit to supported CPU architectures
  2014-10-09  4:56 ` yuvaraj.patil at wipro.com
@ 2014-10-09  7:40   ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-10-09  7:40 UTC (permalink / raw)
  To: buildroot

Hello Yuvaraj,

On Thu, 9 Oct 2014 04:56:28 +0000, yuvaraj.patil at wipro.com wrote:

> Similar issue is reported on Blackfin architecture for this package.
> http://autobuild.buildroot.net/results/a2a/a2ad841630b411df3fc26461a868fe796a8b67ff//
> 
> Does the fix provided in below email addresses this as well?

Yes, it does: as you can see by reading the patch, the fix consists in
adding a whitelist of the architectures supported by the botan package,
and the Blackfin architecture is not in this whitelist. Therefore, the
botan package will no longer be selectable in Blackfin configurations.

Thanks for looking into this and checking if the patch covered the
Blackfin case as well!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-09  7:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-08 19:52 [Buildroot] [git commit] botan: limit to supported CPU architectures Peter Korsgaard
2014-10-09  4:56 ` yuvaraj.patil at wipro.com
2014-10-09  7:40   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox