From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kmod: add host-automake dependency
Date: Fri, 10 Oct 2014 11:06:34 +0200 [thread overview]
Message-ID: <20141010110634.2ef7a7a5@free-electrons.com> (raw)
In-Reply-To: <1412930455-40512-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Fri, 10 Oct 2014 09:40:55 +0100, Vicente Olivert Riera wrote:
> kmod can fail to build in systems which have old automake versions like
> CentOS 6.5, for instance. It will cause an error like this one:
>
> /buildroot/output/build/kmod-18/build-aux/missing: line 81:
> aclocal-1.14: command not found
>
> Adding host-automake as a dependency fixes the problem.
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> ---
> package/kmod/kmod.mk | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
> index 1f170dd..c0212bb 100644
> --- a/package/kmod/kmod.mk
> +++ b/package/kmod/kmod.mk
> @@ -8,8 +8,8 @@ KMOD_VERSION = 18
> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz
> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod
> KMOD_INSTALL_STAGING = YES
> -KMOD_DEPENDENCIES = host-pkgconf
> -HOST_KMOD_DEPENDENCIES = host-pkgconf
> +KMOD_DEPENDENCIES = host-automake host-pkgconf
> +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf
>
> # license info for libkmod only, conditionally add more below
> KMOD_LICENSE = LGPLv2.1+
This seems wrong. Why not use KMOD_AUTORECONF = YES instead?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-10 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:40 [Buildroot] [PATCH] kmod: add host-automake dependency Vicente Olivert Riera
2014-10-10 9:06 ` Thomas Petazzoni [this message]
2014-10-10 9:15 ` Vicente Olivert Riera
2014-10-10 9:37 ` Vicente Olivert Riera
2014-10-10 9:42 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141010110634.2ef7a7a5@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox