From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kmod: add host-automake dependency
Date: Fri, 10 Oct 2014 10:15:12 +0100 [thread overview]
Message-ID: <5437A3A0.2040600@imgtec.com> (raw)
In-Reply-To: <20141010110634.2ef7a7a5@free-electrons.com>
Dear Thomas Petazzoni,
On 10/10/2014 10:06 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Fri, 10 Oct 2014 09:40:55 +0100, Vicente Olivert Riera wrote:
>> kmod can fail to build in systems which have old automake versions like
>> CentOS 6.5, for instance. It will cause an error like this one:
>>
>> /buildroot/output/build/kmod-18/build-aux/missing: line 81:
>> aclocal-1.14: command not found
>>
>> Adding host-automake as a dependency fixes the problem.
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
>> ---
>> package/kmod/kmod.mk | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/kmod/kmod.mk b/package/kmod/kmod.mk
>> index 1f170dd..c0212bb 100644
>> --- a/package/kmod/kmod.mk
>> +++ b/package/kmod/kmod.mk
>> @@ -8,8 +8,8 @@ KMOD_VERSION = 18
>> KMOD_SOURCE = kmod-$(KMOD_VERSION).tar.xz
>> KMOD_SITE = $(BR2_KERNEL_MIRROR)/linux/utils/kernel/kmod
>> KMOD_INSTALL_STAGING = YES
>> -KMOD_DEPENDENCIES = host-pkgconf
>> -HOST_KMOD_DEPENDENCIES = host-pkgconf
>> +KMOD_DEPENDENCIES = host-automake host-pkgconf
>> +HOST_KMOD_DEPENDENCIES = host-automake host-pkgconf
>>
>> # license info for libkmod only, conditionally add more below
>> KMOD_LICENSE = LGPLv2.1+
>
> This seems wrong. Why not use KMOD_AUTORECONF = YES instead?
I have tried it and it fails:
>>> kmod 18 Autoreconfiguring
libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, `build-aux'.
libtoolize: copying file `build-aux/ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
libkmod/docs/gtk-doc.make:270: error: HAVE_GTK_DOC does not appear in
AM_CONDITIONAL
libkmod/docs/Makefile.am:33: 'libkmod/docs/gtk-doc.make' included from
here
And also, if the kmod-0002-add-backup-implementation-of-be32toh.patch
modifies the configure.ac file, and there is no KMOD_AUTORECONF = YES in
the kmod.mk file, why don't we clean that patch by removing the
configure.ac bit?
Regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
next prev parent reply other threads:[~2014-10-10 9:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 8:40 [Buildroot] [PATCH] kmod: add host-automake dependency Vicente Olivert Riera
2014-10-10 9:06 ` Thomas Petazzoni
2014-10-10 9:15 ` Vicente Olivert Riera [this message]
2014-10-10 9:37 ` Vicente Olivert Riera
2014-10-10 9:42 ` Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437A3A0.2040600@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox