* [Buildroot] [PATCH v2 1/1] Add new package: biosdevname
@ 2014-02-03 21:37 Ryan Wilkins
2014-03-03 23:09 ` Yann E. MORIN
2014-10-12 8:35 ` Yann E. MORIN
0 siblings, 2 replies; 3+ messages in thread
From: Ryan Wilkins @ 2014-02-03 21:37 UTC (permalink / raw)
To: buildroot
Signed-off-by: Ryan Wilkins <ryan@deadfrog.net>
---
v2: incorporated comments from Arnout
---
package/Config.in | 1 +
package/biosdevname/Config.in | 13 +++++++++++++
package/biosdevname/biosdevname.mk | 15 +++++++++++++++
3 files changed, 29 insertions(+)
create mode 100644 package/biosdevname/Config.in
create mode 100644 package/biosdevname/biosdevname.mk
diff --git a/package/Config.in b/package/Config.in
index 93d23cb..d2aeab8 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -265,6 +265,7 @@ endmenu
source "package/a10disp/Config.in"
source "package/acpid/Config.in"
source "package/avrdude/Config.in"
+source "package/biosdevname/Config.in"
source "package/cdrkit/Config.in"
source "package/cryptsetup/Config.in"
source "package/cwiid/Config.in"
diff --git a/package/biosdevname/Config.in b/package/biosdevname/Config.in
new file mode 100644
index 0000000..17a9aa4
--- /dev/null
+++ b/package/biosdevname/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_BIOSDEVNAME
+ bool "biosdevname"
+ depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV
+ select BR2_PACKAGE_PCIUTILS
+ help
+ Biosdevname is a udev helper that looks at various BIOS tables to
+ figure out what the actual hardware names are for Ethernet ports
+ and renames the ports accordingly. This has the advantage of
+ always referring to the same port regardless of system or
+ hardware changes that might otherwise alter the typical ethX
+ naming.
+
+ http://linux.dell.com/biosdevname/
diff --git a/package/biosdevname/biosdevname.mk b/package/biosdevname/biosdevname.mk
new file mode 100644
index 0000000..be1c6af
--- /dev/null
+++ b/package/biosdevname/biosdevname.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# biosdevname
+#
+################################################################################
+
+BIOSDEVNAME_VERSION = 0.4.1
+BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)
+BIOSDEVNAME_LICENSE = GPL
+BIOSDEVNAME_LICENSE_FILES = COPYING
+BIOSDEVNAME_INSTALL_TARGET = YES
+BIOSDEVNAME_CONF_OPT = --exec-prefix=/
+BIOSDEVNAME_DEPENDENCIES = pciutils
+
+$(eval $(autotools-package))
--
1.7.9.5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140203/62744f58/attachment.html>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2 1/1] Add new package: biosdevname
2014-02-03 21:37 [Buildroot] [PATCH v2 1/1] Add new package: biosdevname Ryan Wilkins
@ 2014-03-03 23:09 ` Yann E. MORIN
2014-10-12 8:35 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-03-03 23:09 UTC (permalink / raw)
To: buildroot
Ryan, All,
Thank you for your submission. Here are a few other comments.
On 2014-02-03 16:37 -0500, Ryan Wilkins spake thusly:
[--SNIP--]
> diff --git a/package/biosdevname/Config.in b/package/biosdevname/Config.in
> new file mode 100644
> index 0000000..17a9aa4
> --- /dev/null
> +++ b/package/biosdevname/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_BIOSDEVNAME
> + bool "biosdevname"
> + depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV
Two things:
- we usually separate the dependencies on architectures from the
dependencies on packages
- udev is now provided by a virtual package
So, you should do:
depends on BR2_i386 || BR2_x86_64
dependson BR2_PACKAGE_HAS_UDEV
> + select BR2_PACKAGE_PCIUTILS
> + help
> + Biosdevname is a udev helper that looks at various BIOS tables to
> + figure out what the actual hardware names are for Ethernet ports
> + and renames the ports accordingly. This has the advantage of
> + always referring to the same port regardless of system or
> + hardware changes that might otherwise alter the typical ethX
> + naming.
> +
> + http://linux.dell.com/biosdevname/
> diff --git a/package/biosdevname/biosdevname.mk b/package/biosdevname/biosdevname.mk
> new file mode 100644
> index 0000000..be1c6af
> --- /dev/null
> +++ b/package/biosdevname/biosdevname.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# biosdevname
> +#
> +################################################################################
> +
> +BIOSDEVNAME_VERSION = 0.4.1
> +BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)
The git repository has version v0.5.0, out 2013-01-18.
THere are also a few fixes in the repository, that were made a few hours
ago, so it might be a better bet to use a git snapshot:
BIOSDEVNAME_VERSION = c140ce659a204d67e4cc61d2191443123f7dd970
BIOSDEVNAME_SITE = git://linux.dell.com/biosdevname.git
> +BIOSDEVNAME_LICENSE = GPL
> +BIOSDEVNAME_LICENSE_FILES = COPYING
> +BIOSDEVNAME_INSTALL_TARGET = YES
Not needed, that's the default.
> +BIOSDEVNAME_CONF_OPT = --exec-prefix=/
> +BIOSDEVNAME_DEPENDENCIES = pciutils
Missing dependency on udev:
BIOSDEVNAME_DEPENDENCIES = pciutils udev
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH v2 1/1] Add new package: biosdevname
2014-02-03 21:37 [Buildroot] [PATCH v2 1/1] Add new package: biosdevname Ryan Wilkins
2014-03-03 23:09 ` Yann E. MORIN
@ 2014-10-12 8:35 ` Yann E. MORIN
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-10-12 8:35 UTC (permalink / raw)
To: buildroot
Ryan, All,
On 2014-02-03 16:37 -0500, Ryan Wilkins spake thusly:
> Signed-off-by: Ryan Wilkins <ryan@deadfrog.net>
> ---
> v2: incorporated comments from Arnout
I've sent an updated version of that patch:
http://patchwork.ozlabs.org/patch/398911/
Regards,
Yann E. MORIN.
> ---
> package/Config.in | 1 +
> package/biosdevname/Config.in | 13 +++++++++++++
> package/biosdevname/biosdevname.mk | 15 +++++++++++++++
> 3 files changed, 29 insertions(+)
> create mode 100644 package/biosdevname/Config.in
> create mode 100644 package/biosdevname/biosdevname.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 93d23cb..d2aeab8 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -265,6 +265,7 @@ endmenu
> source "package/a10disp/Config.in"
> source "package/acpid/Config.in"
> source "package/avrdude/Config.in"
> +source "package/biosdevname/Config.in"
> source "package/cdrkit/Config.in"
> source "package/cryptsetup/Config.in"
> source "package/cwiid/Config.in"
> diff --git a/package/biosdevname/Config.in b/package/biosdevname/Config.in
> new file mode 100644
> index 0000000..17a9aa4
> --- /dev/null
> +++ b/package/biosdevname/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_BIOSDEVNAME
> + bool "biosdevname"
> + depends on (BR2_i386 || BR2_x86_64) && BR2_PACKAGE_UDEV
> + select BR2_PACKAGE_PCIUTILS
> + help
> + Biosdevname is a udev helper that looks at various BIOS tables to
> + figure out what the actual hardware names are for Ethernet ports
> + and renames the ports accordingly. This has the advantage of
> + always referring to the same port regardless of system or
> + hardware changes that might otherwise alter the typical ethX
> + naming.
> +
> + http://linux.dell.com/biosdevname/
> diff --git a/package/biosdevname/biosdevname.mk b/package/biosdevname/biosdevname.mk
> new file mode 100644
> index 0000000..be1c6af
> --- /dev/null
> +++ b/package/biosdevname/biosdevname.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# biosdevname
> +#
> +################################################################################
> +
> +BIOSDEVNAME_VERSION = 0.4.1
> +BIOSDEVNAME_SITE = http://linux.dell.com/biosdevname/biosdevname-$(BIOSDEVNAME_VERSION)
> +BIOSDEVNAME_LICENSE = GPL
> +BIOSDEVNAME_LICENSE_FILES = COPYING
> +BIOSDEVNAME_INSTALL_TARGET = YES
> +BIOSDEVNAME_CONF_OPT = --exec-prefix=/
> +BIOSDEVNAME_DEPENDENCIES = pciutils
> +
> +$(eval $(autotools-package))
> --
> 1.7.9.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-12 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-03 21:37 [Buildroot] [PATCH v2 1/1] Add new package: biosdevname Ryan Wilkins
2014-03-03 23:09 ` Yann E. MORIN
2014-10-12 8:35 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox