Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] mongrel2: Add comments to avoid use of github call
@ 2014-10-12 17:46 Maxime Hadjinlian
  2014-10-12 19:36 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Maxime Hadjinlian @ 2014-10-12 17:46 UTC (permalink / raw)
  To: buildroot

As the comment says, we don't want to uses the github helper, as we
would end up with a generated tarball, which is not the same one as the
one linked with the releases.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/mongrel2/mongrel2.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/mongrel2/mongrel2.mk b/package/mongrel2/mongrel2.mk
index 14e3a80..aa2e8fc 100644
--- a/package/mongrel2/mongrel2.mk
+++ b/package/mongrel2/mongrel2.mk
@@ -5,6 +5,8 @@
 ################################################################################
 
 MONGREL2_VERSION = v1.9.1
+# Do not uses the github helper here, the generated tarball is *NOT* the same
+# as the one uploaded by upstream for the release.
 MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
 MONGREL2_LICENSE = BSD-3c
 MONGREL2_LICENSE_FILES = LICENSE
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] mongrel2: Add comments to avoid use of github call
  2014-10-12 17:46 [Buildroot] [PATCH v2] mongrel2: Add comments to avoid use of github call Maxime Hadjinlian
@ 2014-10-12 19:36 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2014-10-12 19:36 UTC (permalink / raw)
  To: buildroot

Dear Maxime Hadjinlian,

On Sun, 12 Oct 2014 19:46:14 +0200, Maxime Hadjinlian wrote:

>  MONGREL2_VERSION = v1.9.1
> +# Do not uses the github helper here, the generated tarball is *NOT* the same

s/uses/use/

> +# as the one uploaded by upstream for the release.
>  MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
>  MONGREL2_LICENSE = BSD-3c
>  MONGREL2_LICENSE_FILES = LICENSE


Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-12 19:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-12 17:46 [Buildroot] [PATCH v2] mongrel2: Add comments to avoid use of github call Maxime Hadjinlian
2014-10-12 19:36 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox