Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
@ 2014-10-13  7:55 Jérôme Pouiller
  2014-10-13  7:55 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading Jérôme Pouiller
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-13  7:55 UTC (permalink / raw)
  To: buildroot

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 system/skeleton/etc/ld.so.conf | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 system/skeleton/etc/ld.so.conf

diff --git a/system/skeleton/etc/ld.so.conf b/system/skeleton/etc/ld.so.conf
new file mode 100644
index 0000000..83327c0
--- /dev/null
+++ b/system/skeleton/etc/ld.so.conf
@@ -0,0 +1 @@
+include /etc/ld.so.conf.d/*.conf
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading
  2014-10-13  7:55 [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Jérôme Pouiller
@ 2014-10-13  7:55 ` Jérôme Pouiller
  2014-10-14  8:40   ` Yann E. MORIN
  2014-10-14  8:03 ` [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Yann E. MORIN
  2014-10-24 23:53 ` Yann E. MORIN
  2 siblings, 1 reply; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-13  7:55 UTC (permalink / raw)
  To: buildroot

Problem was reported :
  http://lists.busybox.net/pipermail/buildroot/2014-July/101566.html
  http://lists.busybox.net/pipermail/buildroot/2014-October/107613.html

Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
---
 package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk             | 9 +++++++++
 .../gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf  | 5 +++++
 2 files changed, 14 insertions(+)
 create mode 100644 package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf

diff --git a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
index 8d8b8b4..21046fc 100644
--- a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
+++ b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
@@ -40,4 +40,13 @@ endef
 
 GST_FSL_PLUGINS_POST_PATCH_HOOKS += GST_FSL_PLUGINS_PATCH_M4
 
+define GST_FSL_PLUGINS_FIX_LD_PATH
+	$(INSTALL) -d $(TARGET_DIR)/etc/ld.so.conf.d
+	$(INSTALL) -m 644 \
+		package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf \
+		$(TARGET_DIR)/etc/ld.so.conf.d
+endef
+
+GST_FSL_PLUGINS_POST_INSTALL_TARGET_HOOKS += GST_FSL_PLUGINS_FIX_LD_PATH
+
 $(eval $(autotools-package))
diff --git a/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf b/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf
new file mode 100644
index 0000000..325fbf1
--- /dev/null
+++ b/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf
@@ -0,0 +1,5 @@
+# cf. https://community.freescale.com/thread/300387
+/usr/lib/imx-mm/audio-codec
+/usr/lib/imx-mm/video-codec
+/usr/lib/imx-mm/parser
+
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-13  7:55 [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Jérôme Pouiller
  2014-10-13  7:55 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading Jérôme Pouiller
@ 2014-10-14  8:03 ` Yann E. MORIN
  2014-10-14  8:24   ` Jérôme Pouiller
  2014-10-24 23:53 ` Yann E. MORIN
  2 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2014-10-14  8:03 UTC (permalink / raw)
  To: buildroot

J?r?me, All,

On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  system/skeleton/etc/ld.so.conf | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 system/skeleton/etc/ld.so.conf
> 
> diff --git a/system/skeleton/etc/ld.so.conf b/system/skeleton/etc/ld.so.conf
> new file mode 100644
> index 0000000..83327c0
> --- /dev/null
> +++ b/system/skeleton/etc/ld.so.conf
> @@ -0,0 +1 @@
> +include /etc/ld.so.conf.d/*.conf

Are you sure this works with uClibc? Looking at the code of ldconfig
from uClibc seems to imply it does not support including files.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:03 ` [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Yann E. MORIN
@ 2014-10-14  8:24   ` Jérôme Pouiller
  2014-10-14  8:33     ` Samuel Martin
  2014-10-14  8:37     ` Yann E. MORIN
  0 siblings, 2 replies; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-14  8:24 UTC (permalink / raw)
  To: buildroot

On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
> J?r?me, All,
> 
> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> > ---
> > 
> >  system/skeleton/etc/ld.so.conf | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 100644 system/skeleton/etc/ld.so.conf
> > 
> > diff --git a/system/skeleton/etc/ld.so.conf
> > b/system/skeleton/etc/ld.so.conf new file mode 100644
> > index 0000000..83327c0
> > --- /dev/null
> > +++ b/system/skeleton/etc/ld.so.conf
> > @@ -0,0 +1 @@
> > +include /etc/ld.so.conf.d/*.conf
> 
> Are you sure this works with uClibc? Looking at the code of ldconfig
> from uClibc seems to imply it does not support including files.
I admit I have not tested with uclibc. 

hmm... Suddenly, it is more complex to implement. I see two options:
  * Provide /etc/ld.so.conf during toolchain build depending of libc.
  * Add extra library paths directly in /etc/ld.so.conf instead of adding a 
file in /etc/ld.so.conf.d. However, modifying files during install step is 
error prone.

Any preference?


-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:24   ` Jérôme Pouiller
@ 2014-10-14  8:33     ` Samuel Martin
  2014-10-14  8:40       ` Jérôme Pouiller
  2014-10-14  8:37     ` Yann E. MORIN
  1 sibling, 1 reply; 13+ messages in thread
From: Samuel Martin @ 2014-10-14  8:33 UTC (permalink / raw)
  To: buildroot

On Tue, Oct 14, 2014 at 10:24 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
> On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
>> J?r?me, All,
>>
>> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
>> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
>> > ---
>> >
>> >  system/skeleton/etc/ld.so.conf | 1 +
>> >  1 file changed, 1 insertion(+)
>> >  create mode 100644 system/skeleton/etc/ld.so.conf
>> >
>> > diff --git a/system/skeleton/etc/ld.so.conf
>> > b/system/skeleton/etc/ld.so.conf new file mode 100644
>> > index 0000000..83327c0
>> > --- /dev/null
>> > +++ b/system/skeleton/etc/ld.so.conf
>> > @@ -0,0 +1 @@
>> > +include /etc/ld.so.conf.d/*.conf
>>
>> Are you sure this works with uClibc? Looking at the code of ldconfig
>> from uClibc seems to imply it does not support including files.
> I admit I have not tested with uclibc.
>
> hmm... Suddenly, it is more complex to implement. I see two options:
>   * Provide /etc/ld.so.conf during toolchain build depending of libc.
>   * Add extra library paths directly in /etc/ld.so.conf instead of adding a
> file in /etc/ld.so.conf.d. However, modifying files during install step is
> error prone.
>

or add a post-build hook for uclibc, which does:
cat <target>/etc/ld.conf.d/* >> <target>/etc/ld.conf

> Any preference?
>
>
> --
> J?r?me Pouiller, Sysmic
> Embedded Linux specialist
> http://www.sysmic.fr
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



-- 
Samuel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:24   ` Jérôme Pouiller
  2014-10-14  8:33     ` Samuel Martin
@ 2014-10-14  8:37     ` Yann E. MORIN
  1 sibling, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2014-10-14  8:37 UTC (permalink / raw)
  To: buildroot

J?r?me, Maxime, All,

On 2014-10-14 10:24 +0200, J?r?me Pouiller spake thusly:
> On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
> > J?r?me, All,
> > 
> > On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> > > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> > > ---
> > > 
> > >  system/skeleton/etc/ld.so.conf | 1 +
> > >  1 file changed, 1 insertion(+)
> > >  create mode 100644 system/skeleton/etc/ld.so.conf
> > > 
> > > diff --git a/system/skeleton/etc/ld.so.conf
> > > b/system/skeleton/etc/ld.so.conf new file mode 100644
> > > index 0000000..83327c0
> > > --- /dev/null
> > > +++ b/system/skeleton/etc/ld.so.conf
> > > @@ -0,0 +1 @@
> > > +include /etc/ld.so.conf.d/*.conf
> > 
> > Are you sure this works with uClibc? Looking at the code of ldconfig
> > from uClibc seems to imply it does not support including files.
> I admit I have not tested with uclibc. 
> 
> hmm... Suddenly, it is more complex to implement. I see two options:
>   * Provide /etc/ld.so.conf during toolchain build depending of libc.
>   * Add extra library paths directly in /etc/ld.so.conf instead of adding a 
> file in /etc/ld.so.conf.d. However, modifying files during install step is 
> error prone.
> 
> Any preference?

Adding MAxime in the loop, since he's working on making the skeleton a
generic package.

Probably, at install time of the skeleton package, we could shoe-horn
this depending on whether this is glibc, uClibc or musl.

Maxime, thoughts?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading
  2014-10-13  7:55 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading Jérôme Pouiller
@ 2014-10-14  8:40   ` Yann E. MORIN
  0 siblings, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2014-10-14  8:40 UTC (permalink / raw)
  To: buildroot

J?r?me, All,

On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> Problem was reported :
>   http://lists.busybox.net/pipermail/buildroot/2014-July/101566.html
>   http://lists.busybox.net/pipermail/buildroot/2014-October/107613.html
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk             | 9 +++++++++
>  .../gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf  | 5 +++++
>  2 files changed, 14 insertions(+)
>  create mode 100644 package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf
> 
> diff --git a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> index 8d8b8b4..21046fc 100644
> --- a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> +++ b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
> @@ -40,4 +40,13 @@ endef
>  
>  GST_FSL_PLUGINS_POST_PATCH_HOOKS += GST_FSL_PLUGINS_PATCH_M4
>  
> +define GST_FSL_PLUGINS_FIX_LD_PATH
> +	$(INSTALL) -d $(TARGET_DIR)/etc/ld.so.conf.d
> +	$(INSTALL) -m 644 \
> +		package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf \
> +		$(TARGET_DIR)/etc/ld.so.conf.d

I'd prefer you do it in one command:

    $(INSTALL) -D -m 0644 \
        package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf \
        $(TARGET_DIR)/etc/ld.so.conf.d/gst-fsl-plugins.conf

That way, the directory is created in case it is missing.
Also, the name of the install file is shorter and more meaningful.

Regards,
Yann E. MORIN.

> +endef
> +
> +GST_FSL_PLUGINS_POST_INSTALL_TARGET_HOOKS += GST_FSL_PLUGINS_FIX_LD_PATH
> +
>  $(eval $(autotools-package))
> diff --git a/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf b/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf
> new file mode 100644
> index 0000000..325fbf1
> --- /dev/null
> +++ b/package/gstreamer/gst-fsl-plugins/ld.so.conf.d-gst-fsl-plugins.conf
> @@ -0,0 +1,5 @@
> +# cf. https://community.freescale.com/thread/300387
> +/usr/lib/imx-mm/audio-codec
> +/usr/lib/imx-mm/video-codec
> +/usr/lib/imx-mm/parser
> +
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:33     ` Samuel Martin
@ 2014-10-14  8:40       ` Jérôme Pouiller
  2014-10-14  8:44         ` Samuel Martin
  0 siblings, 1 reply; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-14  8:40 UTC (permalink / raw)
  To: buildroot

On Tuesday 14 October 2014 10:33:16 Samuel Martin wrote:
> On Tue, Oct 14, 2014 at 10:24 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
> > On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
> >> J?r?me, All,
> >> 
> >> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> >> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> >> > ---
> >> > 
> >> >  system/skeleton/etc/ld.so.conf | 1 +
> >> >  1 file changed, 1 insertion(+)
> >> >  create mode 100644 system/skeleton/etc/ld.so.conf
> >> > 
> >> > diff --git a/system/skeleton/etc/ld.so.conf
> >> > b/system/skeleton/etc/ld.so.conf new file mode 100644
> >> > index 0000000..83327c0
> >> > --- /dev/null
> >> > +++ b/system/skeleton/etc/ld.so.conf
> >> > @@ -0,0 +1 @@
> >> > +include /etc/ld.so.conf.d/*.conf
> >> 
> >> Are you sure this works with uClibc? Looking at the code of ldconfig
> >> from uClibc seems to imply it does not support including files.
> > 
> > I admit I have not tested with uclibc.
> > 
> > hmm... Suddenly, it is more complex to implement. I see two options:
> >   * Provide /etc/ld.so.conf during toolchain build depending of libc.
> >   * Add extra library paths directly in /etc/ld.so.conf instead of adding
> >   a
> > 
> > file in /etc/ld.so.conf.d. However, modifying files during install step is
> > error prone.
> 
> or add a post-build hook for uclibc, which does:
> cat <target>/etc/ld.conf.d/* >> <target>/etc/ld.conf
This will not been executed if an external toolchain is used.


-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:40       ` Jérôme Pouiller
@ 2014-10-14  8:44         ` Samuel Martin
  2014-10-14  8:52           ` Jérôme Pouiller
  0 siblings, 1 reply; 13+ messages in thread
From: Samuel Martin @ 2014-10-14  8:44 UTC (permalink / raw)
  To: buildroot

On Tue, Oct 14, 2014 at 10:40 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
> On Tuesday 14 October 2014 10:33:16 Samuel Martin wrote:
>> On Tue, Oct 14, 2014 at 10:24 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
>> > On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
>> >> J?r?me, All,
>> >>
>> >> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
>> >> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
>> >> > ---
>> >> >
>> >> >  system/skeleton/etc/ld.so.conf | 1 +
>> >> >  1 file changed, 1 insertion(+)
>> >> >  create mode 100644 system/skeleton/etc/ld.so.conf
>> >> >
>> >> > diff --git a/system/skeleton/etc/ld.so.conf
>> >> > b/system/skeleton/etc/ld.so.conf new file mode 100644
>> >> > index 0000000..83327c0
>> >> > --- /dev/null
>> >> > +++ b/system/skeleton/etc/ld.so.conf
>> >> > @@ -0,0 +1 @@
>> >> > +include /etc/ld.so.conf.d/*.conf
>> >>
>> >> Are you sure this works with uClibc? Looking at the code of ldconfig
>> >> from uClibc seems to imply it does not support including files.
>> >
>> > I admit I have not tested with uclibc.
>> >
>> > hmm... Suddenly, it is more complex to implement. I see two options:
>> >   * Provide /etc/ld.so.conf during toolchain build depending of libc.
>> >   * Add extra library paths directly in /etc/ld.so.conf instead of adding
>> >   a
>> >
>> > file in /etc/ld.so.conf.d. However, modifying files during install step is
>> > error prone.
>>
>> or add a post-build hook for uclibc, which does:
>> cat <target>/etc/ld.conf.d/* >> <target>/etc/ld.conf
> This will not been executed if an external toolchain is used.

Why not?
In case of external toolchain, we have to select what libc is used in
the toolchain; so it should be ok.

>
>
> --
> J?r?me Pouiller, Sysmic
> Embedded Linux specialist
> http://www.sysmic.fr



-- 
Samuel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:44         ` Samuel Martin
@ 2014-10-14  8:52           ` Jérôme Pouiller
  2014-10-14  9:00             ` Samuel Martin
  0 siblings, 1 reply; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-14  8:52 UTC (permalink / raw)
  To: buildroot

On Tuesday 14 October 2014 10:44:48 Samuel Martin wrote:
> On Tue, Oct 14, 2014 at 10:40 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
> > On Tuesday 14 October 2014 10:33:16 Samuel Martin wrote:
> >> On Tue, Oct 14, 2014 at 10:24 AM, J?r?me Pouiller <jezz@sysmic.org> 
wrote:
> >> > On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
> >> >> J?r?me, All,
> >> >> 
> >> >> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> >> >> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> >> >> > ---
> >> >> > 
> >> >> >  system/skeleton/etc/ld.so.conf | 1 +
> >> >> >  1 file changed, 1 insertion(+)
> >> >> >  create mode 100644 system/skeleton/etc/ld.so.conf
> >> >> > 
> >> >> > diff --git a/system/skeleton/etc/ld.so.conf
> >> >> > b/system/skeleton/etc/ld.so.conf new file mode 100644
> >> >> > index 0000000..83327c0
> >> >> > --- /dev/null
> >> >> > +++ b/system/skeleton/etc/ld.so.conf
> >> >> > @@ -0,0 +1 @@
> >> >> > +include /etc/ld.so.conf.d/*.conf
> >> >> 
> >> >> Are you sure this works with uClibc? Looking at the code of ldconfig
> >> >> from uClibc seems to imply it does not support including files.
> >> > 
> >> > I admit I have not tested with uclibc.
> >> > 
> >> > hmm... Suddenly, it is more complex to implement. I see two options:
> >> >   * Provide /etc/ld.so.conf during toolchain build depending of libc.
> >> >   * Add extra library paths directly in /etc/ld.so.conf instead of
> >> >   adding
> >> >   a
> >> > 
> >> > file in /etc/ld.so.conf.d. However, modifying files during install step
> >> > is
> >> > error prone.
> >> 
> >> or add a post-build hook for uclibc, which does:
> >> cat <target>/etc/ld.conf.d/* >> <target>/etc/ld.conf
> > 
> > This will not been executed if an external toolchain is used.
> 
> Why not?
> In case of external toolchain, we have to select what libc is used in
> the toolchain; so it should be ok.
Ok. I understood a "package post build hook", but you mean a "target finalize 
hook".


-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-14  8:52           ` Jérôme Pouiller
@ 2014-10-14  9:00             ` Samuel Martin
  0 siblings, 0 replies; 13+ messages in thread
From: Samuel Martin @ 2014-10-14  9:00 UTC (permalink / raw)
  To: buildroot

On Tue, Oct 14, 2014 at 10:52 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
> On Tuesday 14 October 2014 10:44:48 Samuel Martin wrote:
>> On Tue, Oct 14, 2014 at 10:40 AM, J?r?me Pouiller <jezz@sysmic.org> wrote:
>> > On Tuesday 14 October 2014 10:33:16 Samuel Martin wrote:
>> >> On Tue, Oct 14, 2014 at 10:24 AM, J?r?me Pouiller <jezz@sysmic.org>
> wrote:
>> >> > On Tuesday 14 October 2014 10:03:41 Yann E. MORIN wrote:
>> >> >> J?r?me, All,
>> >> >>
>> >> >> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
>> >> >> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
>> >> >> > ---
>> >> >> >
>> >> >> >  system/skeleton/etc/ld.so.conf | 1 +
>> >> >> >  1 file changed, 1 insertion(+)
>> >> >> >  create mode 100644 system/skeleton/etc/ld.so.conf
>> >> >> >
>> >> >> > diff --git a/system/skeleton/etc/ld.so.conf
>> >> >> > b/system/skeleton/etc/ld.so.conf new file mode 100644
>> >> >> > index 0000000..83327c0
>> >> >> > --- /dev/null
>> >> >> > +++ b/system/skeleton/etc/ld.so.conf
>> >> >> > @@ -0,0 +1 @@
>> >> >> > +include /etc/ld.so.conf.d/*.conf
>> >> >>
>> >> >> Are you sure this works with uClibc? Looking at the code of ldconfig
>> >> >> from uClibc seems to imply it does not support including files.
>> >> >
>> >> > I admit I have not tested with uclibc.
>> >> >
>> >> > hmm... Suddenly, it is more complex to implement. I see two options:
>> >> >   * Provide /etc/ld.so.conf during toolchain build depending of libc.
>> >> >   * Add extra library paths directly in /etc/ld.so.conf instead of
>> >> >   adding
>> >> >   a
>> >> >
>> >> > file in /etc/ld.so.conf.d. However, modifying files during install step
>> >> > is
>> >> > error prone.
>> >>
>> >> or add a post-build hook for uclibc, which does:
>> >> cat <target>/etc/ld.conf.d/* >> <target>/etc/ld.conf
>> >
>> > This will not been executed if an external toolchain is used.
>>
>> Why not?
>> In case of external toolchain, we have to select what libc is used in
>> the toolchain; so it should be ok.
> Ok. I understood a "package post build hook", but you mean a "target finalize
> hook".

Yes exactly.
Sorry for the confusion.

>
>
> --
> J?r?me Pouiller, Sysmic
> Embedded Linux specialist
> http://www.sysmic.fr



-- 
Samuel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-13  7:55 [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Jérôme Pouiller
  2014-10-13  7:55 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading Jérôme Pouiller
  2014-10-14  8:03 ` [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Yann E. MORIN
@ 2014-10-24 23:53 ` Yann E. MORIN
  2014-10-25 16:23   ` Jérôme Pouiller
  2 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2014-10-24 23:53 UTC (permalink / raw)
  To: buildroot

J?r?me, All,

On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

Given the feedback given in the thread, I've marked this patch "Changes
Requested" in patchwork.

Are you working on an updated patch?

Regards,
Yann E. MORIN.

> ---
>  system/skeleton/etc/ld.so.conf | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 system/skeleton/etc/ld.so.conf
> 
> diff --git a/system/skeleton/etc/ld.so.conf b/system/skeleton/etc/ld.so.conf
> new file mode 100644
> index 0000000..83327c0
> --- /dev/null
> +++ b/system/skeleton/etc/ld.so.conf
> @@ -0,0 +1 @@
> +include /etc/ld.so.conf.d/*.conf
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf
  2014-10-24 23:53 ` Yann E. MORIN
@ 2014-10-25 16:23   ` Jérôme Pouiller
  0 siblings, 0 replies; 13+ messages in thread
From: Jérôme Pouiller @ 2014-10-25 16:23 UTC (permalink / raw)
  To: buildroot

On Friday 24 October 2014 16:53:23 Yann E. MORIN wrote:
> J?r?me, All,
> 
> On 2014-10-13 09:55 +0200, J?r?me Pouiller spake thusly:
> > Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> 
> Given the feedback given in the thread, I've marked this patch "Changes
> Requested" in patchwork.
> 
> Are you working on an updated patch?
I will do next week I think.

-- 
J?r?me Pouiller, Sysmic
Embedded Linux specialist
http://www.sysmic.fr

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2014-10-25 16:23 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-13  7:55 [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Jérôme Pouiller
2014-10-13  7:55 ` [Buildroot] [PATCH 2/2] gst-fsl-plugins: fix plugin loading Jérôme Pouiller
2014-10-14  8:40   ` Yann E. MORIN
2014-10-14  8:03 ` [Buildroot] [PATCH 1/2] skeleton: ld.so.conf include ld.so.conf.d/*.conf Yann E. MORIN
2014-10-14  8:24   ` Jérôme Pouiller
2014-10-14  8:33     ` Samuel Martin
2014-10-14  8:40       ` Jérôme Pouiller
2014-10-14  8:44         ` Samuel Martin
2014-10-14  8:52           ` Jérôme Pouiller
2014-10-14  9:00             ` Samuel Martin
2014-10-14  8:37     ` Yann E. MORIN
2014-10-24 23:53 ` Yann E. MORIN
2014-10-25 16:23   ` Jérôme Pouiller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox