* [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2
2014-10-15 21:23 [Buildroot] [PATCH 1/4] libshout: new package Jörg Krause
@ 2014-10-15 21:23 ` Jörg Krause
2014-10-16 8:42 ` Thomas Petazzoni
2014-10-17 14:24 ` Peter Korsgaard
2014-10-15 21:23 ` [Buildroot] [PATCH 3/4] package/libogg: add hash file Jörg Krause
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Jörg Krause @ 2014-10-15 21:23 UTC (permalink / raw)
To: buildroot
Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
package/libogg/libogg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libogg/libogg.mk b/package/libogg/libogg.mk
index 984e7b7..8fff529 100644
--- a/package/libogg/libogg.mk
+++ b/package/libogg/libogg.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LIBOGG_VERSION = 1.3.1
+LIBOGG_VERSION = 1.3.2
LIBOGG_SOURCE = libogg-$(LIBOGG_VERSION).tar.xz
LIBOGG_SITE = http://downloads.xiph.org/releases/ogg
LIBOGG_LICENSE = BSD-3c
--
2.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2
2014-10-15 21:23 ` [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2 Jörg Krause
@ 2014-10-16 8:42 ` Thomas Petazzoni
2014-10-17 14:24 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-16 8:42 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Wed, 15 Oct 2014 23:23:49 +0200, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
> package/libogg/libogg.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2
2014-10-15 21:23 ` [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2 Jörg Krause
2014-10-16 8:42 ` Thomas Petazzoni
@ 2014-10-17 14:24 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2014-10-17 14:24 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/4] package/libogg: add hash file
2014-10-15 21:23 [Buildroot] [PATCH 1/4] libshout: new package Jörg Krause
2014-10-15 21:23 ` [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2 Jörg Krause
@ 2014-10-15 21:23 ` Jörg Krause
2014-10-16 8:43 ` Thomas Petazzoni
2014-10-17 14:25 ` Peter Korsgaard
2014-10-15 21:23 ` [Buildroot] [PATCH 4/4] package/libvorbis: " Jörg Krause
` (2 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Jörg Krause @ 2014-10-15 21:23 UTC (permalink / raw)
To: buildroot
Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
package/libogg/libogg.hash | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 package/libogg/libogg.hash
diff --git a/package/libogg/libogg.hash b/package/libogg/libogg.hash
new file mode 100644
index 0000000..393ebee
--- /dev/null
+++ b/package/libogg/libogg.hash
@@ -0,0 +1,2 @@
+# From: http://www.xiph.org/downloads/
+sha256 3f687ccdd5ac8b52d76328fbbfebc70c459a40ea891dbf3dccb74a210826e79b libogg-1.3.2.tar.xz
--
2.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 3/4] package/libogg: add hash file
2014-10-15 21:23 ` [Buildroot] [PATCH 3/4] package/libogg: add hash file Jörg Krause
@ 2014-10-16 8:43 ` Thomas Petazzoni
2014-10-17 14:25 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-16 8:43 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Wed, 15 Oct 2014 23:23:50 +0200, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
> package/libogg/libogg.hash | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 package/libogg/libogg.hash
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(verified the hash on the website, and asked Buildroot to
download/extract libogg to make sure the hash was validated properly)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 3/4] package/libogg: add hash file
2014-10-15 21:23 ` [Buildroot] [PATCH 3/4] package/libogg: add hash file Jörg Krause
2014-10-16 8:43 ` Thomas Petazzoni
@ 2014-10-17 14:25 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2014-10-17 14:25 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] package/libvorbis: add hash file
2014-10-15 21:23 [Buildroot] [PATCH 1/4] libshout: new package Jörg Krause
2014-10-15 21:23 ` [Buildroot] [PATCH 2/4] package/libogg: bump to version 1.3.2 Jörg Krause
2014-10-15 21:23 ` [Buildroot] [PATCH 3/4] package/libogg: add hash file Jörg Krause
@ 2014-10-15 21:23 ` Jörg Krause
2014-10-16 8:45 ` Thomas Petazzoni
2014-10-17 14:25 ` Peter Korsgaard
2014-10-16 8:41 ` [Buildroot] [PATCH 1/4] libshout: new package Thomas Petazzoni
2014-10-17 14:11 ` Peter Korsgaard
4 siblings, 2 replies; 12+ messages in thread
From: Jörg Krause @ 2014-10-15 21:23 UTC (permalink / raw)
To: buildroot
Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
package/libvorbis/libvorbis.hash | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 package/libvorbis/libvorbis.hash
diff --git a/package/libvorbis/libvorbis.hash b/package/libvorbis/libvorbis.hash
new file mode 100644
index 0000000..3b997ba
--- /dev/null
+++ b/package/libvorbis/libvorbis.hash
@@ -0,0 +1,2 @@
+# From http://www.xiph.org/downloads/
+sha256 2f05497d29195dc23ee952a24ee3973a74e6277569c4c2eca0ec5968e541f372 libvorbis-1.3.4.tar.xz
--
2.1.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] package/libvorbis: add hash file
2014-10-15 21:23 ` [Buildroot] [PATCH 4/4] package/libvorbis: " Jörg Krause
@ 2014-10-16 8:45 ` Thomas Petazzoni
2014-10-17 14:25 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-16 8:45 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Wed, 15 Oct 2014 23:23:51 +0200, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
> package/libvorbis/libvorbis.hash | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 package/libvorbis/libvorbis.hash
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(checked on web site, tested locally)
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 4/4] package/libvorbis: add hash file
2014-10-15 21:23 ` [Buildroot] [PATCH 4/4] package/libvorbis: " Jörg Krause
2014-10-16 8:45 ` Thomas Petazzoni
@ 2014-10-17 14:25 ` Peter Korsgaard
1 sibling, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2014-10-17 14:25 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Buildroot] [PATCH 1/4] libshout: new package
2014-10-15 21:23 [Buildroot] [PATCH 1/4] libshout: new package Jörg Krause
` (2 preceding siblings ...)
2014-10-15 21:23 ` [Buildroot] [PATCH 4/4] package/libvorbis: " Jörg Krause
@ 2014-10-16 8:41 ` Thomas Petazzoni
2014-10-17 14:11 ` Peter Korsgaard
4 siblings, 0 replies; 12+ messages in thread
From: Thomas Petazzoni @ 2014-10-16 8:41 UTC (permalink / raw)
To: buildroot
Dear J?rg Krause,
On Wed, 15 Oct 2014 23:23:48 +0200, J?rg Krause wrote:
> diff --git a/package/libshout/Config.in b/package/libshout/Config.in
> new file mode 100644
> index 0000000..36c8531
> --- /dev/null
> +++ b/package/libshout/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_LIBSHOUT
> + bool "libshout"
> + select BR2_PACKAGE_LIBOGG
> + select BR2_PACKAGE_LIBVORBIS
> + help
> + Libshout is a library for communicating with and sending data to an
> + icecast server. It handles the socket connection, the timing of the
> + data, and prevents bad data from getting to the icecast server.
> +
> + http://icecast.org/download/
Indentation is wrong: one tab for everything, except the help text that
should be indented with one tab + two spaces.
> diff --git a/package/libshout/libshout.mk b/package/libshout/libshout.mk
> new file mode 100644
> index 0000000..9d7f39c
> --- /dev/null
> +++ b/package/libshout/libshout.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# libshout
> +#
> +################################################################################
> +
> +LIBSHOUT_VERSION = 2.3.1
> +LIBSHOUT_SITE = http://downloads.xiph.org/releases/libshout
> +LIBSHOUT_LICENSE = LGPLv2
License is LGPLv2+.
Other than that, looks good, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 12+ messages in thread* [Buildroot] [PATCH 1/4] libshout: new package
2014-10-15 21:23 [Buildroot] [PATCH 1/4] libshout: new package Jörg Krause
` (3 preceding siblings ...)
2014-10-16 8:41 ` [Buildroot] [PATCH 1/4] libshout: new package Thomas Petazzoni
@ 2014-10-17 14:11 ` Peter Korsgaard
4 siblings, 0 replies; 12+ messages in thread
From: Peter Korsgaard @ 2014-10-17 14:11 UTC (permalink / raw)
To: buildroot
>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> +++ b/package/libshout/libshout.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# libshout
> +#
> +################################################################################
> +
> +LIBSHOUT_VERSION = 2.3.1
> +LIBSHOUT_SITE = http://downloads.xiph.org/releases/libshout
> +LIBSHOUT_LICENSE = LGPLv2
> +LIBSHOUT_LICENSE_FILES = COPYING
> +LIBSHOUT_INSTALL_STAGING = YES
> +LIBSHOUT_DEPENDENCIES = libogg libvorbis
Thanks - Next to the issues Thomas pointed out there's a few more:
The configure script uses PKG_CHECK_MODULES, so you need
host-pkgconf. There's also optional support for libtheora and speex so
I've added that.
Committed with these fixes, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 12+ messages in thread