From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 4/8] package/mpd: enable support for libsoxr
Date: Thu, 16 Oct 2014 11:33:37 +0200 [thread overview]
Message-ID: <20141016113337.439d3720@free-electrons.com> (raw)
In-Reply-To: <1413379134-28918-4-git-send-email-jkrause@posteo.de>
Dear J?rg Krause,
On Wed, 15 Oct 2014 15:18:50 +0200, J?rg Krause wrote:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
> Changes v1 -> v2:
> - none
> ---
> package/mpd/Config.in | 7 +++++++
> package/mpd/mpd.mk | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index 10f3cf0..eba280a 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -46,6 +46,13 @@ config BR2_PACKAGE_MPD_LIBSAMPLERATE
> Enable libsamplerate input support.
> Select this for software sample rate conversion.
>
> +config BR2_PACKAGE_MPD_LIBSOXR
> + bool "libsoxr"
> + select BR2_PACKAGE_LIBSOXR
> + help
> + Enable libsoxr resampler support.
> + The SoX Resampler library performs software sample-rate conversion.
> +
I apologize for the silly comment, but the indentation is wrong here.
The help text should be indented with one tab plus two spaces, not two
tabs.
Same issue applies to patches 4, 5, 6 and 7 of your series.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-16 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 13:18 [Buildroot] [PATCH v2 1/8] package/mpd: bump to version 0.19 Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 2/8] package/mpd: sort plugins by type in Config.in Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 3/8] package/mpd: sort plugins alphabetically in mpd.mk Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 4/8] package/mpd: enable support for libsoxr Jörg Krause
2014-10-16 9:33 ` Thomas Petazzoni [this message]
2014-10-16 10:29 ` Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 5/8] package/mpd: enable support for libsmbclient Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 6/8] package/mpd: enable support for libnfs Jörg Krause
2014-10-16 9:44 ` Thomas Petazzoni
2014-10-16 10:57 ` Jörg Krause
2014-10-17 22:15 ` Arnout Vandecappelle
2014-10-17 23:02 ` Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 7/8] package/mpd: enable support for dsd Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 8/8] package/mpd: fix zeroconf support Jörg Krause
2014-10-16 9:50 ` Thomas Petazzoni
2014-10-16 10:57 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016113337.439d3720@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox