From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 8/8] package/mpd: fix zeroconf support
Date: Thu, 16 Oct 2014 11:50:03 +0200 [thread overview]
Message-ID: <20141016115003.43eceeab@free-electrons.com> (raw)
In-Reply-To: <1413379134-28918-8-git-send-email-jkrause@posteo.de>
Dear J?rg Krause,
On Wed, 15 Oct 2014 15:18:54 +0200, J?rg Krause wrote:
> # Some options need an explicit --disable or --enable
> -ifeq ($(BR2_PACKAGE_AVAHI_DAEMON),y)
> +
> +# Zeroconf support depends on libdns_sd from avahi.
> +ifeq ($(BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY),y)
> MPD_DEPENDENCIES += avahi
> else
> MPD_CONF_OPTS += --with-zeroconf=no
It doesn't seem really obvious for the user that
BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY should be enabled to get avahi
support in mpd. So, in such situations, I would suggest to add a
Config.in option to explicitly enable the Avahi support in mpd:
config BR2_PACKAGE_MPD_AVAHI_SUPPORT
bool "avahi support"
depends on ... # all the dependencies of avahi
select BR2_PACKAGE_AVAHI
select BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
help
Some help text
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-16 9:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 13:18 [Buildroot] [PATCH v2 1/8] package/mpd: bump to version 0.19 Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 2/8] package/mpd: sort plugins by type in Config.in Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 3/8] package/mpd: sort plugins alphabetically in mpd.mk Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 4/8] package/mpd: enable support for libsoxr Jörg Krause
2014-10-16 9:33 ` Thomas Petazzoni
2014-10-16 10:29 ` Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 5/8] package/mpd: enable support for libsmbclient Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 6/8] package/mpd: enable support for libnfs Jörg Krause
2014-10-16 9:44 ` Thomas Petazzoni
2014-10-16 10:57 ` Jörg Krause
2014-10-17 22:15 ` Arnout Vandecappelle
2014-10-17 23:02 ` Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 7/8] package/mpd: enable support for dsd Jörg Krause
2014-10-15 13:18 ` [Buildroot] [PATCH v2 8/8] package/mpd: fix zeroconf support Jörg Krause
2014-10-16 9:50 ` Thomas Petazzoni [this message]
2014-10-16 10:57 ` Jörg Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016115003.43eceeab@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox