Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst1-plugins-imx: add package
Date: Fri, 17 Oct 2014 23:07:15 +0200	[thread overview]
Message-ID: <20141017210715.GF3971@free.fr> (raw)
In-Reply-To: <543D901B.8010806@mind.be>

Arnout, All,

On 2014-10-14 23:05 +0200, Arnout Vandecappelle spake thusly:
> On 14/10/14 19:16, Gary Bisson wrote:
> > On Tue, Oct 14, 2014 at 7:31 AM, Arnout Vandecappelle <arnout@mind.be
> > <mailto:arnout@mind.be>> wrote:
> > 
> >     [snip]
> >     > # Required by gpu-viv-bin-mx6q
> >     > comment "gst1-plugins-imx needs an (e)glibc toolchain"
> >     >     depends on BR2_arm
> >     >     depends on !BR2_TOOLCHAIN_USES_GLIBC
> > 
> >      That's not the right place for pointing to gpu-viv-bin-mx6q. It should be
> >     something like:
> > 
> >     config BR2_PACKAGE_GST1_PLUGINS_IMX
> >             bool "gst1-plugins-imx"
> >             depends on BR2_LINUX_KERNEL
> >             depends on BR2_arm # Only relevant for i.MX
> >             depends on BR2_TOOLCHAIN_USES_GLIBC # gpu-viv-bin-mx6q
> >             select BR2_PACKAGE_GPU_VIV_BIN_MX6Q
> >             # Cannot select libfslvpuwrap because user must select the CPU
> >             depends on BR2_PACKAGE_LIBFSLVPUWRAP
> > 
> >     (I added that thing about libfslvpuwrap but I'm not sure of it...)
> > 
> >  
> > That is actually what I said in the first e-mail, I am not proud of all those
> > dependencies but I couldn't find a way to select GPU_VIV_MX6Q as it is only
> > selectable if  FREESCALE_IMX_PLATFORM is set to FREESCALE_IMX_PLATFORM_IMX6Q. A
> > select like above would give an error but I'm open to any other solution.
> 
>  Actually, you can do
> 	select BR2_PACKAGE_FREESCALE_IMX
> 	select BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q

No you can't do that, because BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q
is part of a choice, and you can not select a choice entry.

So a 'depends on' it must be in this case.

Not sure what to do about the comment, though. We currently have no such
case documented in the manual; only comments about toolchain deps are
described...

I'm not against adding comments about dependencies on other packages,
but I think we should keep them to a minimal level, like dependencies on
biggish stuff (like X.org), or non-obvious stuff.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-10-17 21:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05 21:47 [Buildroot] [PATCH] gst1-plugins-imx: add package Gary Bisson
2014-10-12 14:43 ` Luca Ceresoli
2014-10-13  4:18   ` Gary Bisson
2014-10-13 12:06     ` Luca Ceresoli
2014-10-14 14:31       ` Arnout Vandecappelle
2014-10-14 17:16         ` Gary Bisson
2014-10-14 21:05           ` Arnout Vandecappelle
2014-10-17 21:07             ` Yann E. MORIN [this message]
2014-10-17 21:28               ` Gary Bisson
2014-10-17 21:39                 ` Yann E. MORIN
2014-10-28 15:02                   ` Luca Ceresoli
  -- strict thread matches above, loose matches on Subject: below --
2014-10-13 22:05 Peter Seiderer
2014-10-14  7:16 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141017210715.GF3971@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox