Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Bisson <bisson.gary@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gst1-plugins-imx: add package
Date: Fri, 17 Oct 2014 14:28:12 -0700	[thread overview]
Message-ID: <544189EC.5050905@gmail.com> (raw)
In-Reply-To: <20141017210715.GF3971@free.fr>

Yann, All,

On 10/17/2014 02:07 PM, Yann E. MORIN wrote:
> [snip]
> No you can't do that, because BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6Q
> is part of a choice, and you can not select a choice entry.
>
> So a 'depends on' it must be in this case.
>
> Not sure what to do about the comment, though. We currently have no such
> case documented in the manual; only comments about toolchain deps are
> described...
>
> I'm not against adding comments about dependencies on other packages,
> but I think we should keep them to a minimal level, like dependencies on
> biggish stuff (like X.org), or non-obvious stuff.
>
> Regards,
> Yann E. MORIN.

I agree that a dependency seemed like the only option. Regarding the 
comment it was more about showing the package exists.
Although doing a search will tell you about it and its dependencies I'm 
afraid people would think the package is missing.
As a comparison the Gstreamer 0.10 fsl plugin always shows up as it does 
not depend on iMX6 GPU libs.

Anyway, would it make sense for me to offer a patch v2 or should we wait 
to agree first on modifications?

So far I have listed those modifications to be made on the current version:
- Use of github helper macro
- Modify package comment with Peter S. original patch
- Remove eglibc dependency (already from GPU libs)

But I am still unclear on two items:
- Package naming: although Peter K. did prefer gstreamer1-imx over 
gstreamer-imx [1], gst1-plugins-imx still looks closer to BR plugin naming.
Also consider the Yocto recipe name [2] which is 
gstreamer1.0-plugins-imx, pretty close from gst1-plugins-imx.
- Comments: comments on package dependencies could be removed at first 
and if people find it confusing we could work on it later.

Regards,
Gary

[1] http://lists.busybox.net/pipermail/buildroot/2014-February/090496.html
[2] 
https://github.com/Freescale/meta-fsl-arm/blob/master/recipes-multimedia/gstreamer/gstreamer1.0-plugins-imx_0.9.9.bb

  reply	other threads:[~2014-10-17 21:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-05 21:47 [Buildroot] [PATCH] gst1-plugins-imx: add package Gary Bisson
2014-10-12 14:43 ` Luca Ceresoli
2014-10-13  4:18   ` Gary Bisson
2014-10-13 12:06     ` Luca Ceresoli
2014-10-14 14:31       ` Arnout Vandecappelle
2014-10-14 17:16         ` Gary Bisson
2014-10-14 21:05           ` Arnout Vandecappelle
2014-10-17 21:07             ` Yann E. MORIN
2014-10-17 21:28               ` Gary Bisson [this message]
2014-10-17 21:39                 ` Yann E. MORIN
2014-10-28 15:02                   ` Luca Ceresoli
  -- strict thread matches above, loose matches on Subject: below --
2014-10-13 22:05 Peter Seiderer
2014-10-14  7:16 ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544189EC.5050905@gmail.com \
    --to=bisson.gary@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox