[Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call

[Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call

[Maxime Hadjinlian]

As the comment says, we don't want to uses the github helper, as we
would end up with a generated tarball, which is not the same one as the
one linked with the releases.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
v2 -> v3:
   - fix typo
v1 -> v2:
   - Do not change the URL but add a comments instead
---
 package/mongrel2/mongrel2.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/mongrel2/mongrel2.mk b/package/mongrel2/mongrel2.mk
index 14e3a80..23cec50 100644
--- a/package/mongrel2/mongrel2.mk
+++ b/package/mongrel2/mongrel2.mk
@@ -5,6 +5,8 @@
 ################################################################################
 
 MONGREL2_VERSION = v1.9.1
+# Do not use the github helper here, the generated tarball is *NOT* the same
+# as the one uploaded by upstream for the release.
 MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
 MONGREL2_LICENSE = BSD-3c
 MONGREL2_LICENSE_FILES = LICENSE
-- 
2.1.1

[Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call

[Yann E. MORIN]

Maxime, All,

On 2014-10-12 21:39 +0200, Maxime Hadjinlian spake thusly:
> As the comment says, we don't want to uses the github helper, as we
> would end up with a generated tarball, which is not the same one as the
> one linked with the releases.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
> v2 -> v3:
>    - fix typo
> v1 -> v2:
>    - Do not change the URL but add a comments instead
> ---
>  package/mongrel2/mongrel2.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/mongrel2/mongrel2.mk b/package/mongrel2/mongrel2.mk
> index 14e3a80..23cec50 100644
> --- a/package/mongrel2/mongrel2.mk
> +++ b/package/mongrel2/mongrel2.mk
> @@ -5,6 +5,8 @@
>  ################################################################################
>  
>  MONGREL2_VERSION = v1.9.1
> +# Do not use the github helper here, the generated tarball is *NOT* the same
> +# as the one uploaded by upstream for the release.
>  MONGREL2_SITE = https://github.com/zedshaw/mongrel2/releases/download/$(MONGREL2_VERSION)
>  MONGREL2_LICENSE = BSD-3c
>  MONGREL2_LICENSE_FILES = LICENSE
> -- 
> 2.1.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v3] mongrel2: Add comments to avoid use of github call

[Thomas Petazzoni]

Dear Maxime Hadjinlian,

On Sun, 12 Oct 2014 21:39:18 +0200, Maxime Hadjinlian wrote:
> As the comment says, we don't want to uses the github helper, as we
> would end up with a generated tarball, which is not the same one as the
> one linked with the releases.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> v2 -> v3:
>    - fix typo
> v1 -> v2:
>    - Do not change the URL but add a comments instead
> ---
>  package/mongrel2/mongrel2.mk | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com