Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name
@ 2014-10-19 10:49 Maxime Hadjinlian
  2014-10-19 10:49 ` [Buildroot] [PATCH 2/2] geoip: Remove useless variable Maxime Hadjinlian
  2014-10-19 11:57 ` [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Yann E. MORIN
  0 siblings, 2 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2014-10-19 10:49 UTC (permalink / raw)
  To: buildroot

As stated in the manual, for the github helper, the VERSION should value
either a tag or a full commit ID.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/bmon/bmon.mk   | 4 ++--
 package/geoip/geoip.mk | 4 ++--
 package/lxc/lxc.mk     | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/bmon/bmon.mk b/package/bmon/bmon.mk
index d4c7a49..dc00d82 100644
--- a/package/bmon/bmon.mk
+++ b/package/bmon/bmon.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-BMON_VERSION = 3.2
-BMON_SITE = $(call github,tgraf,bmon,v$(BMON_VERSION))
+BMON_VERSION = v3.2
+BMON_SITE = $(call github,tgraf,bmon,$(BMON_VERSION))
 # configure not shipped
 BMON_AUTORECONF = YES
 BMON_DEPENDENCIES = host-pkgconf libconfuse libnl ncurses
diff --git a/package/geoip/geoip.mk b/package/geoip/geoip.mk
index bbfa014..869cc5e 100644
--- a/package/geoip/geoip.mk
+++ b/package/geoip/geoip.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-GEOIP_VERSION = 1.6.0
+GEOIP_VERSION = v1.6.0
 GEOIP_SOURCE = GeoIP-$(GEOIP_VERSION).tar.gz
-GEOIP_SITE = $(call github,maxmind,geoip-api-c,v$(GEOIP_VERSION))
+GEOIP_SITE = $(call github,maxmind,geoip-api-c,$(GEOIP_VERSION))
 GEOIP_AUTORECONF = YES
 GEOIP_INSTALL_STAGING = YES
 GEOIP_LICENSE = LGPLv2.1+
diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index 38bda7e..953df13 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-LXC_VERSION = 1.0.4
-LXC_SITE = $(call github,lxc,lxc,lxc-$(LXC_VERSION))
+LXC_VERSION = lxc-1.0.4
+LXC_SITE = $(call github,lxc,lxc,$(LXC_VERSION))
 LXC_LICENSE = LGPLv2.1+
 LXC_LICENSE_FILES = COPYING
 LXC_DEPENDENCIES = libcap host-pkgconf
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] geoip: Remove useless variable
  2014-10-19 10:49 [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Maxime Hadjinlian
@ 2014-10-19 10:49 ` Maxime Hadjinlian
  2014-10-19 11:09   ` Maxime Hadjinlian
  2014-10-19 11:57 ` [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Yann E. MORIN
  1 sibling, 1 reply; 4+ messages in thread
From: Maxime Hadjinlian @ 2014-10-19 10:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/geoip/geoip.mk | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/geoip/geoip.mk b/package/geoip/geoip.mk
index 869cc5e..0a0dad0 100644
--- a/package/geoip/geoip.mk
+++ b/package/geoip/geoip.mk
@@ -5,7 +5,6 @@
 ################################################################################
 
 GEOIP_VERSION = v1.6.0
-GEOIP_SOURCE = GeoIP-$(GEOIP_VERSION).tar.gz
 GEOIP_SITE = $(call github,maxmind,geoip-api-c,$(GEOIP_VERSION))
 GEOIP_AUTORECONF = YES
 GEOIP_INSTALL_STAGING = YES
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] geoip: Remove useless variable
  2014-10-19 10:49 ` [Buildroot] [PATCH 2/2] geoip: Remove useless variable Maxime Hadjinlian
@ 2014-10-19 11:09   ` Maxime Hadjinlian
  0 siblings, 0 replies; 4+ messages in thread
From: Maxime Hadjinlian @ 2014-10-19 11:09 UTC (permalink / raw)
  To: buildroot

This is a NAK, needs some more work since the packages has been bumped
and there is a release file.
Will come back with a new patch.

On Sun, Oct 19, 2014 at 12:49 PM, Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/geoip/geoip.mk | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/package/geoip/geoip.mk b/package/geoip/geoip.mk
> index 869cc5e..0a0dad0 100644
> --- a/package/geoip/geoip.mk
> +++ b/package/geoip/geoip.mk
> @@ -5,7 +5,6 @@
>  ################################################################################
>
>  GEOIP_VERSION = v1.6.0
> -GEOIP_SOURCE = GeoIP-$(GEOIP_VERSION).tar.gz
>  GEOIP_SITE = $(call github,maxmind,geoip-api-c,$(GEOIP_VERSION))
>  GEOIP_AUTORECONF = YES
>  GEOIP_INSTALL_STAGING = YES
> --
> 2.1.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name
  2014-10-19 10:49 [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Maxime Hadjinlian
  2014-10-19 10:49 ` [Buildroot] [PATCH 2/2] geoip: Remove useless variable Maxime Hadjinlian
@ 2014-10-19 11:57 ` Yann E. MORIN
  1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2014-10-19 11:57 UTC (permalink / raw)
  To: buildroot

Maxime, All,

On 2014-10-19 12:49 +0200, Maxime Hadjinlian spake thusly:
> As stated in the manual, for the github helper, the VERSION should value
> either a tag or a full commit ID.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/bmon/bmon.mk   | 4 ++--
>  package/geoip/geoip.mk | 4 ++--
>  package/lxc/lxc.mk     | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/package/bmon/bmon.mk b/package/bmon/bmon.mk
> index d4c7a49..dc00d82 100644
> --- a/package/bmon/bmon.mk
> +++ b/package/bmon/bmon.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -BMON_VERSION = 3.2
> -BMON_SITE = $(call github,tgraf,bmon,v$(BMON_VERSION))
> +BMON_VERSION = v3.2
> +BMON_SITE = $(call github,tgraf,bmon,$(BMON_VERSION))

That's also a case where:
  - the package has a new release, 3.5
  - there is a release tarball, so we should not use the github helper

>  # configure not shipped
>  BMON_AUTORECONF = YES
>  BMON_DEPENDENCIES = host-pkgconf libconfuse libnl ncurses
> diff --git a/package/geoip/geoip.mk b/package/geoip/geoip.mk
> index bbfa014..869cc5e 100644
> --- a/package/geoip/geoip.mk
> +++ b/package/geoip/geoip.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -GEOIP_VERSION = 1.6.0
> +GEOIP_VERSION = v1.6.0
>  GEOIP_SOURCE = GeoIP-$(GEOIP_VERSION).tar.gz
> -GEOIP_SITE = $(call github,maxmind,geoip-api-c,v$(GEOIP_VERSION))
> +GEOIP_SITE = $(call github,maxmind,geoip-api-c,$(GEOIP_VERSION))

Ditto:
  - release 1.6.2 is out
  - there is a release tarball

>  GEOIP_AUTORECONF = YES
>  GEOIP_INSTALL_STAGING = YES
>  GEOIP_LICENSE = LGPLv2.1+
> diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
> index 38bda7e..953df13 100644
> --- a/package/lxc/lxc.mk
> +++ b/package/lxc/lxc.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -LXC_VERSION = 1.0.4
> -LXC_SITE = $(call github,lxc,lxc,lxc-$(LXC_VERSION))
> +LXC_VERSION = lxc-1.0.4o

There's also a new release: 1.0.6.

> +LXC_SITE = $(call github,lxc,lxc,$(LXC_VERSION))
>  LXC_LICENSE = LGPLv2.1+
>  LXC_LICENSE_FILES = COPYING
>  LXC_DEPENDENCIES = libcap host-pkgconf
> -- 
> 2.1.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-19 11:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-19 10:49 [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Maxime Hadjinlian
2014-10-19 10:49 ` [Buildroot] [PATCH 2/2] geoip: Remove useless variable Maxime Hadjinlian
2014-10-19 11:09   ` Maxime Hadjinlian
2014-10-19 11:57 ` [Buildroot] [PATCH 1/2] packages: VERSION should reflect tag name Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox