* [Buildroot] [PATCH 1/1] package/alsa-utils: Link against libintl if needed
@ 2014-10-19 12:46 Bernd Kuhls
2014-10-19 13:17 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Bernd Kuhls @ 2014-10-19 12:46 UTC (permalink / raw)
To: buildroot
Fixes
alsamixer-cli.o: In function `main':
cli.c:(.text.startup+0x4d): undefined reference to `libintl_textdomain'
cli.c:(.text.startup+0xc1): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0xd5): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0xe9): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0x1fd): undefined reference to `libintl_gettext'
cli.c:(.text.startup+0x223): undefined reference to `libintl_gettext'
alsamixer-card_select.o:card_select.c:(.text+0xb8): more undefined references to `libintl_gettext' follow
collect2: Fehler: ld gab 1 als Ende-Status zur?ck
make[2]: *** [alsamixer] Fehler 1
make[2]: Leaving directory `/home/fli4l/br4/output/build/alsa-utils-1.0.28/alsamixer'
The build error occured using this minimal defconfig:
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_TOOLCHAIN_BUILDROOT_INET_RPC=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_PACKAGE_ALSA_UTILS=y
BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
BR2_PACKAGE_ALSA_UTILS_AMIDI=y
BR2_PACKAGE_ALSA_UTILS_AMIXER=y
BR2_PACKAGE_ALSA_UTILS_APLAY=y
BR2_PACKAGE_ALSA_UTILS_IECSET=y
BR2_PACKAGE_ALSA_UTILS_ACONNECT=y
BR2_PACKAGE_ALSA_UTILS_APLAYMIDI=y
BR2_PACKAGE_ALSA_UTILS_ARECORDMIDI=y
BR2_PACKAGE_ALSA_UTILS_ASEQDUMP=y
BR2_PACKAGE_ALSA_UTILS_ASEQNET=y
BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y
BR2_PACKAGE_GETTEXT=y
BR2_PACKAGE_NCURSES_WCHAR=y
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/alsa-utils/alsa-utils-0001-libintl.patch | 23 ++++++++++++++++++++++
package/alsa-utils/alsa-utils.mk | 2 ++
2 files changed, 25 insertions(+)
create mode 100644 package/alsa-utils/alsa-utils-0001-libintl.patch
diff --git a/package/alsa-utils/alsa-utils-0001-libintl.patch b/package/alsa-utils/alsa-utils-0001-libintl.patch
new file mode 100644
index 0000000..0562ce8
--- /dev/null
+++ b/package/alsa-utils/alsa-utils-0001-libintl.patch
@@ -0,0 +1,23 @@
+Link against libintl if needed
+
+When built against a C library that has locale support, but for which
+intl support is provided by an external libintl library, alsamixer
+forgets to link against this library, even though the configure script
+properly checks that.
+
+This patch therefore ensure that we link against libintl when needed,
+thanks to the @LIBINTL@ variable provided by the configure script.
+
+Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
+
+
+diff -uNr alsa-utils-1.0.28.org/alsamixer/Makefile.am alsa-utils-1.0.28/alsamixer/Makefile.am
+--- alsa-utils-1.0.28.org/alsamixer/Makefile.am 2014-06-13 19:21:05.000000000 +0200
++++ alsa-utils-1.0.28/alsamixer/Makefile.am 2014-10-19 13:13:09.333149017 +0200
+@@ -1,5 +1,5 @@
+ AM_CFLAGS = @CURSES_CFLAGS@ -DCURSESINC="@CURSESINC@"
+-LDADD = @CURSESLIB@
++LDADD = @CURSESLIB@ @LIBINTL@
+
+ bin_PROGRAMS = alsamixer
+ alsamixer_SOURCES = card_select.c card_select.h \
diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
index 7079361..b69433f 100644
--- a/package/alsa-utils/alsa-utils.mk
+++ b/package/alsa-utils/alsa-utils.mk
@@ -9,6 +9,8 @@ ALSA_UTILS_SOURCE = alsa-utils-$(ALSA_UTILS_VERSION).tar.bz2
ALSA_UTILS_SITE = http://alsa.cybermirror.org/utils
ALSA_UTILS_LICENSE = GPLv2
ALSA_UTILS_LICENSE_FILES = COPYING
+ALSA_UTILS_AUTORECONF = YES
+ALSA_UTILS_GETTEXTIZE = YES
ALSA_UTILS_INSTALL_STAGING = YES
ALSA_UTILS_DEPENDENCIES = host-gettext host-pkgconf alsa-lib \
$(if $(BR2_PACKAGE_NCURSES),ncurses)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/alsa-utils: Link against libintl if needed
2014-10-19 12:46 [Buildroot] [PATCH 1/1] package/alsa-utils: Link against libintl if needed Bernd Kuhls
@ 2014-10-19 13:17 ` Baruch Siach
2014-10-19 13:22 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2014-10-19 13:17 UTC (permalink / raw)
To: buildroot
Hi Bernd,
On Sun, Oct 19, 2014 at 02:46:39PM +0200, Bernd Kuhls wrote:
> Fixes
> alsamixer-cli.o: In function `main':
> cli.c:(.text.startup+0x4d): undefined reference to `libintl_textdomain'
> cli.c:(.text.startup+0xc1): undefined reference to `libintl_gettext'
> cli.c:(.text.startup+0xd5): undefined reference to `libintl_gettext'
> cli.c:(.text.startup+0xe9): undefined reference to `libintl_gettext'
> cli.c:(.text.startup+0x1fd): undefined reference to `libintl_gettext'
> cli.c:(.text.startup+0x223): undefined reference to `libintl_gettext'
> alsamixer-card_select.o:card_select.c:(.text+0xb8): more undefined references to `libintl_gettext' follow
> collect2: Fehler: ld gab 1 als Ende-Status zur?ck
> make[2]: *** [alsamixer] Fehler 1
I think English error messages would be more google friendly.
> make[2]: Leaving directory
> `/home/fli4l/br4/output/build/alsa-utils-1.0.28/alsamixer'
>
> The build error occured using this minimal defconfig:
>
> BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
> BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
> BR2_TOOLCHAIN_BUILDROOT_INET_RPC=y
> BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
> BR2_PACKAGE_ALSA_UTILS=y
> BR2_PACKAGE_ALSA_UTILS_ALSACONF=y
> BR2_PACKAGE_ALSA_UTILS_AMIDI=y
> BR2_PACKAGE_ALSA_UTILS_AMIXER=y
> BR2_PACKAGE_ALSA_UTILS_APLAY=y
> BR2_PACKAGE_ALSA_UTILS_IECSET=y
> BR2_PACKAGE_ALSA_UTILS_ACONNECT=y
> BR2_PACKAGE_ALSA_UTILS_APLAYMIDI=y
> BR2_PACKAGE_ALSA_UTILS_ARECORDMIDI=y
> BR2_PACKAGE_ALSA_UTILS_ASEQDUMP=y
> BR2_PACKAGE_ALSA_UTILS_ASEQNET=y
> BR2_PACKAGE_ALSA_UTILS_SPEAKER_TEST=y
> BR2_PACKAGE_GETTEXT=y
> BR2_PACKAGE_NCURSES_WCHAR=y
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/alsa-utils/alsa-utils-0001-libintl.patch | 23 ++++++++++++++++++++++
> package/alsa-utils/alsa-utils.mk | 2 ++
> 2 files changed, 25 insertions(+)
> create mode 100644 package/alsa-utils/alsa-utils-0001-libintl.patch
>
> diff --git a/package/alsa-utils/alsa-utils-0001-libintl.patch b/package/alsa-utils/alsa-utils-0001-libintl.patch
> new file mode 100644
> index 0000000..0562ce8
> --- /dev/null
> +++ b/package/alsa-utils/alsa-utils-0001-libintl.patch
> @@ -0,0 +1,23 @@
> +Link against libintl if needed
> +
> +When built against a C library that has locale support, but for which
> +intl support is provided by an external libintl library, alsamixer
> +forgets to link against this library, even though the configure script
> +properly checks that.
> +
> +This patch therefore ensure that we link against libintl when needed,
> +thanks to the @LIBINTL@ variable provided by the configure script.
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> +
> +
> +diff -uNr alsa-utils-1.0.28.org/alsamixer/Makefile.am alsa-utils-1.0.28/alsamixer/Makefile.am
> +--- alsa-utils-1.0.28.org/alsamixer/Makefile.am 2014-06-13 19:21:05.000000000 +0200
> ++++ alsa-utils-1.0.28/alsamixer/Makefile.am 2014-10-19 13:13:09.333149017 +0200
> +@@ -1,5 +1,5 @@
> + AM_CFLAGS = @CURSES_CFLAGS@ -DCURSESINC="@CURSESINC@"
> +-LDADD = @CURSESLIB@
> ++LDADD = @CURSESLIB@ @LIBINTL@
> +
> + bin_PROGRAMS = alsamixer
> + alsamixer_SOURCES = card_select.c card_select.h \
> diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
> index 7079361..b69433f 100644
> --- a/package/alsa-utils/alsa-utils.mk
> +++ b/package/alsa-utils/alsa-utils.mk
> @@ -9,6 +9,8 @@ ALSA_UTILS_SOURCE = alsa-utils-$(ALSA_UTILS_VERSION).tar.bz2
> ALSA_UTILS_SITE = http://alsa.cybermirror.org/utils
> ALSA_UTILS_LICENSE = GPLv2
> ALSA_UTILS_LICENSE_FILES = COPYING
> +ALSA_UTILS_AUTORECONF = YES
> +ALSA_UTILS_GETTEXTIZE = YES
Why is this needed?
> ALSA_UTILS_INSTALL_STAGING = YES
> ALSA_UTILS_DEPENDENCIES = host-gettext host-pkgconf alsa-lib \
> $(if $(BR2_PACKAGE_NCURSES),ncurses)
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] package/alsa-utils: Link against libintl if needed
2014-10-19 13:17 ` Baruch Siach
@ 2014-10-19 13:22 ` Yann E. MORIN
0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2014-10-19 13:22 UTC (permalink / raw)
To: buildroot
Baruch, Bernd, All,
On 2014-10-19 16:17 +0300, Baruch Siach spake thusly:
> On Sun, Oct 19, 2014 at 02:46:39PM +0200, Bernd Kuhls wrote:
> > Fixes
> > alsamixer-cli.o: In function `main':
> > cli.c:(.text.startup+0x4d): undefined reference to `libintl_textdomain'
> > cli.c:(.text.startup+0xc1): undefined reference to `libintl_gettext'
> > cli.c:(.text.startup+0xd5): undefined reference to `libintl_gettext'
> > cli.c:(.text.startup+0xe9): undefined reference to `libintl_gettext'
> > cli.c:(.text.startup+0x1fd): undefined reference to `libintl_gettext'
> > cli.c:(.text.startup+0x223): undefined reference to `libintl_gettext'
> > alsamixer-card_select.o:card_select.c:(.text+0xb8): more undefined references to `libintl_gettext' follow
> > collect2: Fehler: ld gab 1 als Ende-Status zur?ck
> > make[2]: *** [alsamixer] Fehler 1
>
> I think English error messages would be more google friendly.
Indeed. :-)
> > diff --git a/package/alsa-utils/alsa-utils-0001-libintl.patch b/package/alsa-utils/alsa-utils-0001-libintl.patch
> > new file mode 100644
> > index 0000000..0562ce8
> > --- /dev/null
> > +++ b/package/alsa-utils/alsa-utils-0001-libintl.patch
> > @@ -0,0 +1,23 @@
> > +Link against libintl if needed
> > +
> > +When built against a C library that has locale support, but for which
> > +intl support is provided by an external libintl library, alsamixer
> > +forgets to link against this library, even though the configure script
> > +properly checks that.
> > +
> > +This patch therefore ensure that we link against libintl when needed,
> > +thanks to the @LIBINTL@ variable provided by the configure script.
> > +
> > +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > +
> > +
> > +diff -uNr alsa-utils-1.0.28.org/alsamixer/Makefile.am alsa-utils-1.0.28/alsamixer/Makefile.am
> > +--- alsa-utils-1.0.28.org/alsamixer/Makefile.am 2014-06-13 19:21:05.000000000 +0200
> > ++++ alsa-utils-1.0.28/alsamixer/Makefile.am 2014-10-19 13:13:09.333149017 +0200
> > +@@ -1,5 +1,5 @@
> > + AM_CFLAGS = @CURSES_CFLAGS@ -DCURSESINC="@CURSESINC@"
> > +-LDADD = @CURSESLIB@
> > ++LDADD = @CURSESLIB@ @LIBINTL@
> > +
> > + bin_PROGRAMS = alsamixer
> > + alsamixer_SOURCES = card_select.c card_select.h \
> > diff --git a/package/alsa-utils/alsa-utils.mk b/package/alsa-utils/alsa-utils.mk
> > index 7079361..b69433f 100644
> > --- a/package/alsa-utils/alsa-utils.mk
> > +++ b/package/alsa-utils/alsa-utils.mk
> > @@ -9,6 +9,8 @@ ALSA_UTILS_SOURCE = alsa-utils-$(ALSA_UTILS_VERSION).tar.bz2
> > ALSA_UTILS_SITE = http://alsa.cybermirror.org/utils
> > ALSA_UTILS_LICENSE = GPLv2
> > ALSA_UTILS_LICENSE_FILES = COPYING
> > +ALSA_UTILS_AUTORECONF = YES
> > +ALSA_UTILS_GETTEXTIZE = YES
>
> Why is this needed?
AUTORECONF is needed because the patch touches a Makefile.am . However,
it would be nice to add a comment why.
Ditto for GETTEXTIZE.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-19 13:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-19 12:46 [Buildroot] [PATCH 1/1] package/alsa-utils: Link against libintl if needed Bernd Kuhls
2014-10-19 13:17 ` Baruch Siach
2014-10-19 13:22 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox