Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] libupnpp: new package
@ 2014-10-20 13:50 Jörg Krause
  2014-10-20 13:50 ` [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5 Jörg Krause
  2014-10-20 17:43 ` [Buildroot] [PATCH 1/2] libupnpp: new package Yann E. MORIN
  0 siblings, 2 replies; 6+ messages in thread
From: Jörg Krause @ 2014-10-20 13:50 UTC (permalink / raw)
  To: buildroot

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/Config.in            |  1 +
 package/libupnpp/Config.in   | 20 ++++++++++++++++++++
 package/libupnpp/libupnpp.mk | 14 ++++++++++++++
 3 files changed, 35 insertions(+)
 create mode 100644 package/libupnpp/Config.in
 create mode 100644 package/libupnpp/libupnpp.mk

diff --git a/package/Config.in b/package/Config.in
index 89b46dc..4626f00 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -816,6 +816,7 @@ menu "Networking"
 	source "package/libtirpc/Config.in"
 	source "package/libtorrent/Config.in"
 	source "package/libupnp/Config.in"
+	source "package/libupnpp/Config.in"
 	source "package/libvncserver/Config.in"
 	source "package/libwebsockets/Config.in"
 	source "package/neon/Config.in"
diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in
new file mode 100644
index 0000000..5a79452
--- /dev/null
+++ b/package/libupnpp/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_LIBUPNPP
+	bool "libupnpp"
+	select BR2_PACKAGE_EXPAT
+	select BR2_PACKAGE_LIBCURL
+	select BR2_PACKAGE_LIBUPNP
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_LARGEFILE # libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
+	help
+	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
+	  upplay.
+
+	  http://www.lesbonscomptes.com/upmpdcli/
+
+comment "upmpdcli needs a toolchain w/ C++, largefile, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \
+		!BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk
new file mode 100644
index 0000000..d46de14
--- /dev/null
+++ b/package/libupnpp/libupnpp.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libupnpp
+#
+################################################################################
+
+LIBUPNPP_VERSION = 0.8.5
+LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
+LIBUPNPP_LICENSE = GPLv2+
+LIBUPNPP_LICENSE_FILES = COPYING
+LIBUPNPP_INSTALL_STAGING = YES
+LIBUPNPP_DEPENDENCIES = expat libcurl libupnp
+
+$(eval $(autotools-package))
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5
  2014-10-20 13:50 [Buildroot] [PATCH 1/2] libupnpp: new package Jörg Krause
@ 2014-10-20 13:50 ` Jörg Krause
  2014-10-20 17:46   ` Yann E. MORIN
  2014-10-20 17:43 ` [Buildroot] [PATCH 1/2] libupnpp: new package Yann E. MORIN
  1 sibling, 1 reply; 6+ messages in thread
From: Jörg Krause @ 2014-10-20 13:50 UTC (permalink / raw)
  To: buildroot

New version of upmpdcli now depends on libupnpp, which was ectracted from the
source and now exists in its own package.

Signed-off-by: J?rg Krause <jkrause@posteo.de>
---
 package/upmpdcli/Config.in   | 8 +++-----
 package/upmpdcli/upmpdcli.mk | 4 ++--
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
index f28c775..84649d2 100644
--- a/package/upmpdcli/Config.in
+++ b/package/upmpdcli/Config.in
@@ -1,12 +1,10 @@
 config BR2_PACKAGE_UPMPDCLI
 	bool "upmpdcli"
-	select BR2_PACKAGE_EXPAT
-	select BR2_PACKAGE_LIBCURL
-	select BR2_PACKAGE_LIBUPNP
 	select BR2_PACKAGE_LIBMPDCLIENT
+	select BR2_PACKAGE_LIBUPNPP
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_LARGEFILE # libupnp
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
+	depends on BR2_LARGEFILE # libupnpp -> libupnp
+	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp -> libupnp
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
 	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
index 547752a..a47c456 100644
--- a/package/upmpdcli/upmpdcli.mk
+++ b/package/upmpdcli/upmpdcli.mk
@@ -4,11 +4,11 @@
 #
 ################################################################################
 
-UPMPDCLI_VERSION = 0.8.3
+UPMPDCLI_VERSION = 0.8.5
 UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
 UPMPDCLI_LICENSE = GPLv2+
 UPMPDCLI_LICENSE_FILES = COPYING
-UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
+UPMPDCLI_DEPENDENCIES = libmpdclient libupnpp
 
 # Upmpdcli only runs if user upmpdcli exists
 define UPMPDCLI_USERS
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] libupnpp: new package
  2014-10-20 13:50 [Buildroot] [PATCH 1/2] libupnpp: new package Jörg Krause
  2014-10-20 13:50 ` [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5 Jörg Krause
@ 2014-10-20 17:43 ` Yann E. MORIN
  2014-10-20 17:50   ` Yann E. MORIN
  1 sibling, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2014-10-20 17:43 UTC (permalink / raw)
  To: buildroot

J?rg, All,

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
[--SNIP--]
> diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in
> new file mode 100644
> index 0000000..5a79452
> --- /dev/null
> +++ b/package/libupnpp/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_LIBUPNPP
> +	bool "libupnpp"
> +	select BR2_PACKAGE_EXPAT
> +	select BR2_PACKAGE_LIBCURL
> +	select BR2_PACKAGE_LIBUPNP
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_LARGEFILE # libupnp
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Nice! It proves you did quite some testing! :-)

> +	help
> +	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
> +	  upplay.
> +
> +	  http://www.lesbonscomptes.com/upmpdcli/
> +
> +comment "upmpdcli needs a toolchain w/ C++, largefile, threads"

'upmpdcli', really?

Otherwise, looks good. With the above mishap fixed, you can add my:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || \
> +		!BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/libupnpp/libupnpp.mk b/package/libupnpp/libupnpp.mk
> new file mode 100644
> index 0000000..d46de14
> --- /dev/null
> +++ b/package/libupnpp/libupnpp.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# libupnpp
> +#
> +################################################################################
> +
> +LIBUPNPP_VERSION = 0.8.5
> +LIBUPNPP_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
> +LIBUPNPP_LICENSE = GPLv2+
> +LIBUPNPP_LICENSE_FILES = COPYING
> +LIBUPNPP_INSTALL_STAGING = YES
> +LIBUPNPP_DEPENDENCIES = expat libcurl libupnp
> +
> +$(eval $(autotools-package))
> -- 
> 2.1.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5
  2014-10-20 13:50 ` [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5 Jörg Krause
@ 2014-10-20 17:46   ` Yann E. MORIN
  0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-10-20 17:46 UTC (permalink / raw)
  To: buildroot

J?rg, All,

On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:
> New version of upmpdcli now depends on libupnpp, which was ectracted from the
> source and now exists in its own package.
> 
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> ---
>  package/upmpdcli/Config.in   | 8 +++-----
>  package/upmpdcli/upmpdcli.mk | 4 ++--
>  2 files changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index f28c775..84649d2 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -1,12 +1,10 @@
>  config BR2_PACKAGE_UPMPDCLI
>  	bool "upmpdcli"
> -	select BR2_PACKAGE_EXPAT
> -	select BR2_PACKAGE_LIBCURL
> -	select BR2_PACKAGE_LIBUPNP
>  	select BR2_PACKAGE_LIBMPDCLIENT
> +	select BR2_PACKAGE_LIBUPNPP
>  	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_LARGEFILE # libupnp
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
> +	depends on BR2_LARGEFILE # libupnpp -> libupnp
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnpp -> libupnp
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
>  	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto

Ah, the dependencies in libupnpp comes from here...
Are you sure they are still needed in libupnpp?

For this patch:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> diff --git a/package/upmpdcli/upmpdcli.mk b/package/upmpdcli/upmpdcli.mk
> index 547752a..a47c456 100644
> --- a/package/upmpdcli/upmpdcli.mk
> +++ b/package/upmpdcli/upmpdcli.mk
> @@ -4,11 +4,11 @@
>  #
>  ################################################################################
>  
> -UPMPDCLI_VERSION = 0.8.3
> +UPMPDCLI_VERSION = 0.8.5
>  UPMPDCLI_SITE = http://www.lesbonscomptes.com/upmpdcli/downloads
>  UPMPDCLI_LICENSE = GPLv2+
>  UPMPDCLI_LICENSE_FILES = COPYING
> -UPMPDCLI_DEPENDENCIES = expat libcurl libupnp libmpdclient
> +UPMPDCLI_DEPENDENCIES = libmpdclient libupnpp
>  
>  # Upmpdcli only runs if user upmpdcli exists
>  define UPMPDCLI_USERS
> -- 
> 2.1.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] libupnpp: new package
  2014-10-20 17:43 ` [Buildroot] [PATCH 1/2] libupnpp: new package Yann E. MORIN
@ 2014-10-20 17:50   ` Yann E. MORIN
  2014-10-20 21:24     ` Jörg Krause
  0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2014-10-20 17:50 UTC (permalink / raw)
  To: buildroot

J?rg, All,

On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly:
> On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:
> > Signed-off-by: J?rg Krause <jkrause@posteo.de>
> [--SNIP--]
> > diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in
> > new file mode 100644
> > index 0000000..5a79452
> > --- /dev/null
> > +++ b/package/libupnpp/Config.in
> > @@ -0,0 +1,20 @@
> > +config BR2_PACKAGE_LIBUPNPP
> > +	bool "libupnpp"
> > +	select BR2_PACKAGE_EXPAT
> > +	select BR2_PACKAGE_LIBCURL
> > +	select BR2_PACKAGE_LIBUPNP
> > +	depends on BR2_INSTALL_LIBSTDCPP
> > +	depends on BR2_LARGEFILE # libupnp
> > +	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
> > +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
> > +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
> > +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
> 
> Nice! It proves you did quite some testing! :-)

I withdraw that comment: the dependencies were copied as-is from
upmpdcli. Are they still required for libupnpp?

> > +	help
> > +	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
> > +	  upplay.
> > +
> > +	  http://www.lesbonscomptes.com/upmpdcli/
> > +
> > +comment "upmpdcli needs a toolchain w/ C++, largefile, threads"
> 
> 'upmpdcli', really?
> 
> Otherwise, looks good. With the above mishap fixed, you can add my:
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Sorry, I withdraw my rev tag, because of the above. That's what you get
by not reviewing the whole series before replying to a patch...
Sorry... :-(

J"org, that does not mean this is faulty, I just wnat to have an answer
to the above before I can give my rev tag.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/2] libupnpp: new package
  2014-10-20 17:50   ` Yann E. MORIN
@ 2014-10-20 21:24     ` Jörg Krause
  0 siblings, 0 replies; 6+ messages in thread
From: Jörg Krause @ 2014-10-20 21:24 UTC (permalink / raw)
  To: buildroot

Yann, All,

On 10/20/2014 07:50 PM, Yann E. MORIN wrote:
> J?rg, All,
>
> On 2014-10-20 19:43 +0200, Yann E. MORIN spake thusly:
>> On 2014-10-20 15:50 +0200, J?rg Krause spake thusly:
>>> Signed-off-by: J?rg Krause <jkrause@posteo.de>
>> [--SNIP--]
>>> diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in
>>> new file mode 100644
>>> index 0000000..5a79452
>>> --- /dev/null
>>> +++ b/package/libupnpp/Config.in
>>> @@ -0,0 +1,20 @@
>>> +config BR2_PACKAGE_LIBUPNPP
>>> +	bool "libupnpp"
>>> +	select BR2_PACKAGE_EXPAT
>>> +	select BR2_PACKAGE_LIBCURL
>>> +	select BR2_PACKAGE_LIBUPNP
>>> +	depends on BR2_INSTALL_LIBSTDCPP
>>> +	depends on BR2_LARGEFILE # libupnp
>>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp
>>> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2014R1 # Too old gcc
>>> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2013R1 # Ditto
>>> +	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 # Ditto
>> Nice! It proves you did quite some testing! :-)
> I withdraw that comment: the dependencies were copied as-is from
> upmpdcli. Are they still required for libupnpp?

I've checked this. They are still required. gcc 4.3.5 does not support 
C++11 keyword `auto`.

>
>>> +	help
>>> +	  The libupnpp C++ library wraps libupnp for easier use by upmpdcli and
>>> +	  upplay.
>>> +
>>> +	  http://www.lesbonscomptes.com/upmpdcli/
>>> +
>>> +comment "upmpdcli needs a toolchain w/ C++, largefile, threads"
>> 'upmpdcli', really?

Copy & paste error. Fixed!

>>
>> Otherwise, looks good. With the above mishap fixed, you can add my:
>>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Sorry, I withdraw my rev tag, because of the above. That's what you get
> by not reviewing the whole series before replying to a patch...
> Sorry... :-(
>
> J"org, that does not mean this is faulty, I just wnat to have an answer
> to the above before I can give my rev tag.
>

I will submit a fixed patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141020/dfec6f2b/attachment.html>

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-20 21:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 13:50 [Buildroot] [PATCH 1/2] libupnpp: new package Jörg Krause
2014-10-20 13:50 ` [Buildroot] [PATCH 2/2] package/upmpdcli: bump to version 0.8.5 Jörg Krause
2014-10-20 17:46   ` Yann E. MORIN
2014-10-20 17:43 ` [Buildroot] [PATCH 1/2] libupnpp: new package Yann E. MORIN
2014-10-20 17:50   ` Yann E. MORIN
2014-10-20 21:24     ` Jörg Krause

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox