* [Buildroot] [PATCH] eudev: add input group
@ 2014-10-20 20:59 Gustavo Zacarias
2014-10-20 21:18 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2014-10-20 20:59 UTC (permalink / raw)
To: buildroot
It's used by 50-default-udev.rules for input-class devices.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/eudev/eudev.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk
index fd935a7..d29f762 100644
--- a/package/eudev/eudev.mk
+++ b/package/eudev/eudev.mk
@@ -42,4 +42,9 @@ define EUDEV_INSTALL_INIT_SYSV
$(INSTALL) -m 0755 package/eudev/S10udev $(TARGET_DIR)/etc/init.d/S10udev
endef
+# Required by default rules for input devices
+define EUDEV_USERS
+ '' -1 input -1 * - - - input group
+endef
+
$(eval $(autotools-package))
--
2.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] eudev: add input group
2014-10-20 20:59 [Buildroot] [PATCH] eudev: add input group Gustavo Zacarias
@ 2014-10-20 21:18 ` Thomas Petazzoni
2014-10-20 21:24 ` Samuel Martin
2014-10-21 7:58 ` Eric Le Bihan
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-20 21:18 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
> It's used by 50-default-udev.rules for input-class devices.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/eudev/eudev.mk | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
I've seen the same issue a couple of days ago.
Does systemd needs a similar fix?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] eudev: add input group
2014-10-20 21:18 ` Thomas Petazzoni
@ 2014-10-20 21:24 ` Samuel Martin
2014-10-21 7:58 ` Eric Le Bihan
1 sibling, 0 replies; 6+ messages in thread
From: Samuel Martin @ 2014-10-20 21:24 UTC (permalink / raw)
To: buildroot
On Mon, Oct 20, 2014 at 11:18 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Gustavo Zacarias,
>
> On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
>> It's used by 50-default-udev.rules for input-class devices.
>>
>> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
>> ---
>> package/eudev/eudev.mk | 5 +++++
>> 1 file changed, 5 insertions(+)
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I've seen the same issue a couple of days ago.
>
> Does systemd needs a similar fix?
I think so.
It is not that much about systemd, but more about udev rules that
would try to set the ownership to some group that does not exist.
Regards,
--
Samuel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] eudev: add input group
2014-10-20 21:18 ` Thomas Petazzoni
2014-10-20 21:24 ` Samuel Martin
@ 2014-10-21 7:58 ` Eric Le Bihan
2014-10-21 13:15 ` Gustavo Zacarias
1 sibling, 1 reply; 6+ messages in thread
From: Eric Le Bihan @ 2014-10-21 7:58 UTC (permalink / raw)
To: buildroot
Hi!
On Mon, Oct 20, 2014 at 11:18:02PM +0200, Thomas Petazzoni wrote:
> Dear Gustavo Zacarias,
>
> On Mon, 20 Oct 2014 17:59:05 -0300, Gustavo Zacarias wrote:
> > It's used by 50-default-udev.rules for input-class devices.
> >
> > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> > ---
> > package/eudev/eudev.mk | 5 +++++
> > 1 file changed, 5 insertions(+)
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I've seen the same issue a couple of days ago.
>
> Does systemd needs a similar fix?
Yes it does.
In my setup, I modified system/skeleton/etc/group to add "input:x:31:"
I'll send a patch similar to the eudev one.
Best regards
ELB
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] eudev: add input group
2014-10-21 7:58 ` Eric Le Bihan
@ 2014-10-21 13:15 ` Gustavo Zacarias
2014-10-21 16:28 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2014-10-21 13:15 UTC (permalink / raw)
To: buildroot
On 10/21/2014 04:58 AM, Eric Le Bihan wrote:
>> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>> I've seen the same issue a couple of days ago.
>>
>> Does systemd needs a similar fix?
>
> Yes it does.
>
> In my setup, I modified system/skeleton/etc/group to add "input:x:31:"
>
> I'll send a patch similar to the eudev one.
Hold off on applying the patch, mkusers doesn't handle making groups
without users gracefully:
...scripts/mkusers: line 369: [: too many arguments
...scripts/mkusers: line 376: [: too many arguments
...scripts/mkusers: line 400: [: input: integer expression expected
...scripts/mkusers: line 408: [: input: integer expression expected
I can respin adding an input user to match, another option is to handle
the scenario in mkusers.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] eudev: add input group
2014-10-21 13:15 ` Gustavo Zacarias
@ 2014-10-21 16:28 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2014-10-21 16:28 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On 2014-10-21 10:15 -0300, Gustavo Zacarias spake thusly:
> On 10/21/2014 04:58 AM, Eric Le Bihan wrote:
>
> >> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> >>
> >> I've seen the same issue a couple of days ago.
> >>
> >> Does systemd needs a similar fix?
> >
> > Yes it does.
> >
> > In my setup, I modified system/skeleton/etc/group to add "input:x:31:"
> >
> > I'll send a patch similar to the eudev one.
>
> Hold off on applying the patch, mkusers doesn't handle making groups
> without users gracefully:
>
> ...scripts/mkusers: line 369: [: too many arguments
> ...scripts/mkusers: line 376: [: too many arguments
> ...scripts/mkusers: line 400: [: input: integer expression expected
> ...scripts/mkusers: line 408: [: input: integer expression expected
>
> I can respin adding an input user to match, another option is to handle
> the scenario in mkusers.
I can look at handling this in mkusers, certainly.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-21 16:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-20 20:59 [Buildroot] [PATCH] eudev: add input group Gustavo Zacarias
2014-10-20 21:18 ` Thomas Petazzoni
2014-10-20 21:24 ` Samuel Martin
2014-10-21 7:58 ` Eric Le Bihan
2014-10-21 13:15 ` Gustavo Zacarias
2014-10-21 16:28 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox