* [Buildroot] [PATCH] tftpd: Install TFTP client as well
@ 2014-10-23 11:13 Kelvin Cheung
2014-10-23 11:24 ` Baruch Siach
2014-10-23 20:13 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Kelvin Cheung @ 2014-10-23 11:13 UTC (permalink / raw)
To: buildroot
This patch installs TFTP client as well and overrides
BusyBox implementations if BusyBox is enabled.
Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
---
package/tftpd/tftpd.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/tftpd/tftpd.mk b/package/tftpd/tftpd.mk
index c8457db..74e7cfa 100644
--- a/package/tftpd/tftpd.mk
+++ b/package/tftpd/tftpd.mk
@@ -13,7 +13,13 @@ ifneq ($(BR2_INET_IPV6),y)
TFTPD_CONF_OPTS += --without-ipv6
endif
+# Override BusyBox implementations if BusyBox is enabled.
+ifeq ($(BR2_PACKAGE_BUSYBOX),y)
+SYSKLOGD_DEPENDENCIES = busybox
+endif
+
define TFTPD_INSTALL_TARGET_CMDS
+ $(INSTALL) -D $(@D)/tftp/tftp $(TARGET_DIR)/usr/bin/tftp
$(INSTALL) -D $(@D)/tftpd/tftpd $(TARGET_DIR)/usr/sbin/tftpd
$(INSTALL) -D package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d/
endef
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] tftpd: Install TFTP client as well
2014-10-23 11:13 [Buildroot] [PATCH] tftpd: Install TFTP client as well Kelvin Cheung
@ 2014-10-23 11:24 ` Baruch Siach
2014-10-23 20:13 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-10-23 11:24 UTC (permalink / raw)
To: buildroot
Hi Kelvin,
On Thu, Oct 23, 2014 at 07:13:24PM +0800, Kelvin Cheung wrote:
> This patch installs TFTP client as well and overrides
> BusyBox implementations if BusyBox is enabled.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
> package/tftpd/tftpd.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/tftpd/tftpd.mk b/package/tftpd/tftpd.mk
> index c8457db..74e7cfa 100644
> --- a/package/tftpd/tftpd.mk
> +++ b/package/tftpd/tftpd.mk
> @@ -13,7 +13,13 @@ ifneq ($(BR2_INET_IPV6),y)
> TFTPD_CONF_OPTS += --without-ipv6
> endif
>
> +# Override BusyBox implementations if BusyBox is enabled.
> +ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> +SYSKLOGD_DEPENDENCIES = busybox
SYSKLOGD? Are you sure?
baruch
> +endif
> +
> define TFTPD_INSTALL_TARGET_CMDS
> + $(INSTALL) -D $(@D)/tftp/tftp $(TARGET_DIR)/usr/bin/tftp
> $(INSTALL) -D $(@D)/tftpd/tftpd $(TARGET_DIR)/usr/sbin/tftpd
> $(INSTALL) -D package/tftpd/S80tftpd-hpa $(TARGET_DIR)/etc/init.d/
> endef
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] tftpd: Install TFTP client as well
2014-10-23 11:13 [Buildroot] [PATCH] tftpd: Install TFTP client as well Kelvin Cheung
2014-10-23 11:24 ` Baruch Siach
@ 2014-10-23 20:13 ` Thomas Petazzoni
2014-10-24 2:36 ` Kelvin Cheung
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2014-10-23 20:13 UTC (permalink / raw)
To: buildroot
Dear Kelvin Cheung,
On Thu, 23 Oct 2014 19:13:24 +0800, Kelvin Cheung wrote:
> This patch installs TFTP client as well and overrides
> BusyBox implementations if BusyBox is enabled.
>
> Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> ---
> package/tftpd/tftpd.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
Thanks, applied, after fixing the SYSKLOGD typo noticed by Baruch.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] tftpd: Install TFTP client as well
2014-10-23 20:13 ` Thomas Petazzoni
@ 2014-10-24 2:36 ` Kelvin Cheung
0 siblings, 0 replies; 4+ messages in thread
From: Kelvin Cheung @ 2014-10-24 2:36 UTC (permalink / raw)
To: buildroot
Sorry for my negligence.
Thanks Thomas!
2014-10-24 4:13 GMT+08:00 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com>:
> Dear Kelvin Cheung,
>
> On Thu, 23 Oct 2014 19:13:24 +0800, Kelvin Cheung wrote:
> > This patch installs TFTP client as well and overrides
> > BusyBox implementations if BusyBox is enabled.
> >
> > Signed-off-by: Kelvin Cheung <keguang.zhang@gmail.com>
> > ---
> > package/tftpd/tftpd.mk | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> Thanks, applied, after fixing the SYSKLOGD typo noticed by Baruch.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
>
--
Best Regards!
Kelvin Cheung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141024/20ebf3b7/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-24 2:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 11:13 [Buildroot] [PATCH] tftpd: Install TFTP client as well Kelvin Cheung
2014-10-23 11:24 ` Baruch Siach
2014-10-23 20:13 ` Thomas Petazzoni
2014-10-24 2:36 ` Kelvin Cheung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox