* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
@ 2014-10-19 18:59 Bernd Kuhls
2014-10-19 19:16 ` Baruch Siach
2014-10-26 15:42 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2014-10-19 18:59 UTC (permalink / raw)
To: buildroot
Error occured with an allyespackageconfig setup:
In file included from print.c:19:0:
print.c: In function 'ipset_print_ip':
../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
^
print.c:273:21: error: called from here [-Werror=inline]
if (ipset_data_test(data, cidropt)) {
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/ipset/ipset.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk
index d3dbc67..b1518f4 100644
--- a/package/ipset/ipset.mk
+++ b/package/ipset/ipset.mk
@@ -13,4 +13,6 @@ IPSET_AUTORECONF = YES
IPSET_LICENSE = GPLv2
IPSET_LICENSE_FILES = COPYING
+IPSET_CONF_ENV = ax_cv_cflags_gcc_option__Winline=""
+
$(eval $(autotools-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
2014-10-19 18:59 [Buildroot] [PATCH 1/1] package/ipset: Fix compile error Bernd Kuhls
@ 2014-10-19 19:16 ` Baruch Siach
2014-10-26 15:42 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2014-10-19 19:16 UTC (permalink / raw)
To: buildroot
Hi Bernd,
On Sun, Oct 19, 2014 at 08:59:07PM +0200, Bernd Kuhls wrote:
> Error occured with an allyespackageconfig setup:
>
> In file included from print.c:19:0:
> print.c: In function 'ipset_print_ip':
> ../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
> ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
> ^
> print.c:273:21: error: called from here [-Werror=inline]
> if (ipset_data_test(data, cidropt)) {
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/ipset/ipset.mk | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk
> index d3dbc67..b1518f4 100644
> --- a/package/ipset/ipset.mk
> +++ b/package/ipset/ipset.mk
> @@ -13,4 +13,6 @@ IPSET_AUTORECONF = YES
> IPSET_LICENSE = GPLv2
> IPSET_LICENSE_FILES = COPYING
>
> +IPSET_CONF_ENV = ax_cv_cflags_gcc_option__Winline=""
> +
> $(eval $(autotools-package))
Instead of squashing each type of compiler warning, why not remove -Werror
entirely? It's not that useful when you only want to build the package.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
2014-10-19 18:59 [Buildroot] [PATCH 1/1] package/ipset: Fix compile error Bernd Kuhls
2014-10-19 19:16 ` Baruch Siach
@ 2014-10-26 15:42 ` Thomas Petazzoni
2014-10-26 16:00 ` Baruch Siach
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-26 15:42 UTC (permalink / raw)
To: buildroot
Dear Bernd Kuhls,
On Sun, 19 Oct 2014 20:59:07 +0200, Bernd Kuhls wrote:
> Error occured with an allyespackageconfig setup:
>
> In file included from print.c:19:0:
> print.c: In function 'ipset_print_ip':
> ../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
> ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
> ^
> print.c:273:21: error: called from here [-Werror=inline]
> if (ipset_data_test(data, cidropt)) {
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/ipset/ipset.mk | 2 ++
> 1 file changed, 2 insertions(+)
To fix the same problem, I've applied a slightly different fix, that
simply removes -Werror altogether.
See
http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
2014-10-26 15:42 ` Thomas Petazzoni
@ 2014-10-26 16:00 ` Baruch Siach
2014-10-26 16:52 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2014-10-26 16:00 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Sun, Oct 26, 2014 at 04:42:54PM +0100, Thomas Petazzoni wrote:
> Dear Bernd Kuhls,
>
> On Sun, 19 Oct 2014 20:59:07 +0200, Bernd Kuhls wrote:
> > Error occured with an allyespackageconfig setup:
> >
> > In file included from print.c:19:0:
> > print.c: In function 'ipset_print_ip':
> > ../include/libipset/data.h:150:1: error: inlining failed in call to 'ipset_data_test': call is unlikely and code size would grow [-Werror=inline]
> > ipset_data_test(const struct ipset_data *data, enum ipset_opt opt)
> > ^
> > print.c:273:21: error: called from here [-Werror=inline]
> > if (ipset_data_test(data, cidropt)) {
> >
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> > ---
> > package/ipset/ipset.mk | 2 ++
> > 1 file changed, 2 insertions(+)
>
> To fix the same problem, I've applied a slightly different fix, that
> simply removes -Werror altogether.
>
> See
> http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.
The presence of /usr/local/include directory in the include path still needs
to be fixes by itself. See
http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
This comes from the AM_CPPFLAGS variable that is set in Make_global.am.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
2014-10-26 16:00 ` Baruch Siach
@ 2014-10-26 16:52 ` Thomas Petazzoni
2014-10-26 19:17 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-26 16:52 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Sun, 26 Oct 2014 18:00:29 +0200, Baruch Siach wrote:
> > To fix the same problem, I've applied a slightly different fix, that
> > simply removes -Werror altogether.
> >
> > See
> > http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.
>
> The presence of /usr/local/include directory in the include path still needs
> to be fixes by itself. See
> http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
> This comes from the AM_CPPFLAGS variable that is set in Make_global.am.
Ah, right. Could you send a patch for this?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/ipset: Fix compile error
2014-10-26 16:52 ` Thomas Petazzoni
@ 2014-10-26 19:17 ` Baruch Siach
0 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2014-10-26 19:17 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Sun, Oct 26, 2014 at 05:52:20PM +0100, Thomas Petazzoni wrote:
> On Sun, 26 Oct 2014 18:00:29 +0200, Baruch Siach wrote:
> > > To fix the same problem, I've applied a slightly different fix, that
> > > simply removes -Werror altogether.
> > >
> > > See
> > > http://git.buildroot.net/buildroot/commit/?id=a923b44112aa3bfdb42b12cc1bd2712a263c1a0c.
> >
> > The presence of /usr/local/include directory in the include path still needs
> > to be fixes by itself. See
> > http://autobuild.buildroot.net/results/4f5/4f55c2415281c6204500efe28fe9e24c8ef73863/build-end.log.
> > This comes from the AM_CPPFLAGS variable that is set in Make_global.am.
>
> Ah, right. Could you send a patch for this?
I hope I'll have some time for this later this week.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-26 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-19 18:59 [Buildroot] [PATCH 1/1] package/ipset: Fix compile error Bernd Kuhls
2014-10-19 19:16 ` Baruch Siach
2014-10-26 15:42 ` Thomas Petazzoni
2014-10-26 16:00 ` Baruch Siach
2014-10-26 16:52 ` Thomas Petazzoni
2014-10-26 19:17 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox