[Buildroot] [PATCH 1/1] libgtk3: fix undefined reference to get_xkb()

[Buildroot] [PATCH 1/1] libgtk3: fix undefined reference to get_xkb()

[Eric Le Bihan]

When configuring Gtk+ with --disable-xkb, the build fails because of an
undefined reference to get_xkb().

This issue as been reported upstream [1]. This patch fixes it.

Fixes: 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
Fixes: 0c3f1df92481852622445478d2239371fc818f41

[1] https://bugzilla.gnome.org/show_bug.cgi?id=739070

Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
---
 ...3-0004-Fix-undefined-reference-to-get_xkb.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch

diff --git a/package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch b/package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch
new file mode 100644
index 0000000..c2f4b4f
--- /dev/null
+++ b/package/libgtk3/libgtk3-0004-Fix-undefined-reference-to-get_xkb.patch
@@ -0,0 +1,33 @@
+From b64a04250b1f35923434158beb6ddb5726b41eac Mon Sep 17 00:00:00 2001
+From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
+Date: Mon, 27 Oct 2014 10:34:38 +0100
+Subject: [PATCH 1/1] Fix undefined reference to get_xkb()
+
+When configuring Gtk+ with --disable-xkb, the build fails because of an
+undefined reference to get_xkb().
+
+This patch fixes this issue.
+
+Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr>
+---
+ gdk/x11/gdkkeys-x11.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/gdk/x11/gdkkeys-x11.c b/gdk/x11/gdkkeys-x11.c
+index c45a971..6a5481b 100644
+--- a/gdk/x11/gdkkeys-x11.c
++++ b/gdk/x11/gdkkeys-x11.c
+@@ -1498,8 +1498,10 @@ gdk_x11_keymap_map_virtual_modifiers (GdkKeymap       *keymap,
+   int i, j;
+   gboolean retval;
+ 
++#ifdef HAVE_XKB
+   if (KEYMAP_USE_XKB (keymap))
+     get_xkb (keymap_x11);
++#endif
+ 
+   retval = TRUE;
+ 
+-- 
+1.9.1
+
-- 
1.9.1

[Buildroot] [PATCH 1/1] libgtk3: fix undefined reference to get_xkb()

[Thomas Petazzoni]

Dear Eric Le Bihan,

On Mon, 27 Oct 2014 12:03:02 +0100, Eric Le Bihan wrote:
> When configuring Gtk+ with --disable-xkb, the build fails because of an
> undefined reference to get_xkb().
> 
> This issue as been reported upstream [1]. This patch fixes it.
> 
> Fixes: 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
> Fixes: 0c3f1df92481852622445478d2239371fc818f41

Are these commit IDs, or autobuilder result IDs? If the latter, then
it should be full URL to the autobuilder result.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] libgtk3: fix undefined reference to get_xkb()

[Eric Le Bihan]

Hi!

On Mon, Oct 27, 2014 at 01:41:37PM +0100, Thomas Petazzoni wrote:
> Dear Eric Le Bihan,
>
> On Mon, 27 Oct 2014 12:03:02 +0100, Eric Le Bihan wrote:
> > When configuring Gtk+ with --disable-xkb, the build fails because of an
> > undefined reference to get_xkb().
> >
> > This issue as been reported upstream [1]. This patch fixes it.
> >
> > Fixes: 513d79b97bb8ad0e5cd431c47c706b5ec87a9882
> > Fixes: 0c3f1df92481852622445478d2239371fc818f41
>
> Are these commit IDs, or autobuilder result IDs? If the latter, then
> it should be full URL to the autobuilder result.

D'Oh! I will a new version with the correct URLs.

Best regards
ELB