Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL
@ 2014-10-29 13:33 Baruch Siach
  2014-10-30  8:20 ` Arnout Vandecappelle
  2014-10-30 20:52 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2014-10-29 13:33 UTC (permalink / raw)
  To: buildroot

Also remove the comment attributing threads dependency to alsa-lib, since
shairport-sync itself uses pthreads.

Fixes:
http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/shairport-sync/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/shairport-sync/Config.in b/package/shairport-sync/Config.in
index ce3106186fb3..c1d81a7e2a54 100644
--- a/package/shairport-sync/Config.in
+++ b/package/shairport-sync/Config.in
@@ -1,7 +1,7 @@
 config BR2_PACKAGE_SHAIRPORT_SYNC
 	bool "shairport-sync"
 	depends on BR2_USE_MMU # libdaemon
-	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa_lib
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_ALSA_LIB
 	select BR2_PACKAGE_ALSA_LIB_MIXER
 	select BR2_PACKAGE_LIBDAEMON
@@ -33,6 +33,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
 
 endif
 
-comment "shairport-sync needs a toolchain w/ threads"
+comment "shairport-sync needs a toolchain w/ NPTL"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
-- 
2.1.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL
  2014-10-29 13:33 [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL Baruch Siach
@ 2014-10-30  8:20 ` Arnout Vandecappelle
  2014-10-30 20:52 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2014-10-30  8:20 UTC (permalink / raw)
  To: buildroot

On 29/10/14 14:33, Baruch Siach wrote:
> Also remove the comment attributing threads dependency to alsa-lib, since
> shairport-sync itself uses pthreads.
> 
> Fixes:
> http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  package/shairport-sync/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/shairport-sync/Config.in b/package/shairport-sync/Config.in
> index ce3106186fb3..c1d81a7e2a54 100644
> --- a/package/shairport-sync/Config.in
> +++ b/package/shairport-sync/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_SHAIRPORT_SYNC
>  	bool "shairport-sync"
>  	depends on BR2_USE_MMU # libdaemon
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa_lib
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	select BR2_PACKAGE_ALSA_LIB
>  	select BR2_PACKAGE_ALSA_LIB_MIXER
>  	select BR2_PACKAGE_LIBDAEMON
> @@ -33,6 +33,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
>  
>  endif
>  
> -comment "shairport-sync needs a toolchain w/ threads"
> +comment "shairport-sync needs a toolchain w/ NPTL"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL
  2014-10-29 13:33 [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL Baruch Siach
  2014-10-30  8:20 ` Arnout Vandecappelle
@ 2014-10-30 20:52 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-10-30 20:52 UTC (permalink / raw)
  To: buildroot

Dear Baruch Siach,

On Wed, 29 Oct 2014 15:33:40 +0200, Baruch Siach wrote:
> Also remove the comment attributing threads dependency to alsa-lib, since
> shairport-sync itself uses pthreads.
> 
> Fixes:
> http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/shairport-sync/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks. And thanks to Arnout for the review.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-30 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-29 13:33 [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL Baruch Siach
2014-10-30  8:20 ` Arnout Vandecappelle
2014-10-30 20:52 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox