* [Buildroot] [PATCH v2] schifra: fix build of examples and add hash
@ 2014-10-28 10:17 Arnout Vandecappelle
2014-10-28 17:55 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2014-10-28 10:17 UTC (permalink / raw)
To: buildroot
The OPTIONS argument passed to make had a redundant -o option, leading
to:
g++ -pipe -Os -o -o schifra_reed_solomon_speed_evaluation schifra_reed_solomon_speed_evaluation.cpp -lstdc++ -lm
arm-linux-musleabi-g++: error: schifra_reed_solomon_speed_evaluation: No such file or directory
Fixes:
http://autobuild.buildroot.net/results/2143b4f6f22f50ccb4af36732cc7d9304daa3ff9/
This error didn't occur before because upstream has silently updated
the tarball. To protect against this in the future, a hash is added as
well.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/schifra/schifra.hash | 3 +++
package/schifra/schifra.mk | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
create mode 100644 package/schifra/schifra.hash
diff --git a/package/schifra/schifra.hash b/package/schifra/schifra.hash
new file mode 100644
index 0000000..7f8e6c0
--- /dev/null
+++ b/package/schifra/schifra.hash
@@ -0,0 +1,3 @@
+# Calculated locally after download
+# Upstream doesn't store a version and tarball may change unexpectedly!
+sha256 3e60478cf024d87735d1cc1460aa2176c449e6c7f76914eefda25d3b20d22522 schifra.tgz
diff --git a/package/schifra/schifra.mk b/package/schifra/schifra.mk
index 96387d3..e55bf02 100644
--- a/package/schifra/schifra.mk
+++ b/package/schifra/schifra.mk
@@ -12,7 +12,7 @@ SCHIFRA_LICENSE = schifra license
SCHIFRA_LICENSE_FILES = schifra_license.txt
SCHIFRA_MAKE_OPTS = COMPILER="$(TARGET_CXX)" \
- OPTIONS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS) -o"
+ OPTIONS="$(TARGET_CFLAGS) $(TARGET_LDFLAGS)"
# The examples are the only buildable artefacts.
ifeq ($(BR2_PACKAGE_SCHIFRA_EXAMPLES),y)
--
2.1.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] schifra: fix build of examples and add hash
2014-10-28 10:17 [Buildroot] [PATCH v2] schifra: fix build of examples and add hash Arnout Vandecappelle
@ 2014-10-28 17:55 ` Thomas Petazzoni
2014-10-31 11:01 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-28 17:55 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle (Essensium/Mind),
On Tue, 28 Oct 2014 11:17:41 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> The OPTIONS argument passed to make had a redundant -o option, leading
> to:
>
> g++ -pipe -Os -o -o schifra_reed_solomon_speed_evaluation schifra_reed_solomon_speed_evaluation.cpp -lstdc++ -lm
> arm-linux-musleabi-g++: error: schifra_reed_solomon_speed_evaluation: No such file or directory
>
> Fixes:
> http://autobuild.buildroot.net/results/2143b4f6f22f50ccb4af36732cc7d9304daa3ff9/
>
> This error didn't occur before because upstream has silently updated
> the tarball. To protect against this in the future, a hash is added as
> well.
>
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/schifra/schifra.hash | 3 +++
> package/schifra/schifra.mk | 2 +-
> 2 files changed, 4 insertions(+), 1 deletion(-)
> create mode 100644 package/schifra/schifra.hash
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] schifra: fix build of examples and add hash
2014-10-28 17:55 ` Thomas Petazzoni
@ 2014-10-31 11:01 ` Peter Korsgaard
2014-10-31 11:12 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2014-10-31 11:01 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Hi,
>> The OPTIONS argument passed to make had a redundant -o option, leading
>> to:
>>
>> g++ -pipe -Os -o -o schifra_reed_solomon_speed_evaluation schifra_reed_solomon_speed_evaluation.cpp -lstdc++ -lm
>> arm-linux-musleabi-g++: error: schifra_reed_solomon_speed_evaluation: No such file or directory
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/2143b4f6f22f50ccb4af36732cc7d9304daa3ff9/
>>
>> This error didn't occur before because upstream has silently updated
>> the tarball. To protect against this in the future, a hash is added as
>> well.
>>
>> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>> ---
>> package/schifra/schifra.hash | 3 +++
>> package/schifra/schifra.mk | 2 +-
>> 2 files changed, 4 insertions(+), 1 deletion(-)
>> create mode 100644 package/schifra/schifra.hash
> Applied, thanks.
It seems like it changed AGAIN:
http://autobuild.buildroot.net/results/b62/b624c7f9fd7b431e97599e4b9b5e2a87fcb1a0a9/build-end.log
This is not workable. Nobody will be able to seriously use schifra in a
project like this, and E.G. 2014.08 and earlier releases are broken.
What do we do?
- Get upstream to add a version number to the tarball and bump the
version whenever it changes
- Put a known good version on sources.buildroot.net and use that
- Drop the package
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] schifra: fix build of examples and add hash
2014-10-31 11:01 ` Peter Korsgaard
@ 2014-10-31 11:12 ` Thomas Petazzoni
2014-10-31 13:36 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2014-10-31 11:12 UTC (permalink / raw)
To: buildroot
Dear Peter Korsgaard,
On Fri, 31 Oct 2014 12:01:32 +0100, Peter Korsgaard wrote:
> It seems like it changed AGAIN:
>
> http://autobuild.buildroot.net/results/b62/b624c7f9fd7b431e97599e4b9b5e2a87fcb1a0a9/build-end.log
>
> This is not workable. Nobody will be able to seriously use schifra in a
> project like this, and E.G. 2014.08 and earlier releases are broken.
Are we sure it changed again? Isn't the build error above caused by the
fact that the tarball in the cache was wrong, and now that we've added
the hash, the individual autobuilder instances are progressively
realizing that the tarball they have in their cache is wrong.
> What do we do?
>
> - Get upstream to add a version number to the tarball and bump the
> version whenever it changes
>
> - Put a known good version on sources.buildroot.net and use that
>
> - Drop the package
I personally don't care about schifra. It was added back in August 2012
by Simon Dawson, but unfortunately Simon is no longer contributing to
Buildroot.
Maybe we should first report the issue upstream?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2] schifra: fix build of examples and add hash
2014-10-31 11:12 ` Thomas Petazzoni
@ 2014-10-31 13:36 ` Peter Korsgaard
2014-10-31 14:01 ` Thomas Petazzoni
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2014-10-31 13:36 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> Dear Peter Korsgaard,
> On Fri, 31 Oct 2014 12:01:32 +0100, Peter Korsgaard wrote:
>> It seems like it changed AGAIN:
>>
>> http://autobuild.buildroot.net/results/b62/b624c7f9fd7b431e97599e4b9b5e2a87fcb1a0a9/build-end.log
>>
>> This is not workable. Nobody will be able to seriously use schifra in a
>> project like this, and E.G. 2014.08 and earlier releases are broken.
> Are we sure it changed again? Isn't the build error above caused by the
> fact that the tarball in the cache was wrong, and now that we've added
> the hash, the individual autobuilder instances are progressively
> realizing that the tarball they have in their cache is wrong.
Yes, I just tried downloading it here:
wget -q http://www.schifra.com/downloads/schifra.tgz
md5sum schifra.tgz
3b0aa73ed1ae1e2491e1a860a4f49f1b schifra.tgz
Which doesn't match the .hash file.
>> - Get upstream to add a version number to the tarball and bump the
>> version whenever it changes
>>
>> - Put a known good version on sources.buildroot.net and use that
>>
>> - Drop the package
> I personally don't care about schifra. It was added back in August 2012
> by Simon Dawson, but unfortunately Simon is no longer contributing to
> Buildroot.
Indeed, I'm of the same opinion.
> Maybe we should first report the issue upstream?
I'll send a mail, and if it doesn't get resolved soon (or if somebody
steps up to say they need it), then I'll simply drop the package.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-31 14:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28 10:17 [Buildroot] [PATCH v2] schifra: fix build of examples and add hash Arnout Vandecappelle
2014-10-28 17:55 ` Thomas Petazzoni
2014-10-31 11:01 ` Peter Korsgaard
2014-10-31 11:12 ` Thomas Petazzoni
2014-10-31 13:36 ` Peter Korsgaard
2014-10-31 14:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox