Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: respect top-level TARGET_CFLAGS
Date: Thu, 6 Nov 2014 13:51:20 +0200	[thread overview]
Message-ID: <20141106115120.GG2234@tarshish> (raw)
In-Reply-To: <1415274442-24547-1-git-send-email-abrodkin@synopsys.com>

Hi Alexey,

On Thu, Nov 06, 2014 at 02:47:22PM +0300, Alexey Brodkin wrote:
> When BR2_TARGET_OPTIMIZATION is used (with some specific compiler flags)
> it's expected that ALL target binaries will be built with specified options.
> 
> Currently uClibc is built with its own set of options.
> This change allows passing additional flags to uclibc build system.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> 
> Cc: Anton Kolesov <akolesov@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: Peter Korsgaard <peter@korsgaard.com>
> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Have you actually CCed all these addresses? I only see Thomas in the Cc: 
header, besides you.

baruch

> ---
>  package/uclibc/uclibc.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/uclibc/uclibc.mk b/package/uclibc/uclibc.mk
> index ce416dd..419a4d1 100644
> --- a/package/uclibc/uclibc.mk
> +++ b/package/uclibc/uclibc.mk
> @@ -24,6 +24,8 @@ endif
>  
>  UCLIBC_INSTALL_STAGING = YES
>  
> +UCLIBC_EXTRA_CFLAGS = $(TARGET_CFLAGS)
> +
>  # uclibc is part of the toolchain so disable the toolchain dependency
>  UCLIBC_ADD_TOOLCHAIN_DEPENDENCY = NO

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-11-06 11:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 11:47 [Buildroot] [PATCH] uclibc: respect top-level TARGET_CFLAGS Alexey Brodkin
2014-11-06 11:51 ` Baruch Siach [this message]
2014-11-06 11:59   ` Alexey Brodkin
2014-11-06 12:03     ` Baruch Siach
2014-11-06 17:25       ` Thomas Petazzoni
2014-11-06 12:49 ` Gustavo Zacarias
2014-11-06 13:04   ` Alexey Brodkin
2014-11-06 13:18     ` Gustavo Zacarias
2014-11-11 15:32       ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141106115120.GG2234@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox