From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] uclibc: respect top-level TARGET_CFLAGS
Date: Thu, 06 Nov 2014 09:49:35 -0300 [thread overview]
Message-ID: <545B6E5F.5090406@zacarias.com.ar> (raw)
In-Reply-To: <1415274442-24547-1-git-send-email-abrodkin@synopsys.com>
On 11/06/2014 08:47 AM, Alexey Brodkin wrote:
> When BR2_TARGET_OPTIMIZATION is used (with some specific compiler flags)
> it's expected that ALL target binaries will be built with specified options.
>
> Currently uClibc is built with its own set of options.
> This change allows passing additional flags to uclibc build system.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
This was rejected before:
https://bugs.busybox.net/show_bug.cgi?id=5294
And i'm back to my original question, what's the specific need for this?
Even for eglibc/glibc we force -O2 for example.
If there's a very valid (like, it breaks!) reason for this we can look
for a way to address it, but as-is i say NAK.
If you look at uClibc's Rules.mak file you'll see there are lots of
OPTIMIZATION/CPU_CFLAGS (and other) conditionals that could be undone by
this and lead to unexpected results.
Regards.
next prev parent reply other threads:[~2014-11-06 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 11:47 [Buildroot] [PATCH] uclibc: respect top-level TARGET_CFLAGS Alexey Brodkin
2014-11-06 11:51 ` Baruch Siach
2014-11-06 11:59 ` Alexey Brodkin
2014-11-06 12:03 ` Baruch Siach
2014-11-06 17:25 ` Thomas Petazzoni
2014-11-06 12:49 ` Gustavo Zacarias [this message]
2014-11-06 13:04 ` Alexey Brodkin
2014-11-06 13:18 ` Gustavo Zacarias
2014-11-11 15:32 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B6E5F.5090406@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox