[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Peter Korsgaard]

commit: http://git.buildroot.net/buildroot/commit/?id=e07c705e699b876dcc77be06d734b83e1bd31084
branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master

The qt5 build system currently unconditionally builds and installs into
staging Qt5PrintSupport if widgets are enabled, so ensure it also gets
installed into target to make sure we don't end up with dynamic linker
errors at runtime:

test: error while loading shared libraries: libQt5PrintSupport.so.5: cannot
open shared object file: No such file or directory

From src.pro:

!contains(QT_CONFIG, no-gui) {
        ..
        !wince*:!winrt {
            SUBDIRS += src_printsupport
            src_plugins.depends += src_printsupport
        }

}

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/qt5/qt5base/Config.in |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
index f4eedec..e5679be 100644
--- a/package/qt5/qt5base/Config.in
+++ b/package/qt5/qt5base/Config.in
@@ -209,10 +209,8 @@ config BR2_PACKAGE_QT5BASE_DEFAULT_QPA
 	  different platform at runtime with the -platform option.
 
 config BR2_PACKAGE_QT5BASE_PRINTSUPPORT
-	bool "print support module"
-	select BR2_PACKAGE_QT5BASE_WIDGETS
-	help
-	  This option enables the Qt5PrintSupport
+	depends on BR2_PACKAGE_QT5BASE_WIDGETS
+	def_bool y
 
 config BR2_PACKAGE_QT5BASE_FONTCONFIG
 	bool "fontconfig support"

[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Thu, 13 Nov 2014 15:48:57 +0100, Peter Korsgaard wrote:
> commit: http://git.buildroot.net/buildroot/commit/?id=e07c705e699b876dcc77be06d734b83e1bd31084
> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> 
> The qt5 build system currently unconditionally builds and installs into
> staging Qt5PrintSupport if widgets are enabled, so ensure it also gets
> installed into target to make sure we don't end up with dynamic linker
> errors at runtime:
> 
> test: error while loading shared libraries: libQt5PrintSupport.so.5: cannot
> open shared object file: No such file or directory
> 
> From src.pro:
> 
> !contains(QT_CONFIG, no-gui) {
>         ..
>         !wince*:!winrt {
>             SUBDIRS += src_printsupport
>             src_plugins.depends += src_printsupport
>         }
> 
> }
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/qt5/qt5base/Config.in |    6 ++----
>  1 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/package/qt5/qt5base/Config.in b/package/qt5/qt5base/Config.in
> index f4eedec..e5679be 100644
> --- a/package/qt5/qt5base/Config.in
> +++ b/package/qt5/qt5base/Config.in
> @@ -209,10 +209,8 @@ config BR2_PACKAGE_QT5BASE_DEFAULT_QPA
>  	  different platform at runtime with the -platform option.
>  
>  config BR2_PACKAGE_QT5BASE_PRINTSUPPORT
> -	bool "print support module"
> -	select BR2_PACKAGE_QT5BASE_WIDGETS
> -	help
> -	  This option enables the Qt5PrintSupport
> +	depends on BR2_PACKAGE_QT5BASE_WIDGETS
> +	def_bool y

So why have a Config.in option for this in the first place?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 >> config BR2_PACKAGE_QT5BASE_PRINTSUPPORT
 >> -	bool "print support module"
 >> -	select BR2_PACKAGE_QT5BASE_WIDGETS
 >> -	help
 >> -	  This option enables the Qt5PrintSupport
 >> +	depends on BR2_PACKAGE_QT5BASE_WIDGETS
 >> +	def_bool y

 > So why have a Config.in option for this in the first place?

Just because I wanted to make as minimal as possible a change now that
we're past -rc1. I don't follow qt5 development, but presumably this
used to be user settable and could become so again in future qt5
releases.

-- 
Bye, Peter Korsgaard 

[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Thomas Petazzoni]

Dear Peter Korsgaard,

On Thu, 13 Nov 2014 16:17:08 +0100, Peter Korsgaard wrote:

>  > So why have a Config.in option for this in the first place?
> 
> Just because I wanted to make as minimal as possible a change now that
> we're past -rc1.

That makes sense.

> I don't follow qt5 development, but presumably this
> used to be user settable and could become so again in future qt5
> releases.

That however seems like a pretty weak argument :-) Do we keep or add
options just because they may hypothetically be useful in the future?

But OK, the first argument is good enough. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [git commit] qt5base: unconditionally install Qt5printSupport if widgets are enabled

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Dear Peter Korsgaard,
 > On Thu, 13 Nov 2014 16:17:08 +0100, Peter Korsgaard wrote:

 >> > So why have a Config.in option for this in the first place?
 >> 
 >> Just because I wanted to make as minimal as possible a change now that
 >> we're past -rc1.

 > That makes sense.

Good ;)

 >> I don't follow qt5 development, but presumably this
 >> used to be user settable and could become so again in future qt5
 >> releases.

 > That however seems like a pretty weak argument :-) Do we keep or add
 > options just because they may hypothetically be useful in the future?

I agree it is a bit weak ;) I basically don't really know much about
qt5, so I wanted as minimal as possible a change.

I just noticed that we have the same issue with the network, sql, xml
and test modules, so I will make a similar change for those as well.

I find it quite a pity that qt5base apparently isn't very configurable
after all :/

-- 
Bye, Peter Korsgaard