Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] tzdata.mk
@ 2014-11-04  7:10 Martin Dorwig
  2014-11-18 18:29 ` Yann E. MORIN
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Dorwig @ 2014-11-04  7:10 UTC (permalink / raw)
  To: buildroot

Hello,
i am using buildroot-2014.08 and
maybe i found a bug inpackage/tzdata/ tzdata.mk

$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share
cp -a $(HOST_DIR)/usr/share/zoneinfo $(TARGET_DIR)/usr/share/zoneinfo

if $(TARGET_DIR)/usr/share/zoneinfo already exist, cp will create 
$(TARGET_DIR)/usr/share/zoneinfo/zoneinfo and copy the files there

i suggest
$(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share/zoneinfo
cp -a $(HOST_DIR)/usr/share/zoneinfo/* $(TARGET_DIR)/usr/share/zoneinfo

regards 
Martin

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [Buildroot] tzdata.mk
  2014-11-04  7:10 [Buildroot] tzdata.mk Martin Dorwig
@ 2014-11-18 18:29 ` Yann E. MORIN
  0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2014-11-18 18:29 UTC (permalink / raw)
  To: buildroot

Martin, All,

On 2014-11-04 08:10 +0100, Martin Dorwig spake thusly:
> i am using buildroot-2014.08 and
> maybe i found a bug inpackage/tzdata/ tzdata.mk
> 
> $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share
> cp -a $(HOST_DIR)/usr/share/zoneinfo $(TARGET_DIR)/usr/share/zoneinfo
> 
> if $(TARGET_DIR)/usr/share/zoneinfo already exist, cp will create 
> $(TARGET_DIR)/usr/share/zoneinfo/zoneinfo and copy the files there

Indeed.

> i suggest
> $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/share/zoneinfo
> cp -a $(HOST_DIR)/usr/share/zoneinfo/* $(TARGET_DIR)/usr/share/zoneinfo

That looks sensible, yes. I'll take care of doing the patch.

Thanks for the report!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-11-18 18:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04  7:10 [Buildroot] tzdata.mk Martin Dorwig
2014-11-18 18:29 ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox