Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] freescale-imx: Add helper to extract self-extractible binaries
Date: Tue, 18 Nov 2014 23:08:25 +0100	[thread overview]
Message-ID: <20141118220825.GN4333@free.fr> (raw)
In-Reply-To: <1415376207-23292-2-git-send-email-jezz@sysmic.org>

J?r?me, All,

Coming back on that one...

On 2014-11-07 17:03 +0100, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
>  package/freescale-imx/freescale-imx.mk | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/package/freescale-imx/freescale-imx.mk b/package/freescale-imx/freescale-imx.mk
> index c52fc11..38774ca 100644
> --- a/package/freescale-imx/freescale-imx.mk
> +++ b/package/freescale-imx/freescale-imx.mk
> @@ -7,4 +7,25 @@
>  FREESCALE_IMX_VERSION = 3.10.17-1.0.0
>  FREESCALE_IMX_SITE = http://www.freescale.com/lgfiles/NMG/MAD/YOCTO
>  
> +# Helper for self-extracting binaries distributed by Freescale.
> +# The --force makes sure it doesn't fail if the source dir already exists.
> +# The --auto-accept skips the license check - not needed for us
> +# because we have legal-info
> +# Since there's a EULA in the bin file, extract it
> +# If you use this macro, don't forget to add "EULA" to LICENSE_FILES and set
> +# REDISTRIBUTE to "NO". Indeed, this is a legal minefield:
> +# the EULA specifies that the Board Support Package includes software
> +# and hardware (sic!) for which a separate license is needed...
> +define FREESCALE_IMX_EXTRACT_HELPER
> +	awk 'BEGIN      { start = 0; } \
> +	     /^EOEULA/  { start = 0; } \
> +	                { if (start) print; } \
> +	     /<<EOEULA/ { start = 1; }' \
> +	    $(DL_DIR)/$(1) > $(@D)/EULA

I wonder if we would not be better off passing the full path to the
firmware file, from the caller, i.e.:

    $(call FREESCALE_IMX_EXTRACT_HELPER,$(DL_DIR)/$(firmware_file))

Regards,
Yann E. MORIN.

> +	cd $(@D) && sh $(DL_DIR)/$(1) --force --auto-accept;
> +	find $(@D)/$(basename $(1)) -mindepth 1 -maxdepth 1 -exec mv {} $(@D) \;
> +	rmdir $(@D)/$(basename $(1))
> +endef
> +
> +
>  include $(sort $(wildcard package/freescale-imx/*/*.mk))
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-18 22:08 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 16:03 [Buildroot] [PATCH 0/7] Better handling of freescale self-extractible binaries Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 1/7] freescale-imx: Add helper to extract " Jérôme Pouiller
2014-11-18 22:08   ` Yann E. MORIN [this message]
2014-11-07 16:03 ` [Buildroot] [PATCH 2/7] firmware-imx: Use self-extractible helper Jérôme Pouiller
2014-11-18 22:09   ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 3/7] imx-vpu: " Jérôme Pouiller
2014-11-18 22:12   ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 4/7] libfsl*: " Jérôme Pouiller
2014-11-18 22:13   ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 5/7] gpu-viv-bin-mx6q: " Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 6/7] libz160: " Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 7/7] gpu-amd-bin-mx51: " Jérôme Pouiller
2014-11-18 22:16 ` [Buildroot] [PATCH 0/7] Better handling of freescale self-extractible binaries Yann E. MORIN
2014-11-19 20:25   ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118220825.GN4333@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox