From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/7] firmware-imx: Use self-extractible helper
Date: Tue, 18 Nov 2014 23:09:46 +0100 [thread overview]
Message-ID: <20141118220946.GO4333@free.fr> (raw)
In-Reply-To: <1415376207-23292-3-git-send-email-jezz@sysmic.org>
J?r?me, All,
On 2014-11-07 17:03 +0100, J?r?me Pouiller spake thusly:
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
> ---
> package/freescale-imx/firmware-imx/firmware-imx.mk | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
> index d26b31c..c0d3d44 100644
> --- a/package/freescale-imx/firmware-imx/firmware-imx.mk
> +++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
> @@ -7,27 +7,19 @@
> FIRMWARE_IMX_VERSION = $(FREESCALE_IMX_VERSION)
> FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
> FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
> +
> +# See freescale-imx.mk
> FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \
> Atheros license (ath6k)
> -FIRMWARE_IMX_LICENSE_FILES = licenses/vpu/EULA licenses/ath6k/AR6102/License.txt
> -# This is a legal minefield: the EULA specifies that
> -# the Board Support Package includes software and hardware (sic!)
> -# for which a separate license is needed...
> +FIRMWARE_IMX_LICENSE_FILES = EULA licenses/vpu/EULA licenses/ath6k/AR6102/License.txt
> FIRMWARE_IMX_REDISTRIBUTE = NO
>
> FIRMWARE_IMX_BLOBS = ath6k sdma vpu
>
> -# The archive is a shell-self-extractor of a bzipped tar. It happens
> -# to extract in the correct directory (firmware-imx-x.y.z)
> -# The --force makes sure it doesn't fail if the source dir already exists.
> -# The --auto-accept skips the license check - not needed for us
> -# because we have legal-info.
> define FIRMWARE_IMX_EXTRACT_CMDS
> - cd $(BUILD_DIR); \
> - sh $(DL_DIR)/$(FIRMWARE_IMX_SOURCE) --force --auto-accept
> + $(call FREESCALE_IMX_EXTRACT_HELPER,$(FIRMWARE_IMX_SOURCE))
Pass the full path from here.
Otherwise, looks good. On your v2, your can add my:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> endef
>
> -
> define FIRMWARE_IMX_INSTALL_TARGET_CMDS
> mkdir -p $(TARGET_DIR)/lib/firmware
> for blobdir in $(FIRMWARE_IMX_BLOBS); do \
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-18 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 16:03 [Buildroot] [PATCH 0/7] Better handling of freescale self-extractible binaries Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 1/7] freescale-imx: Add helper to extract " Jérôme Pouiller
2014-11-18 22:08 ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 2/7] firmware-imx: Use self-extractible helper Jérôme Pouiller
2014-11-18 22:09 ` Yann E. MORIN [this message]
2014-11-07 16:03 ` [Buildroot] [PATCH 3/7] imx-vpu: " Jérôme Pouiller
2014-11-18 22:12 ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 4/7] libfsl*: " Jérôme Pouiller
2014-11-18 22:13 ` Yann E. MORIN
2014-11-07 16:03 ` [Buildroot] [PATCH 5/7] gpu-viv-bin-mx6q: " Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 6/7] libz160: " Jérôme Pouiller
2014-11-07 16:03 ` [Buildroot] [PATCH 7/7] gpu-amd-bin-mx51: " Jérôme Pouiller
2014-11-18 22:16 ` [Buildroot] [PATCH 0/7] Better handling of freescale self-extractible binaries Yann E. MORIN
2014-11-19 20:25 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118220946.GO4333@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox